From 8b56786be5734be575cf0e9caabc8011e01e035f Mon Sep 17 00:00:00 2001 From: Jakob Schott Date: Mon, 19 May 2025 23:20:18 +0200 Subject: [PATCH] Updated test to reflect code changes --- apps/web/app/lib/survey-builder.test.ts | 12 ++++++------ .../src/components/questions/nps-question.test.tsx | 13 ------------- .../questions/open-text-question.test.tsx | 2 +- .../questions/picture-selection-question.test.tsx | 2 +- .../src/components/wrappers/stacked-card.test.tsx | 2 +- 5 files changed, 9 insertions(+), 22 deletions(-) diff --git a/apps/web/app/lib/survey-builder.test.ts b/apps/web/app/lib/survey-builder.test.ts index 5a78d2e0a8..6bd9ecf233 100644 --- a/apps/web/app/lib/survey-builder.test.ts +++ b/apps/web/app/lib/survey-builder.test.ts @@ -41,7 +41,7 @@ describe("Survey Builder", () => { buttonLabel: { default: "common.next" }, backButtonLabel: { default: "common.back" }, shuffleOption: "none", - required: true, + required: false, }); expect(question.choices.length).toBe(3); expect(question.id).toBeDefined(); @@ -141,7 +141,7 @@ describe("Survey Builder", () => { inputType: "text", buttonLabel: { default: "common.next" }, backButtonLabel: { default: "common.back" }, - required: true, + required: false, charLimit: { enabled: false, }, @@ -204,7 +204,7 @@ describe("Survey Builder", () => { range: 5, buttonLabel: { default: "common.next" }, backButtonLabel: { default: "common.back" }, - required: true, + required: false, isColorCodingEnabled: false, }); expect(question.id).toBeDefined(); @@ -265,7 +265,7 @@ describe("Survey Builder", () => { headline: { default: "NPS Question" }, buttonLabel: { default: "common.next" }, backButtonLabel: { default: "common.back" }, - required: true, + required: false, isColorCodingEnabled: false, }); expect(question.id).toBeDefined(); @@ -324,7 +324,7 @@ describe("Survey Builder", () => { label: { default: "I agree to terms" }, buttonLabel: { default: "common.next" }, backButtonLabel: { default: "common.back" }, - required: true, + required: false, }); expect(question.id).toBeDefined(); }); @@ -377,7 +377,7 @@ describe("Survey Builder", () => { headline: { default: "CTA Question" }, buttonLabel: { default: "common.next" }, backButtonLabel: { default: "common.back" }, - required: true, + required: false, buttonExternal: false, }); expect(question.id).toBeDefined(); diff --git a/packages/surveys/src/components/questions/nps-question.test.tsx b/packages/surveys/src/components/questions/nps-question.test.tsx index 8f3837f440..80a6c79d1c 100644 --- a/packages/surveys/src/components/questions/nps-question.test.tsx +++ b/packages/surveys/src/components/questions/nps-question.test.tsx @@ -167,19 +167,6 @@ describe("NPSQuestion", () => { expect(getUpdatedTtc).toHaveBeenCalled(); }); - test("updates hover state when mouse moves over options", () => { - render(); - - const option = screen.getByText("5").closest("label"); - expect(option).toBeInTheDocument(); - - fireEvent.mouseOver(option!); - expect(option).toHaveClass("fb-bg-accent-bg"); - - fireEvent.mouseLeave(option!); - expect(option).not.toHaveClass("fb-bg-accent-bg"); - }); - test("supports keyboard navigation", () => { render(); diff --git a/packages/surveys/src/components/questions/open-text-question.test.tsx b/packages/surveys/src/components/questions/open-text-question.test.tsx index 0bff21b187..f2b2b8128a 100644 --- a/packages/surveys/src/components/questions/open-text-question.test.tsx +++ b/packages/surveys/src/components/questions/open-text-question.test.tsx @@ -122,7 +122,7 @@ describe("OpenTextQuestion", () => { test("renders textarea for long answers", () => { render(); - expect(screen.getByRole("textbox")).toHaveAttribute("rows", "3"); + expect(screen.getByRole("textbox")).toHaveAttribute("rows", "5"); }); test("displays character limit when configured", () => { diff --git a/packages/surveys/src/components/questions/picture-selection-question.test.tsx b/packages/surveys/src/components/questions/picture-selection-question.test.tsx index 15f9795d97..803e9c64e9 100644 --- a/packages/surveys/src/components/questions/picture-selection-question.test.tsx +++ b/packages/surveys/src/components/questions/picture-selection-question.test.tsx @@ -171,7 +171,7 @@ describe("PictureSelectionQuestion", () => { render(); const images = screen.getAllByRole("img"); - const label = images[0].closest("label"); + const label = images[0].closest("button"); fireEvent.keyDown(label!, { key: " " }); diff --git a/packages/surveys/src/components/wrappers/stacked-card.test.tsx b/packages/surveys/src/components/wrappers/stacked-card.test.tsx index d7bd34440d..7a60385d76 100644 --- a/packages/surveys/src/components/wrappers/stacked-card.test.tsx +++ b/packages/surveys/src/components/wrappers/stacked-card.test.tsx @@ -183,7 +183,7 @@ describe("StackedCard", () => { test("card height is initial when offset is < 0 and not fullSizeCards", () => { render(); const card = screen.getByTestId("questionCard-0"); - expect(card).toHaveStyle("height: initial"); + expect(card).toHaveStyle(`height: ${defaultProps.cardHeight}`); }); test("card height is cardHeight when offset > 0 and not fullSizeCards", () => {