From 8ef74fdaff5acf059889a49d7e9a28768ae8a905 Mon Sep 17 00:00:00 2001
From: Shubham Palriwala <spalriwalau@gmail.com>
Date: Fri, 12 Apr 2024 16:40:20 +0530
Subject: [PATCH] fix: constants timeframe in seconds (#2434)

---
 apps/web/app/middleware/rateLimit.ts |  2 +-
 packages/lib/constants.ts            | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/apps/web/app/middleware/rateLimit.ts b/apps/web/app/middleware/rateLimit.ts
index da7d4636a1..5cbd8d58a0 100644
--- a/apps/web/app/middleware/rateLimit.ts
+++ b/apps/web/app/middleware/rateLimit.ts
@@ -10,7 +10,7 @@ type Options = {
 const inMemoryRateLimiter = (options: Options) => {
   const tokenCache = new LRUCache<string, number>({
     max: 1000,
-    ttl: options.interval,
+    ttl: options.interval * 1000, // converts to expected input of milliseconds
   });
 
   return async (token: string) => {
diff --git a/packages/lib/constants.ts b/packages/lib/constants.ts
index 94d55655d5..aae1ecf67a 100644
--- a/packages/lib/constants.ts
+++ b/packages/lib/constants.ts
@@ -150,24 +150,24 @@ export const SURVEY_BG_COLORS = [
 
 // Rate Limiting
 export const SIGNUP_RATE_LIMIT = {
-  interval: 60 * 60 * 1000, // 60 minutes
+  interval: 60 * 60, // 60 minutes
   allowedPerInterval: 30,
 };
 export const LOGIN_RATE_LIMIT = {
-  interval: 15 * 60 * 1000, // 15 minutes
+  interval: 15 * 60, // 15 minutes
   allowedPerInterval: 30,
 };
 export const CLIENT_SIDE_API_RATE_LIMIT = {
-  interval: 5 * 60 * 1000, // 5 minutes
+  interval: 5 * 60, // 5 minutes
   allowedPerInterval: 200,
 };
 export const SHARE_RATE_LIMIT = {
-  interval: 60 * 60 * 1000, // 60 minutes
+  interval: 60 * 60, // 60 minutes
   allowedPerInterval: 30,
 };
 
 export const SYNC_USER_IDENTIFICATION_RATE_LIMIT = {
-  interval: 60 * 1000, // 1 minute
+  interval: 60, // 1 minute
   allowedPerInterval: 5,
 };