fix: new ending card not expanding (#4526)

Co-authored-by: Anshuman Pandey <54475686+pandeymangg@users.noreply.github.com>

apps/web/app/(app)/(survey-editor)/environments/[environmentId]/surveys/[surveyId]/edit/components/QuestionsDroppable.tsx

@@ -18,7 +18,6 @@ interface QuestionsDraggableProps {
   selectedLanguageCode: string;
   setSelectedLanguageCode: (language: string) => void;
   invalidQuestions: string[] | null;
-  internalQuestionIdMap: Record<string, string>;
   contactAttributeKeys: TContactAttributeKey[];
   addQuestion: (question: any, index?: number) => void;
   isFormbricksCloud: boolean;
@@ -38,7 +37,6 @@ export const QuestionsDroppable = ({
   setActiveQuestionId,
   setSelectedLanguageCode,
   updateQuestion,
-  internalQuestionIdMap,
   contactAttributeKeys,
   addQuestion,
   isFormbricksCloud,
@@ -52,7 +50,7 @@ export const QuestionsDroppable = ({
       <SortableContext items={localSurvey.questions} strategy={verticalListSortingStrategy}>
         {localSurvey.questions.map((question, questionIdx) => (
           <QuestionCard
-            key={internalQuestionIdMap[question.id]}
+            key={question.id}
             localSurvey={localSurvey}
             project={project}
             question={question}

apps/web/app/(app)/(survey-editor)/environments/[environmentId]/surveys/[surveyId]/edit/components/QuestionsView.tsx

@@ -344,6 +344,7 @@ export const QuestionsView = ({
     const newEndingCard = getDefaultEndingCard(localSurvey.languages, locale);
 
     updatedSurvey.endings.splice(index, 0, newEndingCard);
+    setActiveQuestionId(newEndingCard.id);
 
     setLocalSurvey(updatedSurvey);
   };
@@ -457,7 +458,6 @@ export const QuestionsView = ({
           activeQuestionId={activeQuestionId}
           setActiveQuestionId={setActiveQuestionId}
           invalidQuestions={invalidQuestions}
-          internalQuestionIdMap={internalQuestionIdMap}
           contactAttributeKeys={contactAttributeKeys}
           addQuestion={addQuestion}
           isFormbricksCloud={isFormbricksCloud}