From ca19ee6e0f65a6ce4a5e02c529e642315accca71 Mon Sep 17 00:00:00 2001 From: Matti Nannt Date: Thu, 28 Sep 2023 13:02:41 +0200 Subject: [PATCH] fix: formbricks-js not displaying properly on smaller screens (#866) --- packages/js/src/lib/eventListeners.ts | 4 +-- packages/js/src/lib/init.ts | 2 +- packages/surveys/src/components/Modal.tsx | 30 +++-------------------- 3 files changed, 6 insertions(+), 30 deletions(-) diff --git a/packages/js/src/lib/eventListeners.ts b/packages/js/src/lib/eventListeners.ts index 017a4acbb3..193ec5ca0b 100644 --- a/packages/js/src/lib/eventListeners.ts +++ b/packages/js/src/lib/eventListeners.ts @@ -14,8 +14,8 @@ import { addSyncEventListener, removeSyncEventListener } from "./sync"; let areRemoveEventListenersAdded = false; -export const addEventListeners = (): void => { - addSyncEventListener(); +export const addEventListeners = (debug: boolean = false): void => { + addSyncEventListener(debug); addPageUrlEventListeners(); addClickEventListener(); addExitIntentListener(); diff --git a/packages/js/src/lib/init.ts b/packages/js/src/lib/init.ts index c32438f4f6..591b1bc65c 100644 --- a/packages/js/src/lib/init.ts +++ b/packages/js/src/lib/init.ts @@ -97,7 +97,7 @@ export const initialize = async ( } logger.debug("Adding event listeners"); - addEventListeners(); + addEventListeners(c.debug); addCleanupEventListeners(); isInitialized = true; diff --git a/packages/surveys/src/components/Modal.tsx b/packages/surveys/src/components/Modal.tsx index 38f66ef06c..266de35761 100644 --- a/packages/surveys/src/components/Modal.tsx +++ b/packages/surveys/src/components/Modal.tsx @@ -3,12 +3,6 @@ import { VNode } from "preact"; import { useEffect, useMemo, useRef, useState } from "preact/hooks"; import { cn } from "../lib/utils"; -// CSS classes object -const mobileClasses = { - show: "translate-y-full", - hide: "translate-y-0", -}; - interface ModalProps { children: VNode; isOpen: boolean; @@ -29,7 +23,6 @@ export default function Modal({ onClose, }: ModalProps) { const [show, setShow] = useState(false); - const [isMobile, setIsMobile] = useState(false); const isCenter = placement === "center"; const modalRef = useRef(null); @@ -56,21 +49,6 @@ export default function Modal({ }; }, [show, clickOutside, onClose, isCenter]); - const handleMobileClasses = (isMobile: boolean, show: boolean) => { - return isMobile ? (show ? mobileClasses.show : mobileClasses.hide) : ""; - }; - - useEffect(() => { - const handleResize = () => { - setIsMobile(window.innerWidth < 640); - }; - window.addEventListener("resize", handleResize); - handleResize(); - return () => { - window.removeEventListener("resize", handleResize); - }; - }, []); - // This classes will be applied only when screen size is greater than sm, hence sm is common prefix for all const getPlacementStyle = (placement: PlacementType) => { switch (placement) { @@ -114,8 +92,8 @@ export default function Modal({ "relative h-full w-full", isCenter ? darkOverlay - ? "sm:bg-gray-700/80" - : "sm:bg-white/50" + ? "bg-gray-700/80" + : "bg-white/50" : "bg-none transition-all duration-500 ease-in-out" )}>
{!isCenter && (