bugfix #128

apps/web/lib/apiEvents.ts

@@ -48,10 +48,6 @@ export const processApiEvent = async (event: ApiEvent, formId) => {
   if (event.type === "pageSubmission") {
     const schema = form.schema as Schema;
     const { pageName } = event.data;
-    const pages = schema.pages.filter((page) => page.type === "form");
-
-    const indexOfPage = pages.findIndex((page) => page.name === pageName);
-    // const owner = form.owner;
 
     await prisma.sessionEvent.create({
       data: {
@@ -71,17 +67,23 @@ export const processApiEvent = async (event: ApiEvent, formId) => {
 
     sendTelemetry("pageSubmission received");
 
-    if (indexOfPage === pages.length - 1) {
-      processApiEvent(
-        {
-          ...event,
-          type: "formCompleted",
-          data: {
-            submissionSessionId: event.data.submissionSessionId,
+    if ("pages" in schema) {
+      const pages = schema.pages.filter((page) => page.type === "form");
+
+      const indexOfPage = pages.findIndex((page) => page.name === pageName);
+
+      if (indexOfPage === pages.length - 1) {
+        processApiEvent(
+          {
+            ...event,
+            type: "formCompleted",
+            data: {
+              submissionSessionId: event.data.submissionSessionId,
+            },
           },
-        },
-        formId
-      );
+          formId
+        );
+      }
     }
   } else if (event.type === "formCompleted") {
     await prisma.sessionEvent.create({
@@ -100,7 +102,7 @@ export const processApiEvent = async (event: ApiEvent, formId) => {
     sendTelemetry("formCompleted received");
   } else if (event.type === "updateSchema") {
     const data = { schema: event.data, updatedAt: new Date() };
-    prisma.form.update({
+    await prisma.form.update({
       where: { id: formId },
       data,
     });

prisma/migrations/20221009122833_add_email_notification_pipeline_type/migration.sql

@@ -1,2 +0,0 @@
--- AlterEnum
-ALTER TYPE "PipelineType" ADD VALUE 'EMAIL_NOTIFICATION';

prisma/migrations/20221009123056_add_form_completed/migration.sql

@@ -1,2 +0,0 @@
--- AlterEnum
-ALTER TYPE "PipelineEvent" ADD VALUE 'FORM_COMPLETED';