From ef7df0fc77296fe6cc4336a8951bfd5ae703d064 Mon Sep 17 00:00:00 2001
From: Aditya Deshlahre <132184385+adityadeshlahre@users.noreply.github.com>
Date: Sat, 26 Oct 2024 02:48:38 +0530
Subject: [PATCH] fix: added webhook url test for a valid URL (#4007)

Co-authored-by: Matthias Nannt <mail@matthiasnannt.com>
Co-authored-by: Johannes <72809645+jobenjada@users.noreply.github.com>
---
 .../webhooks/components/AddWebhookModal.tsx   |  6 +++
 .../components/WebhookSettingsTab.tsx         |  6 +++
 .../integrations/webhooks/lib/utils.ts        | 37 +++++++++++++++++++
 3 files changed, 49 insertions(+)
 create mode 100644 apps/web/app/(app)/environments/[environmentId]/integrations/webhooks/lib/utils.ts

diff --git a/apps/web/app/(app)/environments/[environmentId]/integrations/webhooks/components/AddWebhookModal.tsx b/apps/web/app/(app)/environments/[environmentId]/integrations/webhooks/components/AddWebhookModal.tsx
index c68fc18560..366d1af355 100644
--- a/apps/web/app/(app)/environments/[environmentId]/integrations/webhooks/components/AddWebhookModal.tsx
+++ b/apps/web/app/(app)/environments/[environmentId]/integrations/webhooks/components/AddWebhookModal.tsx
@@ -1,6 +1,7 @@
 import { triggers } from "@/app/(app)/environments/[environmentId]/integrations/webhooks/components/HardcodedTriggers";
 import { SurveyCheckboxGroup } from "@/app/(app)/environments/[environmentId]/integrations/webhooks/components/SurveyCheckboxGroup";
 import { TriggerCheckboxGroup } from "@/app/(app)/environments/[environmentId]/integrations/webhooks/components/TriggerCheckboxGroup";
+import { validWebHookURL } from "@/app/(app)/environments/[environmentId]/integrations/webhooks/lib/utils";
 import clsx from "clsx";
 import { Webhook } from "lucide-react";
 import { useRouter } from "next/navigation";
@@ -42,6 +43,11 @@ export const AddWebhookModal = ({ environmentId, surveys, open, setOpen }: AddWe
 
   const handleTestEndpoint = async (sendSuccessToast: boolean) => {
     try {
+      const { valid, error } = validWebHookURL(testEndpointInput);
+      if (!valid) {
+        toast.error(error ?? "Something went wrong please try again!");
+        return;
+      }
       setHittingEndpoint(true);
       await testEndpointAction({ url: testEndpointInput });
       setHittingEndpoint(false);
diff --git a/apps/web/app/(app)/environments/[environmentId]/integrations/webhooks/components/WebhookSettingsTab.tsx b/apps/web/app/(app)/environments/[environmentId]/integrations/webhooks/components/WebhookSettingsTab.tsx
index d0bd643907..64bf1a4da8 100644
--- a/apps/web/app/(app)/environments/[environmentId]/integrations/webhooks/components/WebhookSettingsTab.tsx
+++ b/apps/web/app/(app)/environments/[environmentId]/integrations/webhooks/components/WebhookSettingsTab.tsx
@@ -3,6 +3,7 @@
 import { triggers } from "@/app/(app)/environments/[environmentId]/integrations/webhooks/components/HardcodedTriggers";
 import { SurveyCheckboxGroup } from "@/app/(app)/environments/[environmentId]/integrations/webhooks/components/SurveyCheckboxGroup";
 import { TriggerCheckboxGroup } from "@/app/(app)/environments/[environmentId]/integrations/webhooks/components/TriggerCheckboxGroup";
+import { validWebHookURL } from "@/app/(app)/environments/[environmentId]/integrations/webhooks/lib/utils";
 import clsx from "clsx";
 import { TrashIcon } from "lucide-react";
 import { useRouter } from "next/navigation";
@@ -46,6 +47,11 @@ export const WebhookSettingsTab = ({ webhook, surveys, setOpen }: ActionSettings
 
   const handleTestEndpoint = async (sendSuccessToast: boolean) => {
     try {
+      const { valid, error } = validWebHookURL(testEndpointInput);
+      if (!valid) {
+        toast.error(error ?? "Something went wrong please try again!");
+        return;
+      }
       setHittingEndpoint(true);
       await testEndpointAction({ url: testEndpointInput });
       setHittingEndpoint(false);
diff --git a/apps/web/app/(app)/environments/[environmentId]/integrations/webhooks/lib/utils.ts b/apps/web/app/(app)/environments/[environmentId]/integrations/webhooks/lib/utils.ts
new file mode 100644
index 0000000000..c50a276b0d
--- /dev/null
+++ b/apps/web/app/(app)/environments/[environmentId]/integrations/webhooks/lib/utils.ts
@@ -0,0 +1,37 @@
+export const validWebHookURL = (urlInput: string) => {
+  const trimmedInput = urlInput.trim();
+  if (!trimmedInput) {
+    return { valid: false, error: "Please enter a URL" };
+  }
+
+  try {
+    const url = new URL(trimmedInput);
+
+    if (url.protocol !== "https:") {
+      return { valid: false, error: "URL must start with https://" };
+    }
+
+    const domainError: string =
+      "Please enter a complete URL with a valid domain (e.g., https://formbricks.com)";
+
+    const multipleSlashesPattern = /(?<!:)\/\/+/;
+    if (multipleSlashesPattern.test(trimmedInput)) {
+      return {
+        valid: false,
+        error: domainError,
+      };
+    }
+
+    const validDomainPattern = /^[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$/;
+    if (!validDomainPattern.test(url.hostname)) {
+      return {
+        valid: false,
+        error: domainError,
+      };
+    }
+
+    return { valid: true };
+  } catch (error) {
+    return { valid: false, error: "Invalid URL format. Please enter a complete URL including https://" };
+  }
+};