Compare commits

...

4 Commits

Author SHA1 Message Date
Dhruwang
75d63e1f75 fix test 2025-09-01 15:51:50 +05:30
Dhruwang
8358c863a0 reverted to old styling and tweaked it 2025-09-01 15:50:48 +05:30
ompharate
0a969b476e fix: add rel attribute to Link for security improvements 2025-08-25 12:33:12 +05:30
ompharate
f6c91540e3 fix(tooltip): wrap TooltipContent in a Portal for improved rendering 2025-08-22 19:36:25 +05:30
3 changed files with 20 additions and 12 deletions

View File

@@ -283,12 +283,13 @@ export const generateResponseTableColumns = (
<TooltipTrigger> <TooltipTrigger>
<CircleHelpIcon className="h-3 w-3 text-slate-500" strokeWidth={1.5} /> <CircleHelpIcon className="h-3 w-3 text-slate-500" strokeWidth={1.5} />
</TooltipTrigger> </TooltipTrigger>
<TooltipContent side="bottom" className="font-normal"> <TooltipContent side="bottom" className="space-x-1 font-normal">
{t("environments.surveys.responses.how_to_identify_users")} <span>{t("environments.surveys.responses.how_to_identify_users")}</span>
<Link <Link
className="underline underline-offset-2 hover:text-slate-900" className="underline underline-offset-2 hover:text-slate-900"
href="https://formbricks.com/docs/app-surveys/user-identification" href="https://formbricks.com/docs/app-surveys/user-identification"
target="_blank"> target="_blank"
rel="noopener noreferrer">
{t("common.app_survey")} {t("common.app_survey")}
</Link> </Link>
</TooltipContent> </TooltipContent>

View File

@@ -30,6 +30,11 @@ vi.mock("@radix-ui/react-tooltip", () => ({
{children} {children}
</div> </div>
), ),
Portal: ({ children, ...props }: any) => (
<div data-testid="tooltip-portal" {...props}>
{children}
</div>
),
})); }));
describe("Tooltip", () => { describe("Tooltip", () => {

View File

@@ -18,15 +18,17 @@ const TooltipContent: React.ComponentType<TooltipPrimitive.TooltipContentProps>
React.ElementRef<typeof TooltipPrimitive.Content>, React.ElementRef<typeof TooltipPrimitive.Content>,
React.ComponentPropsWithoutRef<typeof TooltipPrimitive.Content> React.ComponentPropsWithoutRef<typeof TooltipPrimitive.Content>
>(({ className, sideOffset = 4, ...props }, ref) => ( >(({ className, sideOffset = 4, ...props }, ref) => (
<TooltipPrimitive.Content <TooltipPrimitive.Portal>
ref={ref} <TooltipPrimitive.Content
sideOffset={sideOffset} ref={ref}
className={cn( sideOffset={sideOffset}
"animate-in fade-in-50 data-[side=bottom]:slide-in-from-top-1 data-[side=top]:slide-in-from-bottom-1 data-[side=left]:slide-in-from-right-1 data-[side=right]:slide-in-from-left-1 z-50 overflow-hidden rounded-md border border-slate-100 bg-white px-3 py-1.5 text-sm text-slate-700 shadow-md", className={cn(
className "animate-in fade-in-50 data-[side=bottom]:slide-in-from-top-1 data-[side=top]:slide-in-from-bottom-1 data-[side=left]:slide-in-from-right-1 data-[side=right]:slide-in-from-left-1 z-50 overflow-hidden rounded-md border border-slate-100 bg-white px-3 py-1.5 text-sm text-slate-700 shadow-md",
)} className
{...props} )}
/> {...props}
/>
</TooltipPrimitive.Portal>
)); ));
TooltipContent.displayName = TooltipPrimitive.Content.displayName; TooltipContent.displayName = TooltipPrimitive.Content.displayName;