fix: fixes storage resolution issues (#7310) (#7319)

Co-authored-by: Cursor <cursoragent@cursor.com>

apps/web/app/middleware/endpoint-validator.test.ts

@@ -257,7 +257,6 @@ describe("endpoint-validator", () => {
       expect(isAuthProtectedRoute("/api/v1/client/test")).toBe(false);
       expect(isAuthProtectedRoute("/")).toBe(false);
       expect(isAuthProtectedRoute("/s/survey123")).toBe(false);
-      expect(isAuthProtectedRoute("/p/pretty-url")).toBe(false);
       expect(isAuthProtectedRoute("/c/jwt-token")).toBe(false);
       expect(isAuthProtectedRoute("/health")).toBe(false);
     });
@@ -313,19 +312,6 @@ describe("endpoint-validator", () => {
       expect(isPublicDomainRoute("/c")).toBe(false);
       expect(isPublicDomainRoute("/contact/token")).toBe(false);
     });
-    
-    test("should return true for pretty URL survey routes", () => {
-      expect(isPublicDomainRoute("/p/pretty123")).toBe(true);
-      expect(isPublicDomainRoute("/p/pretty-name-with-dashes")).toBe(true);
-      expect(isPublicDomainRoute("/p/survey_id_with_underscores")).toBe(true);
-      expect(isPublicDomainRoute("/p/abc123def456")).toBe(true);
-    });
-
-    test("should return false for malformed pretty URL survey routes", () => {
-      expect(isPublicDomainRoute("/p/")).toBe(false);
-      expect(isPublicDomainRoute("/p")).toBe(false);
-      expect(isPublicDomainRoute("/pretty/123")).toBe(false);
-    });
 
     test("should return true for client API routes", () => {
       expect(isPublicDomainRoute("/api/v1/client/something")).toBe(true);
@@ -389,8 +375,6 @@ describe("endpoint-validator", () => {
       expect(isAdminDomainRoute("/s/survey-id-with-dashes")).toBe(false);
       expect(isAdminDomainRoute("/c/jwt-token")).toBe(false);
       expect(isAdminDomainRoute("/c/very-long-jwt-token-123")).toBe(false);
-      expect(isAdminDomainRoute("/p/pretty123")).toBe(false);
-      expect(isAdminDomainRoute("/p/pretty-name-with-dashes")).toBe(false);
       expect(isAdminDomainRoute("/api/v1/client/test")).toBe(false);
       expect(isAdminDomainRoute("/api/v2/client/other")).toBe(false);
     });
@@ -406,7 +390,6 @@ describe("endpoint-validator", () => {
       test("should allow public routes on public domain", () => {
         expect(isRouteAllowedForDomain("/s/survey123", true)).toBe(true);
         expect(isRouteAllowedForDomain("/c/jwt-token", true)).toBe(true);
-        expect(isRouteAllowedForDomain("/p/pretty123", true)).toBe(true);
         expect(isRouteAllowedForDomain("/api/v1/client/test", true)).toBe(true);
         expect(isRouteAllowedForDomain("/api/v2/client/other", true)).toBe(true);
         expect(isRouteAllowedForDomain("/health", true)).toBe(true);
@@ -443,8 +426,6 @@ describe("endpoint-validator", () => {
         expect(isRouteAllowedForDomain("/s/survey-id-with-dashes", false)).toBe(false);
         expect(isRouteAllowedForDomain("/c/jwt-token", false)).toBe(false);
         expect(isRouteAllowedForDomain("/c/very-long-jwt-token-123", false)).toBe(false);
-        expect(isRouteAllowedForDomain("/p/pretty123", false)).toBe(false);
-        expect(isRouteAllowedForDomain("/p/pretty-name-with-dashes", false)).toBe(false);
         expect(isRouteAllowedForDomain("/api/v1/client/test", false)).toBe(false);
         expect(isRouteAllowedForDomain("/api/v2/client/other", false)).toBe(false);
       });
@@ -459,8 +440,6 @@ describe("endpoint-validator", () => {
       test("should handle paths with query parameters and fragments", () => {
         expect(isRouteAllowedForDomain("/s/survey123?param=value", true)).toBe(true);
         expect(isRouteAllowedForDomain("/s/survey123#section", true)).toBe(true);
-        expect(isRouteAllowedForDomain("/p/pretty123?param=value", true)).toBe(true);
-        expect(isRouteAllowedForDomain("/p/pretty123#section", true)).toBe(true);
         expect(isRouteAllowedForDomain("/environments/123?tab=settings", true)).toBe(false);
         expect(isRouteAllowedForDomain("/environments/123?tab=settings", false)).toBe(true);
       });
@@ -471,7 +450,6 @@ describe("endpoint-validator", () => {
     describe("URL parsing edge cases", () => {
       test("should handle paths with query parameters", () => {
         expect(isPublicDomainRoute("/s/survey123?param=value&other=test")).toBe(true);
-        expect(isPublicDomainRoute("/p/pretty123?param=value&other=test")).toBe(true);
         expect(isPublicDomainRoute("/api/v1/client/test?query=data")).toBe(true);
         expect(isPublicDomainRoute("/environments/123?tab=settings")).toBe(false);
         expect(isAuthProtectedRoute("/environments/123?tab=overview")).toBe(true);
@@ -480,14 +458,12 @@ describe("endpoint-validator", () => {
       test("should handle paths with fragments", () => {
         expect(isPublicDomainRoute("/s/survey123#section")).toBe(true);
         expect(isPublicDomainRoute("/c/jwt-token#top")).toBe(true);
-        expect(isPublicDomainRoute("/p/pretty123#section")).toBe(true);
         expect(isPublicDomainRoute("/environments/123#overview")).toBe(false);
         expect(isAuthProtectedRoute("/organizations/456#settings")).toBe(true);
       });
 
       test("should handle trailing slashes", () => {
         expect(isPublicDomainRoute("/s/survey123/")).toBe(true);
-        expect(isPublicDomainRoute("/p/pretty123/")).toBe(true);
         expect(isPublicDomainRoute("/api/v1/client/test/")).toBe(true);
         expect(isManagementApiRoute("/api/v1/management/test/")).toEqual({
           isManagementApi: true,
@@ -502,9 +478,6 @@ describe("endpoint-validator", () => {
         expect(isPublicDomainRoute("/s/survey123/preview")).toBe(true);
         expect(isPublicDomainRoute("/s/survey123/embed")).toBe(true);
         expect(isPublicDomainRoute("/s/survey123/thank-you")).toBe(true);
-        expect(isPublicDomainRoute("/p/pretty123/preview")).toBe(true);
-        expect(isPublicDomainRoute("/p/pretty123/embed")).toBe(true);
-        expect(isPublicDomainRoute("/p/pretty123/thank-you")).toBe(true);
       });
 
       test("should handle nested client API routes", () => {
@@ -556,7 +529,6 @@ describe("endpoint-validator", () => {
       test("should handle special characters in survey IDs", () => {
         expect(isPublicDomainRoute("/s/survey-123_test.v2")).toBe(true);
         expect(isPublicDomainRoute("/c/jwt.token.with.dots")).toBe(true);
-        expect(isPublicDomainRoute("/p/pretty-123_test.v2")).toBe(true);
       });
     });
 
@@ -564,7 +536,6 @@ describe("endpoint-validator", () => {
       test("should properly validate malicious or injection-like URLs", () => {
         // SQL injection-like attempts
         expect(isPublicDomainRoute("/s/'; DROP TABLE users; --")).toBe(true); // Still valid survey ID format
-        expect(isPublicDomainRoute("/p/'; DROP TABLE users; --")).toBe(true);
         expect(isManagementApiRoute("/api/v1/management/'; DROP TABLE users; --")).toEqual({
           isManagementApi: true,
           authenticationMethod: AuthenticationMethod.ApiKey,
@@ -572,12 +543,10 @@ describe("endpoint-validator", () => {
 
         // Path traversal attempts
         expect(isPublicDomainRoute("/s/../../../etc/passwd")).toBe(true); // Still matches pattern
-        expect(isPublicDomainRoute("/p/../../../etc/passwd")).toBe(true);
         expect(isAuthProtectedRoute("/environments/../../../etc/passwd")).toBe(true);
 
         // XSS-like attempts
         expect(isPublicDomainRoute("/s/<script>alert('xss')</script>")).toBe(true);
-        expect(isPublicDomainRoute("/p/<script>alert('xss')</script>")).toBe(true);
         expect(isClientSideApiRoute("/api/v1/client/<script>alert('xss')</script>")).toEqual({
           isClientSideApi: true,
           isRateLimited: true,
@@ -587,7 +556,6 @@ describe("endpoint-validator", () => {
       test("should handle URL encoding", () => {
         expect(isPublicDomainRoute("/s/survey%20123")).toBe(true);
         expect(isPublicDomainRoute("/c/jwt%2Etoken")).toBe(true);
-        expect(isPublicDomainRoute("/p/pretty%20123")).toBe(true);
         expect(isAuthProtectedRoute("/environments%2F123")).toBe(true);
         expect(isManagementApiRoute("/api/v1/management/test%20route")).toEqual({
           isManagementApi: true,
@@ -623,7 +591,6 @@ describe("endpoint-validator", () => {
         // These should not match due to case sensitivity
         expect(isPublicDomainRoute("/S/survey123")).toBe(false);
         expect(isPublicDomainRoute("/C/jwt-token")).toBe(false);
-        expect(isPublicDomainRoute("/P/pretty123")).toBe(false);
         expect(isClientSideApiRoute("/API/V1/CLIENT/test")).toEqual({
           isClientSideApi: false,
           isRateLimited: true,

apps/web/app/middleware/route-config.ts

@@ -7,7 +7,6 @@ const PUBLIC_ROUTES = {
   SURVEY_ROUTES: [
     /^\/s\/[^/]+/, // /s/[surveyId] - survey pages
     /^\/c\/[^/]+/, // /c/[jwt] - contact survey pages
-    /^\/p\/[^/]+/, // /p/[prettyUrl] - pretty URL pages
   ],
 
   // API routes accessible from public domain

apps/web/modules/core/rate-limit/rate-limit-configs.ts

@@ -30,4 +30,4 @@ export const rateLimitConfigs = {
     upload: { interval: 60, allowedPerInterval: 5, namespace: "storage:upload" }, // 5 per minute
     delete: { interval: 60, allowedPerInterval: 5, namespace: "storage:delete" }, // 5 per minute
   },
-} as const;
+};

apps/web/modules/ee/contacts/segments/lib/filter/prisma-query.test.ts

@@ -1229,104 +1229,6 @@ describe("segmentFilterToPrismaQuery", () => {
     }
   });
 
-  test("number filter falls back to raw SQL when un-migrated rows exist", async () => {
-    mockFindFirst.mockResolvedValue({ id: "unmigrated-row-1" });
-    mockQueryRawUnsafe.mockResolvedValue([{ contactId: "mock-contact-1" }]);
-
-    const filters: TBaseFilters = [
-      {
-        id: "filter_1",
-        connector: null,
-        resource: {
-          id: "attr_1",
-          root: {
-            type: "attribute" as const,
-            contactAttributeKey: "age",
-          },
-          value: 25,
-          qualifier: {
-            operator: "greaterThan",
-          },
-        },
-      },
-    ];
-
-    const result = await segmentFilterToPrismaQuery(mockSegmentId, filters, mockEnvironmentId);
-
-    expect(result.ok).toBe(true);
-    if (result.ok) {
-      const filterClause = result.data.whereClause.AND?.[1] as any;
-      expect(filterClause.AND[0]).toEqual({
-        OR: [
-          {
-            attributes: {
-              some: {
-                attributeKey: { key: "age" },
-                valueNumber: { gt: 25 },
-              },
-            },
-          },
-          { id: { in: ["mock-contact-1"] } },
-        ],
-      });
-    }
-
-    expect(mockFindFirst).toHaveBeenCalledWith({
-      where: {
-        attributeKey: {
-          key: "age",
-          environmentId: mockEnvironmentId,
-          dataType: "number",
-        },
-        valueNumber: null,
-      },
-      select: { id: true },
-    });
-
-    expect(mockQueryRawUnsafe).toHaveBeenCalled();
-    const sqlCall = mockQueryRawUnsafe.mock.calls[0];
-    expect(sqlCall[0]).toContain('cak."environmentId" = $4');
-    expect(sqlCall[4]).toBe(mockEnvironmentId);
-  });
-
-  test("number filter uses clean Prisma query when backfill is complete", async () => {
-    const filters: TBaseFilters = [
-      {
-        id: "filter_1",
-        connector: null,
-        resource: {
-          id: "attr_1",
-          root: {
-            type: "attribute" as const,
-            contactAttributeKey: "score",
-          },
-          value: 100,
-          qualifier: {
-            operator: "lessEqual",
-          },
-        },
-      },
-    ];
-
-    const result = await segmentFilterToPrismaQuery(mockSegmentId, filters, mockEnvironmentId);
-
-    expect(result.ok).toBe(true);
-    if (result.ok) {
-      const filterClause = result.data.whereClause.AND?.[1] as any;
-      expect(filterClause.AND[0]).toEqual({
-        attributes: {
-          some: {
-            attributeKey: { key: "score" },
-            valueNumber: { lte: 100 },
-          },
-        },
-      });
-    }
-
-    expect(mockFindFirst).toHaveBeenCalled();
-    expect(mockQueryRawUnsafe).not.toHaveBeenCalled();
-  });
-
   // ==========================================
   // DATE FILTER TESTS
   // ==========================================

apps/web/modules/ee/contacts/segments/lib/segments.test.ts

@@ -37,7 +37,6 @@ vi.mock("@formbricks/database", () => ({
       create: vi.fn(),
       delete: vi.fn(),
       update: vi.fn(),
-      upsert: vi.fn(),
       findFirst: vi.fn(),
     },
     survey: {
@@ -207,73 +206,6 @@ describe("Segment Service Tests", () => {
       vi.mocked(prisma.segment.create).mockRejectedValue(new Error("DB error"));
       await expect(createSegment(mockSegmentCreateInput)).rejects.toThrow(Error);
     });
-
-    test("should upsert a private segment without surveyId", async () => {
-      const privateInput: TSegmentCreateInput = {
-        ...mockSegmentCreateInput,
-        isPrivate: true,
-      };
-      const privateSegmentPrisma = { ...mockSegmentPrisma, isPrivate: true };
-      vi.mocked(prisma.segment.upsert).mockResolvedValue(privateSegmentPrisma);
-      const segment = await createSegment(privateInput);
-      expect(segment).toEqual({ ...mockSegment, isPrivate: true });
-      expect(prisma.segment.upsert).toHaveBeenCalledWith({
-        where: {
-          environmentId_title: {
-            environmentId,
-            title: privateInput.title,
-          },
-        },
-        create: {
-          environmentId,
-          title: privateInput.title,
-          description: undefined,
-          isPrivate: true,
-          filters: [],
-        },
-        update: {
-          description: undefined,
-          filters: [],
-        },
-        select: selectSegment,
-      });
-      expect(prisma.segment.create).not.toHaveBeenCalled();
-    });
-
-    test("should upsert a private segment with surveyId", async () => {
-      const privateInputWithSurvey: TSegmentCreateInput = {
-        ...mockSegmentCreateInput,
-        isPrivate: true,
-        surveyId,
-      };
-      const privateSegmentPrisma = { ...mockSegmentPrisma, isPrivate: true };
-      vi.mocked(prisma.segment.upsert).mockResolvedValue(privateSegmentPrisma);
-      const segment = await createSegment(privateInputWithSurvey);
-      expect(segment).toEqual({ ...mockSegment, isPrivate: true });
-      expect(prisma.segment.upsert).toHaveBeenCalledWith({
-        where: {
-          environmentId_title: {
-            environmentId,
-            title: privateInputWithSurvey.title,
-          },
-        },
-        create: {
-          environmentId,
-          title: privateInputWithSurvey.title,
-          description: undefined,
-          isPrivate: true,
-          filters: [],
-          surveys: { connect: { id: surveyId } },
-        },
-        update: {
-          description: undefined,
-          filters: [],
-          surveys: { connect: { id: surveyId } },
-        },
-        select: selectSegment,
-      });
-      expect(prisma.segment.create).not.toHaveBeenCalled();
-    });
   });
 
   describe("cloneSegment", () => {

apps/web/modules/storage/utils.test.ts

@@ -8,8 +8,6 @@ import {
   isValidFileTypeForExtension,
   isValidImageFile,
   resolveStorageUrl,
-  resolveStorageUrlAuto,
-  resolveStorageUrlsInObject,
   sanitizeFileName,
   validateFileUploads,
   validateSingleFile,
@@ -408,7 +406,7 @@ describe("storage utils", () => {
       expect(resolveStorageUrl("")).toBe("");
     });
 
-    test("should return absolute URL unchanged", () => {
+    test("should return absolute URL unchanged (backward compatibility)", () => {
       const httpsUrl = "https://example.com/storage/env-123/public/image.jpg";
       const httpUrl = "http://example.com/storage/env-123/public/image.jpg";
 
@@ -417,12 +415,14 @@ describe("storage utils", () => {
     });
 
     test("should resolve relative /storage/ path to absolute URL", async () => {
+      // Use actual implementation with mocked dependencies
       const { resolveStorageUrl: actualResolveStorageUrl } =
         await vi.importActual<typeof import("@/modules/storage/utils")>("@/modules/storage/utils");
 
       const relativePath = "/storage/env-123/public/image.jpg";
       const result = actualResolveStorageUrl(relativePath);
 
+      // Should prepend the base URL (from mocked WEBAPP_URL or getPublicDomain)
       expect(result).toContain("/storage/env-123/public/image.jpg");
       expect(result.startsWith("http")).toBe(true);
     });
@@ -432,209 +432,4 @@ describe("storage utils", () => {
       expect(resolveStorageUrl("relative/path.jpg")).toBe("relative/path.jpg");
     });
   });
-
-  describe("resolveStorageUrlAuto", () => {
-    test("should return non-storage strings unchanged", () => {
-      expect(resolveStorageUrlAuto("hello world")).toBe("hello world");
-      expect(resolveStorageUrlAuto("/some/other/path")).toBe("/some/other/path");
-      expect(resolveStorageUrlAuto("https://example.com/image.jpg")).toBe("https://example.com/image.jpg");
-    });
-
-    test("should NOT transform free-text values that merely start with /storage/", () => {
-      expect(resolveStorageUrlAuto("/storage/help")).toBe("/storage/help");
-      expect(resolveStorageUrlAuto("/storage/")).toBe("/storage/");
-      expect(resolveStorageUrlAuto("/storage/some-text")).toBe("/storage/some-text");
-      expect(resolveStorageUrlAuto("/storage/foo/bar")).toBe("/storage/foo/bar");
-    });
-
-    test("should resolve public storage URL", async () => {
-      const { resolveStorageUrlAuto: actual } =
-        await vi.importActual<typeof import("@/modules/storage/utils")>("@/modules/storage/utils");
-
-      const result = actual("/storage/env-123/public/image.jpg");
-      expect(result).toContain("/storage/env-123/public/image.jpg");
-      expect(result.startsWith("http")).toBe(true);
-    });
-
-    test("should detect private access type from URL path", () => {
-      const privateUrl = "/storage/env-123/private/file.pdf";
-      const publicUrl = "/storage/env-123/public/image.jpg";
-
-      expect(privateUrl.includes("/private/")).toBe(true);
-      expect(publicUrl.includes("/private/")).toBe(false);
-    });
-  });
-
-  describe("resolveStorageUrlsInObject", () => {
-    test("should return null and undefined as-is", () => {
-      expect(resolveStorageUrlsInObject(null)).toBeNull();
-      expect(resolveStorageUrlsInObject(undefined)).toBeUndefined();
-    });
-
-    test("should return primitive values unchanged", () => {
-      expect(resolveStorageUrlsInObject(42)).toBe(42);
-      expect(resolveStorageUrlsInObject(true)).toBe(true);
-      expect(resolveStorageUrlsInObject("hello")).toBe("hello");
-    });
-
-    test("should NOT transform free-text that merely starts with /storage/", () => {
-      expect(resolveStorageUrlsInObject("/storage/help")).toBe("/storage/help");
-      expect(resolveStorageUrlsInObject("/storage/")).toBe("/storage/");
-
-      const input = {
-        questionId1: "/storage/",
-        questionId2: "/storage/help",
-        questionId3: "/storage/some-text",
-        questionId4: "/storage/foo/bar",
-        realUrl: "/storage/env-123/public/image.jpg",
-      };
-      const result = resolveStorageUrlsInObject(input);
-      expect(result.questionId1).toBe("/storage/");
-      expect(result.questionId2).toBe("/storage/help");
-      expect(result.questionId3).toBe("/storage/some-text");
-      expect(result.questionId4).toBe("/storage/foo/bar");
-      // realUrl still gets resolved because it matches the actual format
-      expect(result.realUrl).not.toBe("/storage/env-123/public/image.jpg");
-    });
-
-    test("should preserve Date instances", () => {
-      const date = new Date("2026-01-01");
-      expect(resolveStorageUrlsInObject(date)).toBe(date);
-    });
-
-    test("should resolve storage URL strings", async () => {
-      const { resolveStorageUrlsInObject: actual } =
-        await vi.importActual<typeof import("@/modules/storage/utils")>("@/modules/storage/utils");
-
-      const result = actual("/storage/env-123/public/image.jpg");
-      expect(typeof result).toBe("string");
-      expect(result).toContain("/storage/env-123/public/image.jpg");
-      expect((result as string).startsWith("http")).toBe(true);
-    });
-
-    test("should resolve URLs in arrays", async () => {
-      const { resolveStorageUrlsInObject: actual } =
-        await vi.importActual<typeof import("@/modules/storage/utils")>("@/modules/storage/utils");
-
-      const input = ["/storage/env-123/public/a.jpg", "plain text"];
-      const result = actual(input);
-
-      expect(result[0]).toContain("/storage/env-123/public/a.jpg");
-      expect(result[0].startsWith("http")).toBe(true);
-      expect(result[1]).toBe("plain text");
-    });
-
-    test("should resolve URLs in nested objects", async () => {
-      const { resolveStorageUrlsInObject: actual } =
-        await vi.importActual<typeof import("@/modules/storage/utils")>("@/modules/storage/utils");
-
-      const input = {
-        name: "Test Survey",
-        welcomeCard: {
-          fileUrl: "/storage/env-123/public/welcome.png",
-          headline: "Hello",
-        },
-        elements: [
-          {
-            imageUrl: "/storage/env-123/public/q1.jpg",
-            choices: [
-              { id: "c1", imageUrl: "/storage/env-123/public/choice1.jpg" },
-              { id: "c2", imageUrl: "https://external.com/image.jpg" },
-            ],
-          },
-        ],
-        count: 5,
-        createdAt: new Date("2026-01-01"),
-      };
-
-      const result = actual(input);
-
-      expect(result.welcomeCard.fileUrl.startsWith("http")).toBe(true);
-      expect(result.welcomeCard.headline).toBe("Hello");
-      expect(result.elements[0].imageUrl.startsWith("http")).toBe(true);
-      expect(result.elements[0].choices[0].imageUrl.startsWith("http")).toBe(true);
-      expect(result.elements[0].choices[1].imageUrl).toBe("https://external.com/image.jpg");
-      expect(result.count).toBe(5);
-      expect(result.createdAt).toEqual(new Date("2026-01-01"));
-      expect(result.name).toBe("Test Survey");
-    });
-
-    test("should resolve URLs in deeply nested objects", async () => {
-      const { resolveStorageUrlsInObject: actual } =
-        await vi.importActual<typeof import("@/modules/storage/utils")>("@/modules/storage/utils");
-
-      const input = {
-        level1: {
-          level2: {
-            level3: {
-              level4: {
-                level5: {
-                  imageUrl: "/storage/env-123/public/deep.png",
-                  items: [
-                    {
-                      nested: {
-                        url: "/storage/env-123/public/nested.jpg",
-                        label: "keep me",
-                      },
-                    },
-                    "plain string",
-                    42,
-                    null,
-                  ],
-                },
-              },
-              sibling: "/storage/env-123/public/sibling.png",
-            },
-          },
-          untouched: { a: { b: { c: "no change" } } },
-        },
-      };
-
-      const result = actual(input);
-
-      expect(result.level1.level2.level3.level4.level5.imageUrl).toContain(
-        "/storage/env-123/public/deep.png"
-      );
-      expect(result.level1.level2.level3.level4.level5.imageUrl.startsWith("http")).toBe(true);
-
-      // @ts-expect-error - items is an array of unknown types
-      expect(result.level1.level2.level3.level4.level5.items[0].nested.url).toContain(
-        "/storage/env-123/public/nested.jpg"
-      );
-      // @ts-expect-error - items is an array of unknown types
-      expect(result.level1.level2.level3.level4.level5.items[0].nested.url.startsWith("http")).toBe(true);
-      // @ts-expect-error - items is an array of unknown types
-      expect(result.level1.level2.level3.level4.level5.items[0].nested.label).toBe("keep me");
-
-      expect(result.level1.level2.level3.level4.level5.items[1]).toBe("plain string");
-      expect(result.level1.level2.level3.level4.level5.items[2]).toBe(42);
-      expect(result.level1.level2.level3.level4.level5.items[3]).toBeNull();
-
-      expect(result.level1.level2.level3.sibling).toContain("/storage/env-123/public/sibling.png");
-      expect(result.level1.level2.level3.sibling.startsWith("http")).toBe(true);
-
-      expect(result.level1.untouched.a.b.c).toBe("no change");
-    });
-
-    test("should handle response data with file upload URLs", async () => {
-      const { resolveStorageUrlsInObject: actual } =
-        await vi.importActual<typeof import("@/modules/storage/utils")>("@/modules/storage/utils");
-
-      const responseData = {
-        questionId1: "text answer",
-        questionId2: 42,
-        fileUploadId: ["/storage/env-123/public/doc.pdf", "/storage/env-123/public/img.png"],
-      };
-
-      const result = actual(responseData);
-
-      expect(result.questionId1).toBe("text answer");
-      expect(result.questionId2).toBe(42);
-      const fileUrls = result.fileUploadId;
-      expect(fileUrls[0]).toContain("/storage/env-123/public/doc.pdf");
-      expect(fileUrls[0].startsWith("http")).toBe(true);
-      expect(fileUrls[1]).toContain("/storage/env-123/public/img.png");
-      expect(fileUrls[1].startsWith("http")).toBe(true);
-    });
-  });
 });

apps/web/modules/ui/components/survey/index.tsx

@@ -40,10 +40,7 @@ export const SurveyInline = (props: Omit<SurveyContainerProps, "containerId">) =
     isLoadingScript = true;
     try {
       const scriptUrl = props.appUrl ? `${props.appUrl}/js/surveys.umd.cjs` : "/js/surveys.umd.cjs";
-      const response = await fetch(
-        scriptUrl,
-        process.env.NODE_ENV === "development" ? { cache: "no-store" } : {}
-      );
+      const response = await fetch(scriptUrl);
 
       if (!response.ok) {
         throw new Error("Failed to load the surveys package");

docs/self-hosting/advanced/migration.mdx

@@ -4,182 +4,12 @@ description: "Formbricks Self-hosted version migration"
 icon: "arrow-right"
 ---
 
-## v4.7
-
-Formbricks v4.7 introduces **typed contact attributes** with native `number` and `date` data types. This enables comparison-based segment filters (e.g. "signup date before 2025-01-01") that were previously not possible with string-only attribute values.
-
-### What Happens Automatically
-
-When Formbricks v4.7 starts for the first time, the data migration will:
-
-1. Analyze all existing contact attribute keys and infer their data types (`text`, `number`, or `date`) based on the stored values
-2. Update the `ContactAttributeKey` table with the detected `dataType` for each key
-3. **If your instance has fewer than 1,000,000 contact attribute rows**: backfill the new `valueNumber` and `valueDate` columns inline. No manual action is needed.
-4. **If your instance has 1,000,000 or more contact attribute rows**: the value backfill is skipped to avoid hitting the migration timeout. You will need to run a standalone backfill script after the upgrade.
-
-<Info>
-  Most self-hosted instances have far fewer than 1,000,000 contact attribute rows (a typical setup with 100K
-  contacts and 5-10 attributes each lands around 500K-1M rows). If you are below the threshold, the migration
-  handles everything automatically and you can skip the manual backfill step below.
-</Info>
-
-### Steps to Migrate
-
-**1. Backup your Database**
-
-<Tabs>
-  <Tab title="Docker">
-    Before running these steps, navigate to the `formbricks` directory where your `docker-compose.yml` file is located.
-
-    ```bash
-    docker exec formbricks-postgres-1 pg_dump -Fc -U postgres -d formbricks > formbricks_pre_v4.7_$(date +%Y%m%d_%H%M%S).dump
-    ```
-
-    <Info>
-      If you run into "**No such container**", use `docker ps` to find your container name, e.g.
-      `formbricks_postgres_1`.
-    </Info>
-  </Tab>
-  <Tab title="Kubernetes">
-    If you are using the **in-cluster PostgreSQL** deployed by the Helm chart:
-
-    ```bash
-    kubectl exec -n formbricks formbricks-postgresql-0 -- pg_dump -Fc -U formbricks -d formbricks > formbricks_pre_v4.7_$(date +%Y%m%d_%H%M%S).dump
-    ```
-
-    <Info>
-      If your PostgreSQL pod has a different name, run `kubectl get pods -n formbricks` to find it.
-    </Info>
-
-    If you are using a **managed PostgreSQL** service (e.g. AWS RDS, Cloud SQL), use your provider's backup/snapshot feature or run `pg_dump` directly against the external host.
-  </Tab>
-</Tabs>
-
-**2. Upgrade to Formbricks v4.7**
-
-<Tabs>
-  <Tab title="Docker">
-    ```bash
-    # Pull the latest version
-    docker compose pull
-
-    # Stop the current instance
-    docker compose down
-
-    # Start with Formbricks v4.7
-    docker compose up -d
-    ```
-  </Tab>
-  <Tab title="Kubernetes">
-    ```bash
-    helm upgrade formbricks oci://ghcr.io/formbricks/helm-charts/formbricks \
-      -n formbricks \
-      --set deployment.image.tag=v4.7.0
-    ```
-
-    <Info>
-      The Helm chart includes a migration Job that automatically runs Prisma schema migrations as a
-      PreSync hook before the new pods start. No manual migration step is needed.
-    </Info>
-  </Tab>
-</Tabs>
-
-**3. Check the Migration Logs**
-
-After Formbricks starts, check the logs to see whether the value backfill was completed or skipped:
-
-<Tabs>
-  <Tab title="Docker">
-    ```bash
-    docker compose logs formbricks | grep -i "backfill"
-    ```
-  </Tab>
-  <Tab title="Kubernetes">
-    ```bash
-    # Check the application pod logs
-    kubectl logs -n formbricks -l app.kubernetes.io/name=formbricks --tail=200 | grep -i "backfill"
-    ```
-
-    If the Helm migration Job ran, you can also inspect its logs:
-
-    ```bash
-    kubectl logs -n formbricks job/formbricks-migration
-    ```
-  </Tab>
-</Tabs>
-
-If you see a message like `Skipping value backfill (X rows >= 1000000 threshold)`, proceed to step 4. Otherwise, the migration is complete and no further action is needed.
-
-**4. Run the Backfill Script (large datasets only)**
-
-If the migration skipped the value backfill, run the standalone backfill script inside the running Formbricks container:
-
-<Tabs>
-  <Tab title="Docker">
-    ```bash
-    docker exec formbricks node packages/database/dist/scripts/backfill-attribute-values.js
-    ```
-
-    <Info>Replace `formbricks` with your actual container name if it differs. Use `docker ps` to find it.</Info>
-  </Tab>
-  <Tab title="Kubernetes">
-    ```bash
-    kubectl exec -n formbricks deploy/formbricks -- node packages/database/dist/scripts/backfill-attribute-values.js
-    ```
-
-    <Info>
-      If your Formbricks deployment has a different name, run `kubectl get deploy -n formbricks` to find it.
-    </Info>
-  </Tab>
-</Tabs>
-
-The script will output progress as it runs:
-
-```
-========================================
-Attribute Value Backfill Script
-========================================
-
-Fetching number-type attribute keys...
-Found 12 number-type keys. Backfilling valueNumber...
-  Number backfill progress: 10/12 keys (48230 rows updated)
-  Number backfill progress: 12/12 keys (52104 rows updated)
-
-Fetching date-type attribute keys...
-Found 5 date-type keys. Backfilling valueDate...
-  Date backfill progress: 5/5 keys (31200 rows updated)
-
-========================================
-Backfill Complete!
-========================================
-  valueNumber rows updated: 52104
-  valueDate rows updated:   31200
-  Duration: 42.3s
-========================================
-```
-
-Key characteristics of the backfill script:
-
-- **Safe to run while Formbricks is live** -- it does not lock the entire table or wrap work in a long transaction
-- **Idempotent** -- it only updates rows where the typed columns are still `NULL`, so you can safely run it multiple times
-- **Resumable** -- each batch commits independently, so if the process is interrupted you can re-run it and it picks up where it left off
-- **No timeout risk** -- unlike the migration, this script runs outside the migration transaction and has no time limit
-
-**5. Verify the Upgrade**
-
-- Access your Formbricks instance at the same URL as before
-- If you use contact segments with number or date filters, verify they return the expected results
-- Check that existing surveys and response data are intact
-
----
-
 ## v4.0
 
 <Warning>
   **Important: Migration Required**
 
-Formbricks 4 introduces additional requirements for self-hosting setups and makes a dedicated Redis cache as well as S3-compatible file storage mandatory.
-
+  Formbricks 4 introduces additional requirements for self-hosting setups and makes a dedicated Redis cache as well as S3-compatible file storage mandatory.
 </Warning>
 
 Formbricks 4.0 is a **major milestone** that sets up the technical foundation for future iterations and feature improvements. This release focuses on modernizing core infrastructure components to improve reliability, scalability, and enable advanced features going forward.
@@ -187,11 +17,9 @@ Formbricks 4.0 is a **major milestone** that sets up the technical foundation fo
 ### What's New in Formbricks 4.0
 
 **🚀 New Enterprise Features:**
-
 - **Quotas Management**: Advanced quota controls for enterprise users
 
 **🏗️ Technical Foundation Improvements:**
-
 - **Enhanced File Storage**: Improved file handling with better performance and reliability
 - **Improved Caching**: New caching functionality improving speed, extensibility and reliability
 - **Database Optimization**: Removal of unused database tables and fields for better performance
@@ -211,8 +39,7 @@ These services are already included in the updated one-click setup for self-host
 We know this represents more moving parts in your infrastructure and might even introduce more complexity in hosting Formbricks, and we don't take this decision lightly. As Formbricks grows into a comprehensive Survey and Experience Management platform, we've reached a point where the simple, single-service approach was holding back our ability to deliver the reliable, feature-rich product our users demand and deserve.
 
 By moving to dedicated, professional-grade services for these critical functions, we're building the foundation needed to deliver:
-
-- **Enterprise-grade reliability** with proper redundancy and backup capabilities
+- **Enterprise-grade reliability** with proper redundancy and backup capabilities  
 - **Advanced features** that require sophisticated caching and file processing
 - **Better performance** through optimized, dedicated services
 - **Future scalability** to support larger deployments and more complex use cases without the need to maintain two different approaches
@@ -225,7 +52,7 @@ Additional migration steps are needed if you are using a self-hosted Formbricks
 
 ### One-Click Setup
 
-For users using our official one-click setup, we provide an automated migration using a migration script:
+For users using our official one-click setup, we provide an automated migration using a migration script: 
 
 ```bash
 # Download the latest script
@@ -240,11 +67,11 @@ chmod +x migrate-to-v4.sh
 ```
 
 This script guides you through the steps for the infrastructure migration and does the following:
-
 - Adds a Redis service to your setup and configures it
 - Adds a MinIO service (open source S3-alternative) to your setup, configures it and migrates local files to it
 - Pulls the latest Formbricks image and updates your instance
 
+
 ### Manual Setup
 
 If you use a different setup to host your Formbricks instance, you need to make sure to make the necessary adjustments to run Formbricks 4.0.
@@ -260,7 +87,6 @@ You need to configure the `REDIS_URL` environment variable and point it to your
 To use file storage (e.g., file upload questions, image choice questions, custom survey backgrounds, etc.), you need to have S3-compatible file storage set up and connected to Formbricks.
 
 Formbricks supports multiple storage providers (among many other S3-compatible storages):
-
 - AWS S3
 - Digital Ocean Spaces
 - Hetzner Object Storage
@@ -275,7 +101,6 @@ Please make sure to set up a storage bucket with one of these solutions and then
   S3_BUCKET_NAME: formbricks-uploads
   S3_ENDPOINT_URL: http://minio:9000 # not needed for AWS S3
 ```
-
 #### Upgrade Process
 
 **1. Backup your Database**
@@ -287,8 +112,8 @@ docker exec formbricks-postgres-1 pg_dump -Fc -U postgres -d formbricks > formbr
 ```
 
 <Info>
-  If you run into "**No such container**", use `docker ps` to find your container name, e.g.
-  `formbricks_postgres_1`.
+  If you run into "**No such container**", use `docker ps` to find your container name,
+  e.g. `formbricks_postgres_1`.
 </Info>
 
 **2. Upgrade to Formbricks 4.0**
@@ -309,7 +134,6 @@ docker compose up -d
 **3. Automatic Database Migration**
 
 When you start Formbricks 4.0 for the first time, it will **automatically**:
-
 - Detect and apply required database schema updates
 - Remove unused database tables and fields
 - Optimize the database structure for better performance

docs/self-hosting/advanced/rate-limiting.mdx

@@ -1,94 +1,41 @@
 ---
 title: "Rate Limiting"
-description: "Current request rate limits in Formbricks"
+description: "Rate limiting for Formbricks"
 icon: "timer"
 ---
 
-Formbricks applies request rate limits to protect against abuse and keep API usage fair.
+To protect the platform from abuse and ensure fair usage, rate limiting is enforced by default on an IP-address basis. If a client exceeds the allowed number of requests within the specified time window, the API will return a `429 Too Many Requests` status code.
 
-Rate limits are scoped by identifier, depending on the endpoint:
+## Default Rate Limits
 
-- IP hash (for unauthenticated/client-side routes and public actions)
-- API key ID (for authenticated API calls)
-- User ID (for authenticated session-based calls and server actions)
-- Organization ID (for follow-up email dispatch)
+The following rate limits apply to various endpoints:
 
-When a limit is exceeded, the API returns `429 Too Many Requests`.
+| **Endpoint**            | **Rate Limit** | **Time Window** |
+| ----------------------- | -------------- | --------------- |
+| `POST /login`           | 30 requests    | 15 minutes      |
+| `POST /signup`          | 30 requests    | 60 minutes      |
+| `POST /verify-email`    | 10 requests    | 60 minutes      |
+| `POST /forgot-password` | 5 requests     | 60 minutes      |
+| `GET /client-side-api`  | 100 requests   | 1 minute        |
+| `POST /share`           | 100 requests   | 60 minutes      |
 
-## Management API Rate Limits
-
-These are the current limits for Management APIs:
-
-| **Route Group** | **Limit** | **Window** | **Identifier** |
-| --- | --- | --- | --- |
-| `/api/v1/management/*` (except `/api/v1/management/storage`), `/api/v1/webhooks/*`, `/api/v1/integrations/*`, `/api/v1/management/me` | 100 requests | 1 minute | API key ID or session user ID |
-| `/api/v2/management/*` (and other v2 authenticated routes that use `authenticatedApiClient`) | 100 requests | 1 minute | API key ID |
-| `POST /api/v1/management/storage` | 5 requests | 1 minute | API key ID or session user ID |
-
-## All Enforced Limits
-
-| **Config** | **Limit** | **Window** | **Identifier** | **Used For** |
-| --- | --- | --- | --- | --- |
-| `auth.login` | 10 requests | 15 minutes | IP hash | Email/password login flow (`/api/auth/callback/credentials`) |
-| `auth.signup` | 30 requests | 60 minutes | IP hash | Signup server action |
-| `auth.forgotPassword` | 5 requests | 60 minutes | IP hash | Forgot password server action |
-| `auth.verifyEmail` | 10 requests | 60 minutes | IP hash | Email verification callback + resend verification action |
-| `api.v1` | 100 requests | 1 minute | API key ID or session user ID | v1 management, webhooks, integrations, and `/api/v1/management/me` |
-| `api.v2` | 100 requests | 1 minute | API key ID | v2 authenticated API wrapper (`authenticatedApiClient`) |
-| `api.client` | 100 requests | 1 minute | IP hash | v1 client API routes (except `/api/v1/client/og` and storage upload override), plus v2 routes that re-use those v1 handlers |
-| `storage.upload` | 5 requests | 1 minute | IP hash or authenticated ID | Client storage upload and management storage upload |
-| `storage.delete` | 5 requests | 1 minute | API key ID or session user ID | `DELETE /storage/[environmentId]/[accessType]/[fileName]` |
-| `actions.emailUpdate` | 3 requests | 60 minutes | User ID | Profile email update action |
-| `actions.surveyFollowUp` | 50 requests | 60 minutes | Organization ID | Survey follow-up email processing |
-| `actions.sendLinkSurveyEmail` | 10 requests | 60 minutes | IP hash | Link survey email send action |
-| `actions.licenseRecheck` | 5 requests | 1 minute | User ID | Enterprise license recheck action |
-
-## Current Endpoint Exceptions
-
-The following routes are currently not rate-limited by the server-side limiter:
-
-- `GET /api/v1/client/og` (explicitly excluded)
-- `POST /api/v2/client/[environmentId]/responses`
-- `POST /api/v2/client/[environmentId]/displays`
-- `GET /api/v2/health`
-
-## 429 Response Shape
-
-v1-style endpoints return:
+If a request exceeds the defined rate limit, the server will respond with:
 
 ```json
 {
-  "code": "too_many_requests",
-  "message": "Maximum number of requests reached. Please try again later.",
-  "details": {}
-}
-```
-
-v2-style endpoints return:
-
-```json
-{
-  "error": {
-    "code": 429,
-    "message": "Too Many Requests"
-  }
+  "code": 429,
+  "error": "Too many requests, Please try after a while!"
 }
 ```
 
 ## Disabling Rate Limiting
 
-For self-hosters, rate limiting can be disabled if necessary. We strongly recommend keeping it enabled in production.
+For self-hosters, rate limiting can be disabled if necessary. However, we **strongly recommend keeping rate limiting enabled in production environments** to prevent abuse.
 
-Set:
+To disable rate limiting, set the following environment variable:
 
 ```bash
 RATE_LIMITING_DISABLED=1
 ```
 
-After changing this value, restart the server.
-
-## Operational Notes
-
-- Redis/Valkey is required for robust rate limiting (`REDIS_URL`).
-- If Redis is unavailable at runtime, rate-limiter checks currently fail open (requests are allowed through without enforcement).
-- Authentication failure audit logging uses a separate throttle (`shouldLogAuthFailure()`) and is intentionally **fail-closed**: when Redis is unavailable or errors occur, audit log entries are **skipped entirely** rather than written without throttle control. This prevents spam while preserving the hash-integrity chain required for compliance. In other words, if Redis is down, no authentication-failure audit logs will be recorded—requests themselves are still allowed (fail-open rate limiting above), but the audit trail for those failures will not be written.
+After making this change, restart your server to apply the new setting.

docs/self-hosting/configuration/domain-configuration.mdx

@@ -85,7 +85,6 @@ When PUBLIC_URL is configured, the following routes are automatically served fro
 
 - `/s/{surveyId}` - Individual survey access
 - `/c/{jwt}` - Personalized link survey access (JWT-based access)
-- `/p/{survey-slug}` - Pretty URL survey access
 - Embedded survey endpoints
 
 #### API Routes

docs/xm-and-surveys/xm/best-practices/cancel-subscription.mdx

@@ -16,6 +16,8 @@ The Churn Survey is among the most effective ways to identify weaknesses in your
 
 * Follow-up to prevent bad reviews
 
+* Coming soon: Make survey mandatory
+
 ## Overview
 
 To run the Churn Survey in your app you want to proceed as follows:
@@ -78,6 +80,13 @@ Whenever a user visits this page, matches the filter conditions above and the re
 
 Here is our complete [Actions manual](/xm-and-surveys/surveys/website-app-surveys/actions/) covering [No-Code](/xm-and-surveys/surveys/website-app-surveys/actions#setting-up-no-code-actions) and [Code](/xm-and-surveys/surveys/website-app-surveys/actions#setting-up-code-actions) Actions.
 
+<Note>
+  Pre-churn flow coming soon We’re currently building full-screen survey
+  pop-ups. You’ll be able to prevent users from closing the survey unless they
+  respond to it. It’s certainly debatable if you want that but you could force
+  them to click through the survey before letting them cancel 🤷
+</Note>
+
 ### 5. Select Action in the “When to ask” card
 
 ![Select feedback button action](/images/xm-and-surveys/xm/best-practices/cancel-subscription/select-action.webp)

docs/xm-and-surveys/xm/best-practices/improve-trial-cr.mdx

@@ -46,7 +46,13 @@ _Want to change the button color? Adjust it in the project settings!_
 
 Save, and move over to the **Audience** tab.
 
-### 3. Pre-segment your audience
+### 3. Pre-segment your audience (coming soon)
+
+<Note>
+### Filter by Attribute Coming Soon
+
+We're working on pre-segmenting users by attributes. This manual will be updated in the coming days.
+</Note>
 
 Pre-segmentation isn't needed for this survey since you likely want to target all users who cancel their trial. You can use a specific user action, like clicking **Cancel Trial**, to show the survey only to users trying your product.
 
@@ -56,13 +62,13 @@ How you trigger your survey depends on your product. There are two options:
 
 - **Trigger by Page view:** If you have a page like `/trial-cancelled` for users who cancel their trial subscription, create a user action with the type "Page View." Select "Limit to specific pages" and apply URL filters with these settings:
 
-![Add page URL action](/images/xm-and-surveys/xm/best-practices/improve-trial-cr/action-pageurl.webp)
+![Change text content](/images/xm-and-surveys/xm/best-practices/improve-trial-cr/action-pageurl.webp)
 
 Whenever a user visits this page, the survey will be displayed ✅
 
 - **Trigger by Button Click:** In a different case, you have a “Cancel Trial" button in your app. You can setup a user Action with the `Inner Text`:
 
-![Add inner text action](/images/xm-and-surveys/xm/best-practices/improve-trial-cr/action-innertext.webp)
+![Change text content](/images/xm-and-surveys/xm/best-practices/improve-trial-cr/action-innertext.webp)
 
 Please have a look at our complete [Actions manual](/xm-and-surveys/surveys/website-app-surveys/actions) if you have questions.
 

docs/xm-and-surveys/xm/best-practices/interview-prompt.mdx

@@ -54,7 +54,13 @@ In the button settings you have to make sure it is set to “External URL”. In
 
 Save, and move over to the “Audience” tab.
 
-### 3. Pre-segment your audience
+### 3. Pre-segment your audience (coming soon)
+
+<Note>
+  ## Filter by attribute coming soon. We're working on pre-segmenting users by
+
+  attributes. We will update this manual in the next few days.
+</Note>
 
 Once you clicked over to the “Audience” tab you can change the settings. In the **Who To Send** card, select “Filter audience by attribute”. This allows you to only show the prompt to a specific segment of your user base.