mirror/hatchet
1
0
Fork 0
mirror of https://github.com/hatchet-dev/hatchet.git synced 2026-01-06 08:49:53 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix: race conditions on retries w/out backoff and concurrency keys (#1368)

Browse Source
This commit is contained in:
abelanger5
2025-03-19 12:36:36 -04:00
committed by GitHub
parent 834c3160d2
commit 4164b80f13
2 changed files with 295 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
sql/schema/v1-core.sql
View File

@@ -982,44 +982,18 @@ BEGIN
AND (nt.retry_backoff_factor IS NULL OR ot.app_retry_count IS NOT DISTINCT FROM nt.app_retry_count OR nt.app_retry_count = 0)
AND ot.retry_count IS DISTINCT FROM nt.retry_count
)
INSERT INTO v1_concurrency_slot (
task_id,
task_inserted_at,
task_retry_count,
external_id,
tenant_id,
workflow_id,
workflow_version_id,
workflow_run_id,
parent_strategy_id,
next_parent_strategy_ids,
strategy_id,
next_strategy_ids,
priority,
key,
next_keys,
queue_to_notify,
schedule_timeout_at
)
SELECT
id,
inserted_at,
retry_count,
external_id,
tenant_id,
workflow_id,
workflow_version_id,
workflow_run_id,
parent_strategy_id,
next_parent_strategy_ids,
strategy_id,
next_strategy_ids,
4,
key,
next_keys,
queue,
schedule_timeout_at
FROM new_slot_rows;
UPDATE
v1_concurrency_slot cs
SET
task_retry_count = nt.retry_count,
is_filled = FALSE,
priority = 4
FROM
new_slot_rows nt
WHERE
cs.task_id = nt.id
AND cs.task_inserted_at = nt.inserted_at
AND cs.strategy_id = nt.strategy_id;
INSERT INTO v1_queue_item (
tenant_id,