mirror/hatchet
1
0
Fork 0
mirror of https://github.com/hatchet-dev/hatchet.git synced 2026-01-07 17:29:39 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix: semaphores increasing on manual replays (#441)

Browse Source 
* fix: semaphores increasing on manual replays

* chore: remove metrics queries
This commit is contained in:
abelanger5
2024-05-01 14:05:39 -04:00
committed by GitHub
parent 5d05090bbf
commit f71f17f5f7
5 changed files with 84 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
api/v1/server/handlers/step-runs/rerun.go
View File

@@ -76,6 +76,15 @@ func (t *StepRunService) StepRunUpdateRerun(ctx echo.Context, request gen.StepRu
return nil, fmt.Errorf("could not get step run for engine: %w", err)
}
// Unlink the step run from its existing worker. This is necessary because automatic retries increment the
// worker semaphore on failure/cancellation, but in this case we don't want to increment the semaphore.
// FIXME: this is very far decoupled from the actual worker logic, and should be refactored.
err = t.config.EngineRepository.StepRun().UnlinkStepRunFromWorker(ctx.Request().Context(), tenant.ID, stepRun.ID)
if err != nil {
return nil, fmt.Errorf("could not unlink step run from worker: %w", err)
}
// send a task to the taskqueue
err = t.config.MessageQueue.AddMessage(
ctx.Request().Context(),