mirror/munki
1
0
Fork 0
mirror of https://github.com/munki/munki.git synced 2026-01-05 22:20:00 -06:00
Code Issues Packages Projects Releases Wiki Activity

Added fix to avoid crash while creating icon due to CGImageSourceCopyPropertiesAtIndex, in macOS 10.15.4 and above (#987)

Browse Source
This commit is contained in:
Shiva Tripathi
2020-04-08 19:50:02 +05:30
committed by GitHub
parent 291a740dd1
commit d079d1b155
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
code/client/munkilib/iconutils.py
View File

@@ -70,6 +70,9 @@ def convertIconToPNG(icon_path, destination_path,
try:
properties = CGImageSourceCopyPropertiesAtIndex(
image_source, index, None)
# perform not empty check for properties to prevent crash as CGImageSourceCopyPropertiesAtIndex sometimes fails in 10.15.4 and above
if not properties:
return False
dpi = int(properties.get(kCGImagePropertyDPIHeight, 0))
height = int(properties.get(kCGImagePropertyPixelHeight, 0))
if (not candidate or