Commit Graph

2975 Commits

Author SHA1 Message Date
Greg Neagle
37e5791b2d Merge branch 'ToolbarItemFix' into Munki3dev 2019-03-20 11:45:53 -07:00
Greg Neagle
7f0d04d2ef Merge branch 'Issue915work' into Munki3dev 2019-03-20 11:44:29 -07:00
Greg Neagle
ffb2dc92dc MSC.app: Remove top border line for each item in updates view.
This line was white, and therefore virtually invisible in Light Mode
(though it did take 1px of vertical space). When switching to Dark Mode,
it added a 1px width to the lines seperating items. We could have switched
the color when switching to Dark Mode, but it seemed easier to just remove
the line. A side-effect is the height of each item is reduced 1px.

Addresses #922
2019-03-15 15:18:13 -07:00
Greg Neagle
5f3f0e458a MSC.app: Fix stupid typo that prevented a restart alert from showing
If an installer pkg or softwareupdate reports the need to restart and a user is still logged in,
MSC.app should display an alert sheet informing the user of the need to restart. Because of the
typo, the alert was never shown, a restart is never "highly encouraged", and eventually a
erroneous "configuration problem" alert is shown. See the screen shots attached to
https://github.com/munki/munki/issues/921 for an example of the issue.
2019-03-14 09:29:28 -07:00
Greg Neagle
835133054a MSC.app: Use a more Python-like method for determining boolean-ish values from Munki's preferences.
Works around an issue where Munki admins might be sloppy and assign string or integer values to
Munki preferences that should be booleans. Python interpeted these non-boolean values in a boolean
context in a way the prior Swift code did not (it treated all non-boolean values as false). This
change attempts to be more forgiving of admin error and treat these values the same way Python would.
Addresses #921
2019-03-14 08:59:45 -07:00
Greg Neagle
e81ed8be18 Display status of an item install before running a preinstall script, if any. Fixes #915 2019-03-10 15:58:05 -07:00
Greg Neagle
309ab3ddec MSC.app: Fix for toolbar item labels sometimes remaining inactive. Fixes #918 2019-03-09 21:54:57 -08:00
Greg Neagle
aed4b4ba1c Update base.css, detail.css and updates.css to match versions in MSC 4.8.3628 2019-03-08 11:45:20 -08:00
Greg Neagle
c908c96239 MSC.app: Address issues with Forced Logout Warnings
Don't crash when warning of a Forced Logout for Mandatory Installs in XX minutes.
Additionally, don't behave as though user agreed to logout when the warning is
ignored long enough that another warning happens while the previous warning is
displayed. Addresses #916 (and another issue)
2019-03-06 15:00:41 -08:00
Greg Neagle
0463c8047a MSC.app: Remove deprecated NSApplication endSheet method to silence a warning. 2019-03-03 12:08:09 -08:00
Greg Neagle
c72ce0899d MSC.app LogViewController: replace deprecated constant with supported one to silence a warning. 2019-03-03 11:39:48 -08:00
Greg Neagle
c49fa4b8e0 MSC.app: On 10.11+, clear local cache after each page load
to prevent stale pages from being shown when using back/forward controls or swipes.
This API is not supported pre 10.11, so macOS 10.10 users can get stale pages
when using the back/forward controls.
2019-03-03 11:17:56 -08:00
Greg Neagle
13b0b840f2 MSC.app: Don't remove span tags when filtering html for item descriptions. Addresses #914 2019-03-03 11:02:44 -08:00
Greg Neagle
06d6407d05 MSC.app: Address issue where logout is interrupted by MSC.app if there are updates to be forced soon. 2019-03-02 08:21:41 -08:00
Greg Neagle
09d6db82e5 MSC.app: Fix date display when warning for Mandatory Updates on quit 2019-03-02 07:56:44 -08:00
Greg Neagle
8e9b02cb03 Work around issue with WKWebView when user's home directory is not on the same filesystem (volume) as Managed Software Center.app 2019-02-27 09:27:13 -08:00
Greg Neagle
7ddf98055d MSC.app: when an item's icon_name contains an empty string, align MSC 5's behavior with MSC 4. 2019-02-27 09:25:51 -08:00
Greg Neagle
f890235044 Fix an issue that would cause Munki to fail to reboot after installing updates that require a reboot when no-one is logged in. 2019-02-18 07:39:43 -08:00
Elliot Jordan
d14c4304ea Various typo fixes and spelling corrections (#907)
* Fixed "No Comment" typo in strings files

* Fix "problem updates" typo

* Fix "caught" typo

* Fix "pseudo" typo

* Fix "instantiated" typo

* Fix "explicitly" typo

* Fix "osascript" typo

* Spelling fixes and various other corrections

* Fix two more instances of "Logput"

* Fixed a few remaining spelling issues in python files

* Fix "because" typo

PR also submitted upstream to the Murky project for the same correction.

* Fix name of associated app

* Additional spelling corrections in comments/docstrings
2019-02-14 08:30:43 -08:00
Elliot Jordan
435719eb3c Set owner and group at the same time (#906) 2019-02-14 08:24:40 -08:00
Elliot Jordan
9a0adfa0f7 Deduplicate list of conflicting apps in MSC alert (#905) 2019-02-14 08:23:13 -08:00
Greg Neagle
97dcaa380c Improvements in listing available Apple updates.
When com.apple.SotwareUpdate's RecommendedUpdates is not defined or empty, don't fall over to /Library/Upates/index.plist information unless we are on 10.8 or earlier.
Addresses an issue where Munki would sometimes claim downloaded but no longer applicable Apple updates were pending.
2019-02-08 15:21:38 +01:00
Greg Neagle
d663f16f74 Small tweaks to toolbar elements for better appearance under Mojave 2019-02-04 16:09:42 -08:00
Elliot Jordan
b5edd2481e Minor typo fix (#904) 2019-02-02 08:37:04 -08:00
Greg Neagle
e68ece8ec1 Fix for munki:// links for item names that contain a period (and do not end with '.html') 2019-01-31 11:46:26 -08:00
Greg Neagle
f4ac054874 Address issue where MSC.app could not create user-level log files if configured to do user-level logging. 2019-01-31 10:31:29 -08:00
Greg Neagle
e10fed04ee Defend against badly-authored packages that define their installKBytes as a float instead of an integer. Addresses #902. 2019-01-30 09:15:11 -08:00
Greg Neagle
e941952d60 volume-check in pkg distribution files now prevents install on volumes with macOS version < 10.10 2019-01-30 09:01:22 -08:00
Greg Neagle
80a844eb13 If an item to be precached contains PackageURL or PackageCompleteURL keys, store those for use by the precaching agent. 2019-01-15 11:55:17 -08:00
Elliot Jordan
5797477305 Minor typo fix in docstring (#900) 2019-01-15 09:04:26 -08:00
Tom Bridge
099451e068 adds line to remove the app status package receipt (#898)
* adds line to remove the app status package receipt

* adds line feed to end of script
2019-01-15 09:02:46 -08:00
Greg Neagle
125e9c6471 Precaching improvements so that managedsoftwareupdate won't remove partially precached items, and that precache_agent is stopped when managedsoftwareupdate does an updatecheck 2019-01-09 08:23:00 -08:00
Greg Neagle
a73ea66162 Provide switch for MunkiStatus output so precache_agent can switch it off. Addresses #897 2019-01-08 11:00:41 -08:00
Greg Neagle
42a291436d Fix logic error in download.uncache() function that caused it to check filesize for not-yet-downloaded items 2019-01-08 10:58:16 -08:00
Ben Goodstein
4d8b05c9b6 MunkiStatus.app Info.plist localization fixes (#895) 2019-01-07 08:48:08 -08:00
Ben Goodstein
88d9858ceb Localization fixes for Info.plist (#894) 2019-01-07 08:08:06 -08:00
Greg Neagle
d515264134 Fix for percent-done display in update status view 2019-01-04 14:53:46 -08:00
Greg Neagle
31e4afa266 Fix timer in MSC.app that monitors for managedsoftwareupdate failing to start or ending unexpectedly. 2019-01-04 13:39:00 -08:00
Greg Neagle
0f5ece3059 Detail description now inside a div element instead of a p element. Allows p elements to be in descriptions. 2019-01-03 16:40:38 -08:00
Greg Neagle
4f44643a4a Also precache items where precache=True and needs_update=True 2019-01-03 09:39:34 -08:00
Greg Neagle
3a26c666ca implement JavaScript integrstion with Main Window controller's openExternalLink() function 2019-01-02 14:52:58 -08:00
Greg Neagle
54721574e9 Update pkg title in Distribution file to mention macOS instead of OS X 2019-01-02 10:45:18 -08:00
Greg Neagle
918d0b7391 Update copyright dates 2019-01-02 10:31:50 -08:00
Greg Neagle
f715a4627e Update .gitignore files; add MunkiStatus/en.lproj; fixes git tracking issues with localized files 2018-12-21 13:45:37 -08:00
Greg Neagle
8422a6d724 Remove extra odd copy of Localization.swift 2018-12-21 12:16:38 -08:00
Christopher Grande
5e113e10d8 Fix for indeterminate progress bar “rolling shutter” effect (#892) 2018-12-18 13:24:32 -08:00
Greg Neagle
6ef70c0424 Fix and tweak detection of need to shutdown for apple updates 2018-12-18 08:23:47 -08:00
Greg Neagle
19362c77e9 Log shut down actions no matter the logging level; don't require halt message to be at the beginning of a softwareupdate output line 2018-12-17 16:13:00 -08:00
Greg Neagle
ff5d94cc28 Clean up code signing configuration for MSC.app and MunkiStatus.app. Resolves an issue where MSC.app will not launch in response to a clicked Notification Center notification. 2018-12-14 15:36:32 -08:00
Greg Neagle
f60564583c Implement user-level logging from MSC.app. Addresses #884. 2018-12-13 14:24:31 -08:00