Commit Graph

3300 Commits

Author SHA1 Message Date
Greg Neagle 531d99a01a Convert all print statements to Python3-compatible print functions 2019-05-03 19:47:37 -07:00
Elliot Jordan 2ad27ff411 Align except clauses with PEP 3110 (#933)
This should work for Python 2.6+, including 3.
https://www.python.org/dev/peps/pep-3110/#compatibility-issues
2019-05-03 15:05:13 -07:00
Greg Neagle 270f23611e Merge branch 'Munki3dev' of https://github.com/munki/munki into Munki3dev 2019-05-03 15:02:26 -07:00
Christopher Grande 5fbb93f376 Fix for rolling shutter regression on barber-pole animation (#932) 2019-05-03 15:01:22 -07:00
Greg Neagle 137741e7f7 Attempt to work around another softwareupdate bug 2019-05-01 11:01:39 -07:00
Greg Neagle 06eee7c353 Bumping version for future development round 2019-04-23 06:27:23 -07:00
Greg Neagle c10ee6072b Merge branch 'master' into Munki3dev v3.6.2 2019-04-22 11:38:08 -07:00
Greg Neagle 0010706cbd Fix for at least one cause of MSC repeatedly displaying a 'Pending Updates' alert when attempting to quit the application 2019-04-21 14:49:36 -07:00
dcoobs 731dbfadb9 Fix output typo in manifestutils.py (#929) 2019-04-16 11:34:31 -07:00
Greg Neagle af1cf640b4 Fix recording of install requests to application_usage.
This has been broken for a year -- since the refactor into user-agent and root-daemon.
2019-04-12 20:39:50 -07:00
Greg Neagle 60b9bfd227 Simplfy functions that highlight toolbar items 2019-04-04 08:22:22 -07:00
Greg Neagle 5d3b7b0636 Highlight toolbar item imeediately after click instead of waiting for page load. 2019-04-04 06:35:03 -07:00
Greg Neagle 668ad235cd Performance optimizations noticable when there are many hundreds of optional installs 2019-04-03 16:58:16 -07:00
Greg Neagle bc25f0ea4d Log/display warning if ptyexec is not found and we fall back to /usr/bin/script 2019-04-03 08:20:41 -07:00
Greg Neagle a5efb23eb0 Fixes for description display in item detail view to more closely match that of MSC 4.x 2019-04-02 18:55:26 -07:00
Greg Neagle fb4230fc8c Bump version for future release 2019-04-02 09:16:45 -07:00
Greg Neagle 3fb41360c5 Merge branch 'softwareupdate_fixes' into Munki3dev 2019-04-02 09:15:59 -07:00
Greg Neagle 17dfb548cf More tweaks and clean ups 2019-04-02 09:08:39 -07:00
Greg Neagle 9783313223 Improvements in determining available/pending Apple updates.
Use "softwareupdate -l --no-scan" output to filter the list of available
updates in macOS 10.11+. This addresses an issue observed in 10.13 and
10.14 where com.apple.SoftwareUpdate's RecommendedUpdates sometimes
listed updates that were no longer applicable.
2019-04-01 16:48:10 -07:00
Greg Neagle 8c3f9a6c93 Continuing the refactor: replace _run_softwareupdate method with calls to su_tool.run 2019-03-29 17:02:11 -07:00
Greg Neagle 4067ffa0bf Add new code/client/munkilib/appleupdates/su_tool.py as part of refactoring 2019-03-29 15:34:36 -07:00
Greg Neagle 12d589dc2e Merge branch 'master' into softwareupdate_fixes 2019-03-27 10:45:04 -07:00
Greg Neagle 52c290b8e6 Merge branch 'master' into Munki3dev v3.6.1 2019-03-27 10:44:32 -07:00
Greg Neagle 2c0c13e636 Update MSC.app and MunkiStatus.app projects for Xcode 10(.2) compatibility. 2019-03-27 10:43:57 -07:00
Greg Neagle be95661838 Refactoring 2019-03-27 09:51:32 -07:00
Greg Neagle fe8c7f93f2 appleupdates: Remove code for pre-macOS 10.10 2019-03-20 18:23:51 -07:00
Greg Neagle eede2e8e3c Bumping version for future release 2019-03-20 11:59:22 -07:00
Greg Neagle 37e5791b2d Merge branch 'ToolbarItemFix' into Munki3dev 2019-03-20 11:45:53 -07:00
Greg Neagle 7f0d04d2ef Merge branch 'Issue915work' into Munki3dev 2019-03-20 11:44:29 -07:00
Greg Neagle d44feba3ba Merge branch 'Munki3dev' 2019-03-20 08:58:09 -07:00
Greg Neagle ffb2dc92dc MSC.app: Remove top border line for each item in updates view.
This line was white, and therefore virtually invisible in Light Mode
(though it did take 1px of vertical space). When switching to Dark Mode,
it added a 1px width to the lines seperating items. We could have switched
the color when switching to Dark Mode, but it seemed easier to just remove
the line. A side-effect is the height of each item is reduced 1px.

Addresses #922
2019-03-15 15:18:13 -07:00
Greg Neagle 5f3f0e458a MSC.app: Fix stupid typo that prevented a restart alert from showing
If an installer pkg or softwareupdate reports the need to restart and a user is still logged in,
MSC.app should display an alert sheet informing the user of the need to restart. Because of the
typo, the alert was never shown, a restart is never "highly encouraged", and eventually a
erroneous "configuration problem" alert is shown. See the screen shots attached to
https://github.com/munki/munki/issues/921 for an example of the issue.
v3.6.0
2019-03-14 09:29:28 -07:00
Greg Neagle 835133054a MSC.app: Use a more Python-like method for determining boolean-ish values from Munki's preferences.
Works around an issue where Munki admins might be sloppy and assign string or integer values to
Munki preferences that should be booleans. Python interpeted these non-boolean values in a boolean
context in a way the prior Swift code did not (it treated all non-boolean values as false). This
change attempts to be more forgiving of admin error and treat these values the same way Python would.
Addresses #921
2019-03-14 08:59:45 -07:00
Greg Neagle e81ed8be18 Display status of an item install before running a preinstall script, if any. Fixes #915 2019-03-10 15:58:05 -07:00
Greg Neagle 309ab3ddec MSC.app: Fix for toolbar item labels sometimes remaining inactive. Fixes #918 2019-03-09 21:54:57 -08:00
Greg Neagle aed4b4ba1c Update base.css, detail.css and updates.css to match versions in MSC 4.8.3628 2019-03-08 11:45:20 -08:00
Greg Neagle c908c96239 MSC.app: Address issues with Forced Logout Warnings
Don't crash when warning of a Forced Logout for Mandatory Installs in XX minutes.
Additionally, don't behave as though user agreed to logout when the warning is
ignored long enough that another warning happens while the previous warning is
displayed. Addresses #916 (and another issue)
2019-03-06 15:00:41 -08:00
Greg Neagle 0463c8047a MSC.app: Remove deprecated NSApplication endSheet method to silence a warning. 2019-03-03 12:08:09 -08:00
Greg Neagle c72ce0899d MSC.app LogViewController: replace deprecated constant with supported one to silence a warning. 2019-03-03 11:39:48 -08:00
Greg Neagle c49fa4b8e0 MSC.app: On 10.11+, clear local cache after each page load
to prevent stale pages from being shown when using back/forward controls or swipes.
This API is not supported pre 10.11, so macOS 10.10 users can get stale pages
when using the back/forward controls.
2019-03-03 11:17:56 -08:00
Greg Neagle 13b0b840f2 MSC.app: Don't remove span tags when filtering html for item descriptions. Addresses #914 2019-03-03 11:02:44 -08:00
Greg Neagle 06d6407d05 MSC.app: Address issue where logout is interrupted by MSC.app if there are updates to be forced soon. 2019-03-02 08:21:41 -08:00
Greg Neagle 09d6db82e5 MSC.app: Fix date display when warning for Mandatory Updates on quit 2019-03-02 07:56:44 -08:00
Greg Neagle 8e9b02cb03 Work around issue with WKWebView when user's home directory is not on the same filesystem (volume) as Managed Software Center.app 2019-02-27 09:27:13 -08:00
Greg Neagle 7ddf98055d MSC.app: when an item's icon_name contains an empty string, align MSC 5's behavior with MSC 4. 2019-02-27 09:25:51 -08:00
Greg Neagle ec06afb95f Bumping version for new release v3.5.3 2019-02-18 07:43:27 -08:00
Greg Neagle f890235044 Fix an issue that would cause Munki to fail to reboot after installing updates that require a reboot when no-one is logged in. 2019-02-18 07:39:43 -08:00
Greg Neagle b61f61433f Fix an issue that would cause Munki to fail to reboot after installing updates that require a reboot when no-one is logged in. 2019-02-18 07:39:15 -08:00
Elliot Jordan d14c4304ea Various typo fixes and spelling corrections (#907)
* Fixed "No Comment" typo in strings files

* Fix "problem updates" typo

* Fix "caught" typo

* Fix "pseudo" typo

* Fix "instantiated" typo

* Fix "explicitly" typo

* Fix "osascript" typo

* Spelling fixes and various other corrections

* Fix two more instances of "Logput"

* Fixed a few remaining spelling issues in python files

* Fix "because" typo

PR also submitted upstream to the Murky project for the same correction.

* Fix name of associated app

* Additional spelling corrections in comments/docstrings
2019-02-14 08:30:43 -08:00
Elliot Jordan 435719eb3c Set owner and group at the same time (#906) 2019-02-14 08:24:40 -08:00