Justin McWilliams
89e2ab8b81
Move getPIDforProcessName() out of munkicommon and into utils, so it can be
...
used in modules that munkicommon also imports.
2012-02-10 18:05:51 -05:00
Justin McWilliams
c7d2f2a9b0
Change utils.runExternalScript() script_args default from an empty list to an empty tuple.
...
Default arguments are evaluated once at module load time. This may cause problems if the argument is a mutable object such as a list or a dictionary. If the mutable object is changed within the function, those changes will persist to subsequent calls of the function. This wasn't a problem for runExternalScript yet, since the default arg is not changed within the function, but we might as well fix it to protect against potential future bugs.
2012-01-19 11:29:23 -05:00
Greg Neagle
833d509c94
Fix - send update notification to MSU.app after an unattended install; fix method signature for utils.runExternalScript
2011-09-14 16:43:50 -07:00
Rob Middleton
570c0f7ad4
Allow preflight/postflight to run so long as the permissions are not weaker than managedsoftwareupdate.
2011-09-14 21:31:31 +10:00
MagerValp
986a45d395
Reverting r1186, library files don't require executable bit.
...
git-svn-id: http://munki.googlecode.com/svn/trunk@1187 a4e17f2e-e282-11dd-95e1-755cbddbdd66
2011-05-20 13:35:09 +00:00
MagerValp
c3fb0ff0ec
Fixed missing executable bit.
...
git-svn-id: http://munki.googlecode.com/svn/trunk@1186 a4e17f2e-e282-11dd-95e1-755cbddbdd66
2011-05-20 09:31:24 +00:00
Justin McWilliams
b20b212431
Fix utils.runExternalScript docstring to match change in r1092.
...
git-svn-id: http://munki.googlecode.com/svn/trunk@1093 a4e17f2e-e282-11dd-95e1-755cbddbdd66
2011-04-04 21:39:42 +00:00
Justin McWilliams
3f3a3b4dfd
utils.runExternalScript should return stderr, and preflight/postflight stderr should be displayed and logged if return != 0
...
git-svn-id: http://munki.googlecode.com/svn/trunk@1092 a4e17f2e-e282-11dd-95e1-755cbddbdd66
2011-04-04 21:38:33 +00:00
Greg Neagle
a853f78c9f
Update copyright dates across the board.
...
git-svn-id: http://munki.googlecode.com/svn/trunk@1010 a4e17f2e-e282-11dd-95e1-755cbddbdd66
2011-01-25 18:22:14 +00:00
Rob Middleton
6ee6a33e96
pylint: bug in munkicommon.format_time, indentation fixes
...
git-svn-id: http://munki.googlecode.com/svn/trunk@931 a4e17f2e-e282-11dd-95e1-755cbddbdd66
2010-11-27 10:10:27 +00:00
Justin McWilliams
7afec5b605
Better implementation of r863; move verifyFileOnlyWritableByMunkiAndRoot() and runExternalScript() to new munkilib utils module that is 100% free of ObjC-dependant Python.
...
git-svn-id: http://munki.googlecode.com/svn/trunk@865 a4e17f2e-e282-11dd-95e1-755cbddbdd66
2010-10-26 16:32:48 +00:00
