Greg Neagle
f0e00aefba
Fix a typo in a comment
2019-05-26 17:12:17 -07:00
Greg Neagle
d3fa3680b3
If softwareupdate launchd job fails, return the expected dictionary structure, not an integer return code
2019-05-14 13:52:14 -07:00
Greg Neagle
f1df5d96a6
Pylint fixes
2019-05-05 12:48:15 -07:00
Greg Neagle
3768eb78cb
PyLint cleanups
2019-05-05 11:14:04 -07:00
Greg Neagle
97a64a1eb5
PyLint cleanups
2019-05-05 09:51:59 -07:00
Greg Neagle
45d4f78d2c
PyLint cleanups
2019-05-05 09:26:42 -07:00
Greg Neagle
4487595fba
PyLint cleanups
2019-05-04 07:30:42 -07:00
Greg Neagle
5b82366356
Replace an instance of 'Except foo, bar' with 'Excpet foo as bar'
2019-05-03 22:16:28 -07:00
Greg Neagle
4f51efc324
More octal literal fixes for Python 3 compatibility
2019-05-03 22:14:00 -07:00
Greg Neagle
6cf394ad4b
Octal literal fixes for Python 3 compatibility
2019-05-03 22:12:17 -07:00
Greg Neagle
23ba0f98ec
Some more type/isinstance replacements
2019-05-03 22:02:08 -07:00
Greg Neagle
6bc83d08e6
Replace 'type(foo) == bar' with 'isinstance(foo, bar)' to fit Python 3 idiom
2019-05-03 21:57:05 -07:00
Greg Neagle
453524a5b0
More Python 3 idiom changes
2019-05-03 21:49:18 -07:00
Greg Neagle
e1dcb7e198
Python 3 idiom fix
2019-05-03 21:45:23 -07:00
Greg Neagle
8ede35a75f
Fix import in munkilib/munkirepo/GitFileRepo.py to be absolute for Python 3 compatibility
2019-05-03 21:39:02 -07:00
Greg Neagle
df60207145
Add 'from __future__ import absolute_import' to all files to enforce Python3-style imports
2019-05-03 21:34:56 -07:00
Greg Neagle
531d99a01a
Convert all print statements to Python3-compatible print functions
2019-05-03 19:47:37 -07:00
Elliot Jordan
2ad27ff411
Align except clauses with PEP 3110 ( #933 )
...
This should work for Python 2.6+, including 3.
https://www.python.org/dev/peps/pep-3110/#compatibility-issues
2019-05-03 15:05:13 -07:00
Greg Neagle
270f23611e
Merge branch 'Munki3dev' of https://github.com/munki/munki into Munki3dev
2019-05-03 15:02:26 -07:00
Christopher Grande
5fbb93f376
Fix for rolling shutter regression on barber-pole animation ( #932 )
2019-05-03 15:01:22 -07:00
Greg Neagle
137741e7f7
Attempt to work around another softwareupdate bug
2019-05-01 11:01:39 -07:00
Greg Neagle
06eee7c353
Bumping version for future development round
2019-04-23 06:27:23 -07:00
Greg Neagle
c10ee6072b
Merge branch 'master' into Munki3dev
2019-04-22 11:38:08 -07:00
Greg Neagle
0010706cbd
Fix for at least one cause of MSC repeatedly displaying a 'Pending Updates' alert when attempting to quit the application
2019-04-21 14:49:36 -07:00
dcoobs
731dbfadb9
Fix output typo in manifestutils.py ( #929 )
2019-04-16 11:34:31 -07:00
Greg Neagle
af1cf640b4
Fix recording of install requests to application_usage.
...
This has been broken for a year -- since the refactor into user-agent and root-daemon.
2019-04-12 20:39:50 -07:00
Greg Neagle
60b9bfd227
Simplfy functions that highlight toolbar items
2019-04-04 08:22:22 -07:00
Greg Neagle
5d3b7b0636
Highlight toolbar item imeediately after click instead of waiting for page load.
2019-04-04 06:35:03 -07:00
Greg Neagle
668ad235cd
Performance optimizations noticable when there are many hundreds of optional installs
2019-04-03 16:58:16 -07:00
Greg Neagle
bc25f0ea4d
Log/display warning if ptyexec is not found and we fall back to /usr/bin/script
2019-04-03 08:20:41 -07:00
Greg Neagle
a5efb23eb0
Fixes for description display in item detail view to more closely match that of MSC 4.x
2019-04-02 18:55:26 -07:00
Greg Neagle
fb4230fc8c
Bump version for future release
2019-04-02 09:16:45 -07:00
Greg Neagle
17dfb548cf
More tweaks and clean ups
2019-04-02 09:08:39 -07:00
Greg Neagle
9783313223
Improvements in determining available/pending Apple updates.
...
Use "softwareupdate -l --no-scan" output to filter the list of available
updates in macOS 10.11+. This addresses an issue observed in 10.13 and
10.14 where com.apple.SoftwareUpdate's RecommendedUpdates sometimes
listed updates that were no longer applicable.
2019-04-01 16:48:10 -07:00
Greg Neagle
8c3f9a6c93
Continuing the refactor: replace _run_softwareupdate method with calls to su_tool.run
2019-03-29 17:02:11 -07:00
Greg Neagle
4067ffa0bf
Add new code/client/munkilib/appleupdates/su_tool.py as part of refactoring
2019-03-29 15:34:36 -07:00
Greg Neagle
12d589dc2e
Merge branch 'master' into softwareupdate_fixes
2019-03-27 10:45:04 -07:00
Greg Neagle
52c290b8e6
Merge branch 'master' into Munki3dev
2019-03-27 10:44:32 -07:00
Greg Neagle
2c0c13e636
Update MSC.app and MunkiStatus.app projects for Xcode 10(.2) compatibility.
2019-03-27 10:43:57 -07:00
Greg Neagle
be95661838
Refactoring
2019-03-27 09:51:32 -07:00
Greg Neagle
fe8c7f93f2
appleupdates: Remove code for pre-macOS 10.10
2019-03-20 18:23:51 -07:00
Greg Neagle
eede2e8e3c
Bumping version for future release
2019-03-20 11:59:22 -07:00
Greg Neagle
37e5791b2d
Merge branch 'ToolbarItemFix' into Munki3dev
2019-03-20 11:45:53 -07:00
Greg Neagle
7f0d04d2ef
Merge branch 'Issue915work' into Munki3dev
2019-03-20 11:44:29 -07:00
Greg Neagle
ffb2dc92dc
MSC.app: Remove top border line for each item in updates view.
...
This line was white, and therefore virtually invisible in Light Mode
(though it did take 1px of vertical space). When switching to Dark Mode,
it added a 1px width to the lines seperating items. We could have switched
the color when switching to Dark Mode, but it seemed easier to just remove
the line. A side-effect is the height of each item is reduced 1px.
Addresses #922
2019-03-15 15:18:13 -07:00
Greg Neagle
5f3f0e458a
MSC.app: Fix stupid typo that prevented a restart alert from showing
...
If an installer pkg or softwareupdate reports the need to restart and a user is still logged in,
MSC.app should display an alert sheet informing the user of the need to restart. Because of the
typo, the alert was never shown, a restart is never "highly encouraged", and eventually a
erroneous "configuration problem" alert is shown. See the screen shots attached to
https://github.com/munki/munki/issues/921 for an example of the issue.
2019-03-14 09:29:28 -07:00
Greg Neagle
835133054a
MSC.app: Use a more Python-like method for determining boolean-ish values from Munki's preferences.
...
Works around an issue where Munki admins might be sloppy and assign string or integer values to
Munki preferences that should be booleans. Python interpeted these non-boolean values in a boolean
context in a way the prior Swift code did not (it treated all non-boolean values as false). This
change attempts to be more forgiving of admin error and treat these values the same way Python would.
Addresses #921
2019-03-14 08:59:45 -07:00
Greg Neagle
e81ed8be18
Display status of an item install before running a preinstall script, if any. Fixes #915
2019-03-10 15:58:05 -07:00
Greg Neagle
309ab3ddec
MSC.app: Fix for toolbar item labels sometimes remaining inactive. Fixes #918
2019-03-09 21:54:57 -08:00
Greg Neagle
aed4b4ba1c
Update base.css, detail.css and updates.css to match versions in MSC 4.8.3628
2019-03-08 11:45:20 -08:00