From a2f83852f6aca106a907eda91a4d4e830e8a8ae8 Mon Sep 17 00:00:00 2001 From: "ricardo.bartels@telekom.de" Date: Mon, 19 Jun 2023 23:56:03 +0200 Subject: [PATCH] fixes issue with rewriting device role 'Server' color #319 --- module/netbox/object_classes.py | 1 - module/sources/vmware/connection.py | 10 +++++----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/module/netbox/object_classes.py b/module/netbox/object_classes.py index 0089bed..2c2ba37 100644 --- a/module/netbox/object_classes.py +++ b/module/netbox/object_classes.py @@ -626,7 +626,6 @@ class NetBoxObject: # which is already saved in NetBox elif self._original_data.get(key) is None: self._original_data[key] = current_value_str - print(self._original_data[key]) new_value_str = new_value_str.replace("\n", " ") log.info(f"{self.name.capitalize()} '{display_name}' attribute '{key}' changed from " diff --git a/module/sources/vmware/connection.py b/module/sources/vmware/connection.py index 15e98a0..267f851 100644 --- a/module/sources/vmware/connection.py +++ b/module/sources/vmware/connection.py @@ -2409,10 +2409,10 @@ class VMWareHandler(SourceBase): server_role_object = self.inventory.get_by_data(NBDeviceRole, data={"name": "Server"}) if server_role_object is not None: - server_role_object.update(data={ - "name": "Server", - "color": "9e9e9e", - "vm_role": True - }) + role_data = {"name": "Server", "vm_role": True} + if server_role_object.is_new is True: + role_data["color"] = "9e9e9e" + + server_role_object.update(data=role_data) # EOF