From 3283b839377fe504284191b9a9a24e791ce9f1c5 Mon Sep 17 00:00:00 2001 From: Roman Perekhod Date: Wed, 17 Jul 2024 19:52:58 +0200 Subject: [PATCH] Fix a missing SecureView permission attribute in the REPORT response --- changelog/unreleased/fix-missing-secure-view-attr.md | 6 ++++++ services/search/pkg/search/search.go | 5 +++++ 2 files changed, 11 insertions(+) create mode 100644 changelog/unreleased/fix-missing-secure-view-attr.md diff --git a/changelog/unreleased/fix-missing-secure-view-attr.md b/changelog/unreleased/fix-missing-secure-view-attr.md new file mode 100644 index 0000000000..16db843955 --- /dev/null +++ b/changelog/unreleased/fix-missing-secure-view-attr.md @@ -0,0 +1,6 @@ +Bugfix: Fix a missing SecureView permission attribute in the REPORT response + +We fixed a missing SecureView permission attribute in the REPORT response. + +https://github.com/owncloud/ocis/pull/9638 +https://github.com/owncloud/ocis/issues/9607 diff --git a/services/search/pkg/search/search.go b/services/search/pkg/search/search.go index 4c53bd0a92..2e97ba65bb 100644 --- a/services/search/pkg/search/search.go +++ b/services/search/pkg/search/search.go @@ -10,7 +10,9 @@ import ( gateway "github.com/cs3org/go-cs3apis/cs3/gateway/v1beta1" rpc "github.com/cs3org/go-cs3apis/cs3/rpc/v1beta1" provider "github.com/cs3org/go-cs3apis/cs3/storage/provider/v1beta1" + "github.com/cs3org/reva/v2/pkg/conversions" "github.com/cs3org/reva/v2/pkg/rgrpc/todo/pool" + "github.com/cs3org/reva/v2/pkg/storage/utils/grants" "github.com/cs3org/reva/v2/pkg/utils" "github.com/owncloud/ocis/v2/ocis-pkg/log" @@ -141,6 +143,9 @@ func convertToWebDAVPermissions(isShared, isMountpoint, isDir bool, p *provider. p.GetInitiateFileUpload() { fmt.Fprintf(&b, "CK") } + if grants.PermissionsEqual(p, conversions.NewSecureViewerRole().CS3ResourcePermissions()) { + fmt.Fprintf(&b, "X") + } return b.String() }