mirror/opencloud
1
0
Fork 0
mirror of https://github.com/opencloud-eu/opencloud.git synced 2026-02-28 09:29:41 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2188 from owncloud/ignore_auth_on_status_php

Browse Source 
ignore authentication header on status.php
This commit is contained in:
Michael Barz
2021-06-16 21:15:42 +02:00
committed by GitHub
parent 36971ea28b 93b60b1770
commit 189d1485a9
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
changelog/unreleased/status_php_authentication.md Normal file
View File

@@ -0,0 +1,9 @@
Bugfix: Remove authentication from /status.php completely
Despite requests without Authentication header being successful, requests with an
invalid bearer token in the Authentication header were rejected in the proxy with
an 401 unauthenticated. Now the Authentication header is completely ignored for the
/status.php route.
https://github.com/owncloud/ocis/pull/2188
https://github.com/owncloud/client/issues/8538

2
proxy/pkg/middleware/oidc_auth.go
View File

@@ -155,7 +155,7 @@ func (m oidcAuth) shouldServe(req *http.Request) bool {
// todo: looks dirty, check later
// TODO: make a PR to coreos/go-oidc for exposing userinfo endpoint on provider, see https://github.com/coreos/go-oidc/issues/248
for _, ignoringPath := range []string{"/konnect/v1/userinfo"} {
for _, ignoringPath := range []string{"/konnect/v1/userinfo", "/status.php"} {
if req.URL.Path == ignoringPath {
return false
}