From ad0924d87427a0f737b687b12ba7e6c052feb741 Mon Sep 17 00:00:00 2001 From: Willy Kloucek Date: Wed, 19 Oct 2022 09:00:33 +0200 Subject: [PATCH 1/2] move the language-read-write permission's id and name into a const --- services/settings/pkg/store/defaults/defaults.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/services/settings/pkg/store/defaults/defaults.go b/services/settings/pkg/store/defaults/defaults.go index 1511b606d..fe5fd25f1 100644 --- a/services/settings/pkg/store/defaults/defaults.go +++ b/services/settings/pkg/store/defaults/defaults.go @@ -28,6 +28,11 @@ const ( // SettingsManagementPermissionName is the hardcoded setting name for the settings management permission SettingsManagementPermissionName string = "settings-management" + // LanguageReadWriteID is the hardcoded setting UUID for the language read write permission + LanguageReadWriteID string = "7d81f103-0488-4853-bce5-98dcce36d649" + // LanguageReadWriteID is the hardcoded setting name for the language read write permission + LanguageReadWriteName string = "language-readwrite" + // SetSpaceQuotaPermissionID is the hardcoded setting UUID for the set space quota permission SetSpaceQuotaPermissionID string = "4e6f9709-f9e7-44f1-95d4-b762d27b7896" // SetSpaceQuotaPermissionName is the hardcoded setting name for the set space quota permission @@ -124,8 +129,8 @@ func generateBundleAdminRole() *settingsmsg.Bundle { }, }, { - Id: "7d81f103-0488-4853-bce5-98dcce36d649", - Name: "language-readwrite", + Id: LanguageReadWriteID, + Name: LanguageReadWriteName, DisplayName: "Permission to read and set the language (anyone)", Resource: &settingsmsg.Resource{ Type: settingsmsg.Resource_TYPE_SETTING, From ca5affd9f36b36c65d298b2abf174e64dc357846 Mon Sep 17 00:00:00 2001 From: Willy Kloucek Date: Wed, 19 Oct 2022 10:25:54 +0200 Subject: [PATCH 2/2] fix comment --- services/settings/pkg/store/defaults/defaults.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/settings/pkg/store/defaults/defaults.go b/services/settings/pkg/store/defaults/defaults.go index fe5fd25f1..a68b35087 100644 --- a/services/settings/pkg/store/defaults/defaults.go +++ b/services/settings/pkg/store/defaults/defaults.go @@ -30,7 +30,7 @@ const ( // LanguageReadWriteID is the hardcoded setting UUID for the language read write permission LanguageReadWriteID string = "7d81f103-0488-4853-bce5-98dcce36d649" - // LanguageReadWriteID is the hardcoded setting name for the language read write permission + // LanguageReadWriteName is the hardcoded setting name for the language read write permission LanguageReadWriteName string = "language-readwrite" // SetSpaceQuotaPermissionID is the hardcoded setting UUID for the set space quota permission