From 270bf068405fe6deab1ccbba1fded8c635524a20 Mon Sep 17 00:00:00 2001 From: Swikriti Tripathi <41103328+SwikritiT@users.noreply.github.com> Date: Tue, 28 Mar 2023 15:11:41 +0545 Subject: [PATCH] add skip on stable tag (#5940) --- ...ected-failures-localAPI-on-OCIS-storage.md | 6 ++-- .../features/apiGraph/assignRole.feature | 2 +- .../apiGraph/changeOwnPassword.feature | 28 +++++++++---------- .../features/apiGraph/createUser.feature | 12 +++++--- .../features/apiGraph/editUser.feature | 14 +++++----- .../features/apiGraph/getApplications.feature | 4 +-- .../features/apiGraph/getUser.feature | 19 +++++++------ .../apiSpaces/spaceManagement.feature | 10 +++---- .../acceptance/features/apiSpaces/tag.feature | 2 +- .../apiSpacesShares/shareSpaces.feature | 24 ++++++++-------- .../shareSubItemOfSpace.feature | 6 ++-- 11 files changed, 66 insertions(+), 61 deletions(-) diff --git a/tests/acceptance/expected-failures-localAPI-on-OCIS-storage.md b/tests/acceptance/expected-failures-localAPI-on-OCIS-storage.md index b519110928..13bab45523 100644 --- a/tests/acceptance/expected-failures-localAPI-on-OCIS-storage.md +++ b/tests/acceptance/expected-failures-localAPI-on-OCIS-storage.md @@ -23,8 +23,8 @@ The expected failures in this file are from features in the owncloud/ocis repo. - [apiGraph/createGroupCaseSensitive.feature:21](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/createGroupCaseSensitive.feature#L21) - [apiGraph/createGroupCaseSensitive.feature:22](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/createGroupCaseSensitive.feature#L22) - [apiGraph/createGroup.feature:26](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/createGroup.feature#L26) -- [apiGraph/createUser.feature:29](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/createUser.feature#L29) -- [apiGraph/createUser.feature:62](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/createUser.feature#L62) +- [apiGraph/createUser.feature:35](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/createUser.feature#L35) +- [apiGraph/createUser.feature:66](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/createUser.feature#L66) ### [PROPFIND on accepted shares with identical names containing brackets exit with 404](https://github.com/owncloud/ocis/issues/4421) - [apiSpacesShares/changingFilesShare.feature:12](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/changingFilesShare.feature#L12) @@ -105,7 +105,6 @@ The expected failures in this file are from features in the owncloud/ocis repo. - [apiGraph/getUser.feature:40](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L40) - [apiGraph/getUser.feature:41](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L41) - [apiGraph/getUser.feature:42](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L42) -- [apiGraph/getUser.feature:143](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L143) - [apiGraph/getUser.feature:144](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L144) - [apiGraph/getUser.feature:145](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L145) - [apiGraph/getUser.feature:146](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L146) @@ -117,6 +116,7 @@ The expected failures in this file are from features in the owncloud/ocis repo. - [apiGraph/getUser.feature:152](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L152) - [apiGraph/getUser.feature:153](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L153) - [apiGraph/getUser.feature:154](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L154) +- [apiGraph/getUser.feature:155](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L155) #### [Sharing to a group with an expiration date does not work #5442](https://github.com/owncloud/ocis/issues/5442) - [apiSpacesShares/shareSubItemOfSpace.feature:105](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpace.feature#L105) diff --git a/tests/acceptance/features/apiGraph/assignRole.feature b/tests/acceptance/features/apiGraph/assignRole.feature index a352818aed..1cfdcac996 100644 --- a/tests/acceptance/features/apiGraph/assignRole.feature +++ b/tests/acceptance/features/apiGraph/assignRole.feature @@ -1,4 +1,4 @@ -@api +@api @skipOnStable2.0 Feature: assign role As an admin, I want to assign roles to users. diff --git a/tests/acceptance/features/apiGraph/changeOwnPassword.feature b/tests/acceptance/features/apiGraph/changeOwnPassword.feature index f51639c1c1..f1d42fbe7c 100644 --- a/tests/acceptance/features/apiGraph/changeOwnPassword.feature +++ b/tests/acceptance/features/apiGraph/changeOwnPassword.feature @@ -2,17 +2,17 @@ Feature: an user changes its own password - Scenario Outline: change own password - Given user "Alice" has been created with default attributes and without skeleton files - When the user "Alice" changes its own password "" to "" using the Graph API - Then the HTTP status code should be "" - Examples: - | currentPassword | newPassword | code | - | 123456 | validPass | 204 | - | 123456 | кириллица | 204 | - | 123456 | 密码 | 204 | - | 123456 | ?&^%0 | 204 | - | 123456 | | 400 | - | 123456 | 123456 | 400 | - | wrongPass | 123456 | 400 | - | | validPass | 400 | + Scenario Outline: change own password + Given user "Alice" has been created with default attributes and without skeleton files + When the user "Alice" changes its own password "" to "" using the Graph API + Then the HTTP status code should be "" + Examples: + | currentPassword | newPassword | code | + | 123456 | validPass | 204 | + | 123456 | кириллица | 204 | + | 123456 | 密码 | 204 | + | 123456 | ?&^%0 | 204 | + | 123456 | | 400 | + | 123456 | 123456 | 400 | + | wrongPass | 123456 | 400 | + | | validPass | 400 | diff --git a/tests/acceptance/features/apiGraph/createUser.feature b/tests/acceptance/features/apiGraph/createUser.feature index 76a0793398..1f9f220cf7 100644 --- a/tests/acceptance/features/apiGraph/createUser.feature +++ b/tests/acceptance/features/apiGraph/createUser.feature @@ -25,11 +25,15 @@ Feature: create user | withoutPassSameEmail | without pass | alice@example.org | | 200 | true | should | | name | pass with space | example@example.org | my pass | 200 | true | should | | nameWithCharacters(*:!;_+-&) | user | new@example.org | 123 | 400 | true | should not | - | withoutEmail | without email | | 123 | 200 | true | should | - | Alice | same userName | new@example.org | 123 | 400 | true | should | | name with space | name with space | example@example.org | 123 | 400 | true | should not | | createDisabledUser | disabled user | example@example.org | 123 | 200 | false | should | + @skipOnStable2.0 + Examples: + | userName | displayName | email | password | code | enable | shouldOrNot | + | withoutEmail | without email | | 123 | 200 | true | should | + | Alice | same userName | new@example.org | 123 | 400 | true | should | + Scenario: a user cannot be created with empty name Given the administrator has given "Alice" the role "Admin" using the settings api @@ -58,7 +62,7 @@ Feature: create user | User | | Guest | - @issue-3516 + @issue-3516 @skipOnStable2.0 Scenario: a user cannot be created with the name of the disabled user Given user "Brian" has been created with default attributes and without skeleton files And the administrator has given "Alice" the role "Admin" using the settings api @@ -71,7 +75,7 @@ Feature: create user | accountEnabled | true | Then the HTTP status code should be "400" - + @skipOnStable2.0 Scenario: a user can be created with the name of the deleted user Given user "Brian" has been created with default attributes and without skeleton files And the administrator has given "Alice" the role "Admin" using the settings api diff --git a/tests/acceptance/features/apiGraph/editUser.feature b/tests/acceptance/features/apiGraph/editUser.feature index 4c1f26d80f..844f66ab64 100644 --- a/tests/acceptance/features/apiGraph/editUser.feature +++ b/tests/acceptance/features/apiGraph/editUser.feature @@ -28,7 +28,7 @@ Feature: edit user | empty mail | | 400 | brian@example.com | | change to a invalid email | invalidEmail | 400 | brian@example.com | - + @skipOnStable2.0 Scenario Outline: the admin user can edit another user's name Given user "Carol" has been created with default attributes and without skeleton files When the user "Alice" changes the user name of user "Carol" to "" using the Graph API @@ -43,7 +43,7 @@ Feature: edit user | change to existing user name | Brian | 409 | Brian | | empty user name | | 400 | Brian | - + @skipOnStable2.0 Scenario: the admin user changes the name of a user to the name of an existing disabled user Given the user "Alice" has created a new user using the Graph API with the following settings: | userName | sam | @@ -57,7 +57,7 @@ Feature: edit user | key | value | | onPremisesSamAccountName | sam | - + @skipOnStable2.0 Scenario: the admin user changes the name of a user to the name of a previously deleted user Given the user "Alice" has created a new user using the Graph API with the following settings: | userName | sam | @@ -207,7 +207,7 @@ Feature: edit user | Guest | Guest | | Guest | Admin | - + @skipOnStable2.0 Scenario: the admin user disables another user When the user "Alice" disables user "Brian" using the Graph API Then the HTTP status code should be "200" @@ -217,7 +217,7 @@ Feature: edit user | displayName | id | mail | onPremisesSamAccountName | accountEnabled | | Brian Murphy | %uuid_v4% | brian@example.com | Brian | false | - + @skipOnStable2.0 Scenario Outline: a normal user should not be able to disable another user Given user "Carol" has been created with default attributes and without skeleton files And the administrator has given "Brian" the role "" using the settings api @@ -234,7 +234,7 @@ Feature: edit user | User | | Guest | - + @skipOnStable2.0 Scenario: the admin user enables disabled user Given the user "Alice" has disabled user "Brian" using the Graph API When the user "Alice" enables user "Brian" using the Graph API @@ -245,7 +245,7 @@ Feature: edit user | displayName | id | mail | onPremisesSamAccountName | accountEnabled | | Brian Murphy | %uuid_v4% | brian@example.com | Brian | true | - + @skipOnStable2.0 Scenario Outline: a normal user should not be able to enable another user Given user "Carol" has been created with default attributes and without skeleton files And the user "Alice" has disabled user "Carol" using the Graph API diff --git a/tests/acceptance/features/apiGraph/getApplications.feature b/tests/acceptance/features/apiGraph/getApplications.feature index 0843683dc7..3133619f8b 100644 --- a/tests/acceptance/features/apiGraph/getApplications.feature +++ b/tests/acceptance/features/apiGraph/getApplications.feature @@ -1,4 +1,4 @@ -@api @skipOnOcV10 +@api @skipOnOcV10 @skipOnStable2.0 Feature: get applications As an user I want to be able to get applications information with existings roles @@ -25,4 +25,4 @@ Feature: get applications | Admin | | Space Admin | | User | - | Guest | \ No newline at end of file + | Guest | diff --git a/tests/acceptance/features/apiGraph/getUser.feature b/tests/acceptance/features/apiGraph/getUser.feature index d9c8205048..44bfe00cc3 100644 --- a/tests/acceptance/features/apiGraph/getUser.feature +++ b/tests/acceptance/features/apiGraph/getUser.feature @@ -10,7 +10,7 @@ Feature: get users | Alice | | Brian | - + @skipOnStable2.0 Scenario: admin user gets the information of a user Given the administrator has given "Alice" the role "Admin" using the settings api When user "Alice" gets information of user "Brian" using Graph API @@ -41,7 +41,7 @@ Feature: get users | Guest | Guest | | Guest | Admin | - + @skipOnStable2.0 Scenario: admin user gets all users Given the administrator has given "Alice" the role "Admin" using the settings api When user "Alice" gets all users using the Graph API @@ -51,7 +51,7 @@ Feature: get users | Alice Hansen | %uuid_v4% | alice@example.org | Alice | true | | Brian Murphy | %uuid_v4% | brian@example.org | Brian | true | - + @skipOnStable2.0 Scenario: admin user gets all users include disabled users Given the administrator has given "Alice" the role "Admin" using the settings api And the user "Alice" has disabled user "Brian" using the Graph API @@ -74,7 +74,7 @@ Feature: get users | User | | Guest | - + @skipOnStable2.0 Scenario: admin user gets the drive information of a user Given the administrator has given "Alice" the role "Admin" using the settings api When the user "Alice" gets user "Brian" along with his drive information using Graph API @@ -93,7 +93,7 @@ Feature: get users | root@@@webDavUrl | %base_url%/dav/spaces/%space_id% | | webUrl | %base_url%/f/%space_id% | - + @skipOnStable2.0 Scenario Outline: non-admin user gets his/her own drive information Given the administrator has given "Brian" the role "" using the settings api When the user "Brian" gets his drive information using Graph API @@ -117,6 +117,7 @@ Feature: get users | User | | Guest | + @skipOnStable2.0 Scenario: admin user gets the group information of a user Given the administrator has given "Alice" the role "Admin" using the settings api And group "tea-lover" has been created @@ -153,7 +154,7 @@ Feature: get users | Guest | Guest | | Guest | Admin | - + @skipOnStable2.0 Scenario: admin user gets all users of certain groups Given the administrator has given "Alice" the role "Admin" using the settings api And user "Carol" has been created with default attributes and without skeleton files @@ -202,7 +203,7 @@ Feature: get users | displayName | id | mail | onPremisesSamAccountName | accountEnabled | | Carol King | %uuid_v4% | carol@example.org | Carol | false | - + @skipOnStable2.0 Scenario Outline: non admin user tries to get users of certain groups Given the administrator has given "Alice" the role "Admin" using the settings api And the administrator has given "Brian" the role "" using the settings api @@ -217,7 +218,7 @@ Feature: get users | User | | Guest | - + @skipOnStable2.0 Scenario: admin user gets all users with certain roles and members of a certain group Given the administrator has given "Alice" the role "Admin" using the settings api And user "Carol" has been created with default attributes and without skeleton files @@ -243,7 +244,7 @@ Feature: get users | displayName | id | mail | onPremisesSamAccountName | accountEnabled | | Carol King | %uuid_v4% | carol@example.org | Carol | true | - + @skipOnStable2.0 Scenario Outline: non-admin user tries to get users with a certain role Given the administrator has given "Alice" the role "" using the settings api When the user "Alice" gets all users with role "" using the Graph API diff --git a/tests/acceptance/features/apiSpaces/spaceManagement.feature b/tests/acceptance/features/apiSpaces/spaceManagement.feature index e8dc5fb071..f15089bd1e 100644 --- a/tests/acceptance/features/apiSpaces/spaceManagement.feature +++ b/tests/acceptance/features/apiSpaces/spaceManagement.feature @@ -201,7 +201,7 @@ Feature: Space management } """ - + @skipOnStable2.0 Scenario: The space admin user changes the name of the project space When user "Brian" changes the name of the "Project" space to "New Name" owned by user "Alice" Then the HTTP status code should be "200" @@ -241,7 +241,7 @@ Feature: Space management } """ - + @skipOnStable2.0 Scenario: The space admin user changes the description of the project space When user "Brian" changes the description of the "Project" space to "New description" owned by user "Alice" Then the HTTP status code should be "200" @@ -282,7 +282,7 @@ Feature: Space management } """ - + @skipOnStable2.0 Scenario: The space admin user disables the project space When user "Brian" disables a space "Project" owned by user "Alice" Then the HTTP status code should be "204" @@ -337,7 +337,7 @@ Feature: Space management | Brian | | Carol | - + @skipOnStable2.0 Scenario: The space admin user deletes the project space Given user "Alice" has disabled a space "Project" When user "Brian" deletes a space "Project" owned by user "Alice" @@ -386,7 +386,7 @@ Feature: Space management } """ - + @skipOnStable2.0 Scenario: The space admin user enables the project space Given user "Alice" has disabled a space "Project" When user "Brian" restores a disabled space "Project" owned by user "Alice" diff --git a/tests/acceptance/features/apiSpaces/tag.feature b/tests/acceptance/features/apiSpaces/tag.feature index e9ddd4da24..5cb8e2092b 100644 --- a/tests/acceptance/features/apiSpaces/tag.feature +++ b/tests/acceptance/features/apiSpaces/tag.feature @@ -1,4 +1,4 @@ -@api @skipOnOcV10 +@api @skipOnOcV10 @skipOnStable2.0 Feature: Tag The user can add a tag to resources for sorting and quick search diff --git a/tests/acceptance/features/apiSpacesShares/shareSpaces.feature b/tests/acceptance/features/apiSpacesShares/shareSpaces.feature index 7ff3de15df..a7c9284388 100644 --- a/tests/acceptance/features/apiSpacesShares/shareSpaces.feature +++ b/tests/acceptance/features/apiSpacesShares/shareSpaces.feature @@ -42,7 +42,7 @@ Feature: Share spaces | role | viewer | Then the user "Alice" should have a space called "share space" granted to user "Brian" with role "viewer" - + @skipOnStable2.0 Scenario: A user can see that the group has been granted access Given group "sales" has been created When user "Alice" shares a space "share space" with settings: @@ -210,7 +210,7 @@ Feature: Share spaces | viewer | manager | | viewer | editor | - + @skipOnStable2.0 Scenario Outline: A user shares a space with a group Given group "group2" has been created And the administrator has added a user "Brian" to the group "group2" using GraphApi @@ -234,7 +234,7 @@ Feature: Share spaces | editor | | viewer | - + @skipOnStable2.0 Scenario Outline: The user has no access to the space if access for the group has been removed Given group "group2" has been created And the administrator has added a user "Brian" to the group "group2" using GraphApi @@ -251,7 +251,7 @@ Feature: Share spaces | editor | | viewer | - + @skipOnStable2.0 Scenario: The user has no access to the space if he has been removed from the group Given group "group2" has been created And the administrator has added a user "Brian" to the group "group2" using GraphApi @@ -270,7 +270,7 @@ Feature: Share spaces | driveType | project | | name | share space | - + @skipOnStable2.0 Scenario: Users don't have access to the space if the group has been deleted Given group "group2" has been created And the administrator has added a user "Brian" to the group "group2" using GraphApi @@ -284,7 +284,7 @@ Feature: Share spaces And the user "Brian" should not have a space called "share space" And the user "Bob" should not have a space called "share space" - + @skipOnStable2.0 Scenario: User increases permissions for one member of the group or for the entire group Given group "sales" has been created And the administrator has added a user "Brian" to the group "sales" using GraphApi @@ -301,7 +301,7 @@ Feature: Share spaces When user "Brian" uploads a file inside space "share space" with content "Test" to "test.txt" using the WebDAV API Then the HTTP status code should be "201" - + @skipOnStable2.0 Scenario: User increases permissions for the group, so the user's permissions are increased Given group "sales" has been created And the administrator has added a user "Brian" to the group "sales" using GraphApi @@ -318,7 +318,7 @@ Feature: Share spaces When user "Brian" uploads a file inside space "share space" with content "Test" to "test.txt" using the WebDAV API Then the HTTP status code should be "201" - + @skipOnStable2.0 Scenario Outline: A Space Admin can share a space to the user with an expiration date When user "Alice" shares a space "share space" with settings: | shareWith | Brian | @@ -349,7 +349,7 @@ Feature: Share spaces | editor | | viewer | - + @skipOnStable2.0 Scenario Outline: update the expiration date of a space in user share Given user "Alice" has shared a space "share space" with settings: | shareWith | Brian | @@ -407,7 +407,7 @@ Feature: Share spaces | editor | | viewer | - + @skipOnStable2.0 Scenario Outline: update the expiration date of a space in group share Given group "sales" has been created And the administrator has added a user "Brian" to the group "sales" using GraphApi @@ -429,7 +429,7 @@ Feature: Share spaces | editor | | viewer | - + @skipOnStable2.0 Scenario Outline: check the end of expiration of a space in user share Given user "Alice" has shared a space "share space" with settings: | shareWith | Brian | @@ -444,7 +444,7 @@ Feature: Share spaces | editor | | viewer | - + @skipOnStable2.0 Scenario Outline: check the end of expiration of a space in group share Given group "sales" has been created And the administrator has added a user "Brian" to the group "sales" using GraphApi diff --git a/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpace.feature b/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpace.feature index fd4af96745..792b38f997 100644 --- a/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpace.feature +++ b/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpace.feature @@ -119,7 +119,7 @@ Feature: Share a file or folder that is inside a space And the information about the last share for user "Brian" should include | expiration | 2042-01-01 | - + @skipOnStable2.0 Scenario: A user changes the expiration date Given user "Alice" has created a share inside of space "share sub-item" with settings: | path | folder | @@ -147,7 +147,7 @@ Feature: Share a file or folder that is inside a space And the information about the last share for user "Brian" should include | expiration | | - + @skipOnStable2.0 Scenario: check the end of expiration date in user share Given user "Alice" has created a share inside of space "share sub-item" with settings: | path | folder | @@ -159,7 +159,7 @@ Feature: Share a file or folder that is inside a space Then the HTTP status code should be "200" Then as "Brian" folder "Shares/folder" should not exist - @issue-5823 @skip + @issue-5823 @skip @skipOnStable2.0 Scenario: check the end of expiration date in group share Given group "sales" has been created And the administrator has added a user "Brian" to the group "sales" using GraphApi