Address review

tests/acceptance/expected-failures-API-on-OCIS-storage.md

@@ -222,8 +222,7 @@ cannot share a folder with create permission
 - [coreApiShareOperationsToShares1/gettingShares.feature:222](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/gettingShares.feature#L222)
 
 #### [Public link enforce permissions](https://github.com/owncloud/ocis/issues/1269)
-- [coreApiSharePublicLink1/createPublicLinkShare.feature:528](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShare.feature#L528)
-- [coreApiSharePublicLink1/createPublicLinkShare.feature:549](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShare.feature#L549)
+- [coreApiSharePublicLink1/createPublicLinkShare.feature:353](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShare.feature#L353)
 
 #### [download previews of other users file](https://github.com/owncloud/ocis/issues/2071)
 
@@ -246,12 +245,6 @@ cannot share a folder with create permission
 - [coreApiWebdavPreviews/previews.feature:176](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavPreviews/previews.feature#L176)
 - [coreApiWebdavPreviews/previews.feature:177](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavPreviews/previews.feature#L177)
 
-#### [creating public links with permissions fails](https://github.com/owncloud/product/issues/252)
-
-- [coreApiSharePublicLink1/changingPublicLinkShare.feature:30](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiSharePublicLink1/changingPublicLinkShare.feature#L30)
-- [coreApiSharePublicLink1/changingPublicLinkShare.feature:51](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiSharePublicLink1/changingPublicLinkShare.feature#L51)
-- [coreApiSharePublicLink1/changingPublicLinkShare.feature:90](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiSharePublicLink1/changingPublicLinkShare.feature#L90)
-
 #### [copying a folder within a public link folder to folder with same name as an already existing file overwrites the parent file](https://github.com/owncloud/ocis/issues/1232)
 
 - [coreApiSharePublicLink2/copyFromPublicLink.feature:63](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiSharePublicLink2/copyFromPublicLink.feature#L63)
@@ -428,6 +421,7 @@ API, search, favorites, config, capabilities, not existing endpoints, CORS and o
 - [coreApiAuthOcs/ocsGETAuth.feature:121](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiAuthOcs/ocsGETAuth.feature#L121)
 - [coreApiAuthOcs/ocsPOSTAuth.feature:8](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiAuthOcs/ocsPOSTAuth.feature#L8)
 - [coreApiAuthOcs/ocsPUTAuth.feature:8](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiAuthOcs/ocsPUTAuth.feature#L8)
+- [coreApiSharePublicLink1/createPublicLinkShare.feature:343](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShare.feature#L343)
 
 #### [sending MKCOL requests to another user's webDav endpoints as normal user gives 404 instead of 403 ](https://github.com/owncloud/ocis/issues/3872)
 

tests/acceptance/features/coreApiSharePublicLink1/accessToPublicLinkShare.feature

@@ -1,4 +1,4 @@
-@api @public_link_share-feature-required @files_sharing-app-required @issue-ocis-reva-282 @issue-4623 @notToImplementOnOCIS
+@api @public_link_share-feature-required @files_sharing-app-required @issue-ocis-reva-282
 Feature: accessing a public link share
 
   Background:

tests/acceptance/features/coreApiSharePublicLink1/changingPublicLinkShare.feature

@@ -14,16 +14,16 @@ Feature: changing a public link share
     Given user "Alice" has created a public link share with settings
       | path        | /PARENT       |
       | permissions | <permissions> |
-    When the public deletes file "parent.txt" from the last public link share using the <public-webdav-api-version> public WebDAV API
+    When the public deletes file "parent.txt" from the last public link share using the new public WebDAV API
     Then the HTTP status code should be "<http-status-code>"
     And as "Alice" file "PARENT/parent.txt" <should-or-not> exist
 
     Examples:
-      | permissions               | http-status-code | should-or-not | public-webdav-api-version |
-      | read                      | 403              | should        | new                       |
-      | read,create               | 403              | should        | new                       |
-      | create                    | 403              | should        | new                       |
-      | read,update,create,delete | 204              | should not    | new                       |
+      | permissions               | http-status-code | should-or-not |
+      | read                      | 403              | should        |
+      | read,create               | 403              | should        |
+      | create                    | 403              | should        |
+      | read,update,create,delete | 204              | should not    |
 
 
   Scenario: Public link share permissions work correctly for renaming and share permissions read,update,create,delete using the public WebDAV API

tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShare.feature

@@ -301,7 +301,6 @@ Feature: create a public link share
       | name                   |                      |
     And the public should be able to download file "/randomfile.txt" from inside the last public link shared folder using the new public WebDAV API without password and the content should be "Random data"
     And the public upload to the last publicly shared folder using the new public WebDAV API should fail with HTTP status code "403"
-
     Examples:
       | ocs_api_version | ocs_status_code |
       | 1               | 100             |
@@ -347,8 +346,8 @@ Feature: create a public link share
     And user "Alice" has created a public link share with settings
       | path        | PARENT |
       | permissions | read   |
-    And user "Alice" has deleted folder "PARENT"
-    When the public download of file "/parent.txt" from inside the last public link shared folder using the new public WebDAV API should fail with HTTP status code "404"
+    When user "Alice" deletes folder "/PARENT" using the WebDAV API
+    Then the public download of file "/parent.txt" from inside the last public link shared folder using the new public WebDAV API should fail with HTTP status code "404"
 
   @issue-ocis-reva-292 @issue-ocis-reva-199
   Scenario: try to download from a public share that has upload only permissions using the public webdav api