From 46a8dee1261759e3e4d805677175632c8bf013a6 Mon Sep 17 00:00:00 2001 From: Dominik Schmidt Date: Tue, 19 May 2026 10:29:07 +0200 Subject: [PATCH 1/2] fix(debug): drop duplicate service field from probe fallback log The base logger created by log.Configure already attaches a "service" field via its context. handleProbe added it a second time, producing JSON log entries with two "service" keys. Remove the redundant Str("service", name) and the now-unused name parameter. --- pkg/service/debug/service.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/pkg/service/debug/service.go b/pkg/service/debug/service.go index 0cf6b990e6..a28f46c505 100644 --- a/pkg/service/debug/service.go +++ b/pkg/service/debug/service.go @@ -18,11 +18,10 @@ import ( graphMiddleware "github.com/opencloud-eu/opencloud/services/graph/pkg/middleware" ) -var handleProbe = func(mux *http.ServeMux, pattern string, h http.Handler, name string, logger log.Logger) { +var handleProbe = func(mux *http.ServeMux, pattern string, h http.Handler, logger log.Logger) { if h == nil { h = handlers.NewCheckHandler(handlers.NewCheckHandlerConfiguration()) logger.Info(). - Str("service", name). Str("endpoint", pattern). Msg("no probe provided, reverting to default (OK)") } @@ -45,8 +44,8 @@ func NewService(opts ...Option) *http.Server { promhttp.Handler(), )) - handleProbe(mux, "/healthz", dopts.Health, dopts.Name, dopts.Logger) // healthiness check - handleProbe(mux, "/readyz", dopts.Ready, dopts.Name, dopts.Logger) // readiness check + handleProbe(mux, "/healthz", dopts.Health, dopts.Logger) // healthiness check + handleProbe(mux, "/readyz", dopts.Ready, dopts.Logger) // readiness check if dopts.ConfigDump != nil { mux.Handle("/config", dopts.ConfigDump) From 0ad6112dd2d34bd827244457deda92f06b97dda6 Mon Sep 17 00:00:00 2001 From: Dominik Schmidt Date: Tue, 19 May 2026 11:13:59 +0200 Subject: [PATCH 2/2] chore(debug): remove leftover commented-out probeHandler --- pkg/service/debug/service.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/pkg/service/debug/service.go b/pkg/service/debug/service.go index a28f46c505..026f2e90ec 100644 --- a/pkg/service/debug/service.go +++ b/pkg/service/debug/service.go @@ -29,8 +29,6 @@ var handleProbe = func(mux *http.ServeMux, pattern string, h http.Handler, logge mux.Handle(pattern, h) } -//var probeHandler = func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) } - // NewService initializes a new debug service. func NewService(opts ...Option) *http.Server { dopts := newOptions(opts...)