From 48f9e79ff4fd110fb72bdf027d26c4e8580ce484 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rn=20Friedrich=20Dreyer?= Date: Fri, 28 Jun 2024 10:54:00 +0200 Subject: [PATCH] ignore addresses for kubernetes registry MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Jörn Friedrich Dreyer --- .../unreleased/ignore-address-for-kubernetes-registry.md | 5 +++++ ocis-pkg/registry/registry.go | 4 +--- 2 files changed, 6 insertions(+), 3 deletions(-) create mode 100644 changelog/unreleased/ignore-address-for-kubernetes-registry.md diff --git a/changelog/unreleased/ignore-address-for-kubernetes-registry.md b/changelog/unreleased/ignore-address-for-kubernetes-registry.md new file mode 100644 index 0000000000..db857f75c7 --- /dev/null +++ b/changelog/unreleased/ignore-address-for-kubernetes-registry.md @@ -0,0 +1,5 @@ +Bugfix: Ignore address for kubernetes registry + +We no longer pass an address to the go micro kubernetes registry implementation. This causes the implementation to autodetect the namespace and not hardcode it to `default`. + +https://github.com/owncloud/ocis/pull/9490 diff --git a/ocis-pkg/registry/registry.go b/ocis-pkg/registry/registry.go index 1672a1a8e1..77bfd2e97c 100644 --- a/ocis-pkg/registry/registry.go +++ b/ocis-pkg/registry/registry.go @@ -68,9 +68,7 @@ func GetRegistry(opts ...Option) mRegistry.Registry { cfg.DisableCache = true // no cache needed for in-memory registry case "kubernetes": fmt.Println("Attention: kubernetes registry is deprecated, use nats-js-kv instead") - _reg = kubernetesr.NewRegistry( - mRegistry.Addrs(cfg.Addresses...), - ) + _reg = kubernetesr.NewRegistry() case "nats": fmt.Println("Attention: nats registry is deprecated, use nats-js-kv instead") _reg = natsr.NewRegistry(