From 49c7159acbe772229ed6365dbe1f6c8dfeca2498 Mon Sep 17 00:00:00 2001 From: Christian Richter Date: Fri, 17 Jun 2022 09:13:08 +0200 Subject: [PATCH] describe what KID in IDP_SIGNING_KID means Signed-off-by: Christian Richter --- extensions/auth-machine/pkg/config/config.go | 4 ---- extensions/idp/pkg/config/config.go | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/extensions/auth-machine/pkg/config/config.go b/extensions/auth-machine/pkg/config/config.go index eee4a9c340..e2a363c3e1 100644 --- a/extensions/auth-machine/pkg/config/config.go +++ b/extensions/auth-machine/pkg/config/config.go @@ -20,10 +20,6 @@ type Config struct { SkipUserGroupsInToken bool `yaml:"skip_user_groups_in_token" env:"AUTH_MACHINE_SKIP_USER_GROUPS_IN_TOKEN" desc:"Skip storing all groups of a user in the jwt token."` - SkipUserGroupsInToken bool `yaml:"skip_user_groups_in_token" env:"AUTH_MACHINE_SKIP_USER_GROUPS_IN_TOKEN" desc:"Disables the encoding of the user's group memberships in the reva access token. This reduces token size, especially when users are members of a large number of groups."` - - Did you intend to duplicate `SkipUserGroupsInToken` that is already at line 21? - MachineAuthAPIKey string `yaml:"machine_auth_api_key" env:"OCIS_MACHINE_AUTH_API_KEY;AUTH_MACHINE_API_KEY" desc:"Machine auth API key used for validating requests from other services when impersonating users."` Supervised bool `yaml:"-"` diff --git a/extensions/idp/pkg/config/config.go b/extensions/idp/pkg/config/config.go index e08b32ba76..df25ff68bd 100644 --- a/extensions/idp/pkg/config/config.go +++ b/extensions/idp/pkg/config/config.go @@ -103,7 +103,7 @@ type Settings struct { IdentifierDefaultUsernameHintText string IdentifierUILocales []string - SigningKid string `yaml:"signing_kid" env:"IDP_SIGNING_KID" desc:"Value of kid field to use in created tokens (uniquely identifying the signing-private-key)."` + SigningKid string `yaml:"signing_kid" env:"IDP_SIGNING_KID" desc:"Value of the KID (Key ID) field which is used in created tokens to uniquely identify the signing-private-key."` SigningMethod string `yaml:"signing_method" env:"IDP_SIGNING_METHOD" desc:"Signing method of idp requests (e.g. PS256)"` SigningPrivateKeyFiles []string `yaml:"signing_private_key_files" env:"IDP_SIGNING_PRIVATE_KEY_FILES" desc:"Private key files for signing idp requests."` ValidationKeysPath string `yaml:"validation_keys_path" env:"IDP_VALIDATION_KEYS_PATH" desc:"Path to validation keys for idp requests."`