Fix nil pointer exception in webfinger

Co-authoredjby: Jörn Dreyer <jdreyer@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>

services/webfinger/pkg/config/config.go

@@ -22,6 +22,7 @@ type Config struct {
 	Relations []string   `yaml:"relations" env:"WEBFINGER_RELATIONS" desc:"A comma-separated list of relation URIs or registered relation types to add to webfinger responses."`
 	IDP       string     `yaml:"idp" env:"OCIS_URL;OCIS_OIDC_ISSUER;WEBFINGER_OIDC_ISSUER" desc:"The identity provider href for the openid-discovery relation."`
 	OcisURL   string     `yaml:"ocis_url" env:"OCIS_URL;WEBFINGER_OWNCLOUD_SERVER_INSTANCE_URL" desc:"The URL for the legacy ownCloud server instance relation (not to be confused with the product ownCloud Server). It defaults to the OCIS_URL but can be overridden to support some reverse proxy corner cases. To shard the deployment, multiple instances can be configured in the configuration file."`
+	Insecure  bool       `yaml:"insecure" env:"OCIS_INSECURE;WEBFINGER_INSECURE" desc:"Allow insecure connections to the WEBFINGER service."`
 
 	Context context.Context `yaml:"-"`
 }

services/webfinger/pkg/config/defaults/defaultconfig.go

@@ -48,6 +48,8 @@ func DefaultConfig() *config.Config {
 				},
 			},
 		},
+		IDP:      "https://localhost:9200",
+		Insecure: false,
 	}
 }
 

services/webfinger/pkg/server/http/server.go

@@ -1,8 +1,10 @@
 package http
 
 import (
+	"crypto/tls"
 	"net/http"
 	"net/url"
+	"time"
 
 	"github.com/go-chi/chi/v5"
 	chimiddleware "github.com/go-chi/chi/v5/middleware"
@@ -60,9 +62,21 @@ func Server(opts ...Option) (ohttp.Service, error) {
 		version.String,
 	))
 
+	var oidcHTTPClient = &http.Client{
+		Transport: &http.Transport{
+			TLSClientConfig: &tls.Config{
+				MinVersion:         tls.VersionTLS12,
+				InsecureSkipVerify: options.Config.Insecure, //nolint:gosec
+			},
+			DisableKeepAlives: true,
+		},
+		Timeout: time.Second * 10,
+	}
+
 	mux.Use(middleware.OidcAuth(
 		middleware.WithLogger(options.Logger),
 		middleware.WithOidcIssuer(options.Config.IDP),
+		middleware.WithHttpClient(*oidcHTTPClient),
 	))
 
 	// this logs http request related data