mirror/opencloud
1
0
Fork 0
mirror of https://github.com/opencloud-eu/opencloud.git synced 2026-03-20 22:10:39 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: use a tmp file and rename to prevent a possible race condition

Browse Source
This commit is contained in:
Juan Pablo Villafáñez
2024-11-29 14:16:07 +01:00
parent 7f5a2ed00e
commit 56f012ceb6
1 changed files with 20 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
services/thumbnails/pkg/thumbnail/storage/filesystem.go
View File

@@ -62,14 +62,29 @@ func (s FileSystem) Put(key string, img []byte) error {
}
if _, err := os.Stat(imgPath); os.IsNotExist(err) {
f, err := os.Create(imgPath)
f, err := os.CreateTemp(dir, "tmpthumb")
if err != nil {
return errors.Wrapf(err, "could not create file \"%s\"", key)
return errors.Wrapf(err, "could not create temporary file for \"%s\"", key)
}
defer f.Close()
if _, err = f.Write(img); err != nil {
return errors.Wrapf(err, "could not write to file \"%s\"", key)
_, writeErr := f.Write(img) // write the thumbnail in the temporary file
f.Close() // close the file regardless of the error
// if there was a problem writing, remove the temporary file
if writeErr != nil {
if remErr := os.Remove(f.Name()); remErr != nil {
return errors.Wrapf(remErr, "could not cleanup temporary file for \"%s\"", key)
}
return errors.Wrapf(writeErr, "could not write to temporary file for \"%s\"", key)
}
// rename the temporary file to the final file
if renErr := os.Rename(f.Name(), imgPath); renErr != nil {
// if we couldn't rename, remove the temporary file
if remErr := os.Remove(f.Name()); remErr != nil {
return errors.Wrapf(remErr, "rename failed and could not cleanup temporary file for \"%s\"", key)
}
return errors.Wrapf(err, "could not rename temporary file to \"%s\"", key)
}
}