mirror of
https://github.com/opencloud-eu/opencloud.git
synced 2026-01-04 11:19:39 -06:00
Merge pull request #1758 from owncloud/remove-log-secrets
remove JWT from logs
This commit is contained in:
5
changelog/unreleased/remove-log-secret.md
Normal file
5
changelog/unreleased/remove-log-secret.md
Normal file
@@ -0,0 +1,5 @@
|
||||
Enhancement: Remove the JWT from the log
|
||||
|
||||
We were logging the JWT in some places. Secrets should not be exposed in logs so it got removed.
|
||||
|
||||
https://github.com/owncloud/ocis/pull/1758
|
||||
@@ -85,7 +85,7 @@ func OpenIDConnect(opts ...ocisoidc.Option) func(http.Handler) http.Handler {
|
||||
}
|
||||
userInfo, err := oidcProvider.UserInfo(customCtx, oauth2.StaticTokenSource(oauth2Token))
|
||||
if err != nil {
|
||||
opt.Logger.Error().Err(err).Str("token", string(token)).Msg("Failed to get userinfo")
|
||||
opt.Logger.Error().Err(err).Msg("Failed to get userinfo")
|
||||
http.Error(w, ErrInvalidToken.Error(), http.StatusUnauthorized)
|
||||
return
|
||||
}
|
||||
|
||||
@@ -91,7 +91,7 @@ func (m oidcAuth) getClaims(token string, req *http.Request) (claims oidc.Standa
|
||||
oauth2.StaticTokenSource(oauth2Token),
|
||||
)
|
||||
if err != nil {
|
||||
m.logger.Error().Err(err).Str("token", token).Msg("Failed to get userinfo")
|
||||
m.logger.Error().Err(err).Msg("Failed to get userinfo")
|
||||
status = http.StatusUnauthorized
|
||||
return
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user