Addressed reviews

This commit is contained in:
Prarup Gurung
2024-05-03 09:50:52 +05:45
parent 7423fa3a4b
commit 68f03f2f5e
2 changed files with 1 additions and 5 deletions

View File

@@ -897,7 +897,6 @@ Feature: user GDPR (General Data Protection Regulation) report
"pattern": "^%user_id_pattern%$"
},
"type": {
"type": "number",
"const": 1
}
}
@@ -915,13 +914,11 @@ Feature: user GDPR (General Data Protection Regulation) report
"pattern": "^%user_id_pattern%$"
},
"type": {
"type": "number",
"const": 1
}
}
},
"GranteeGroupID": {
"type": ["number", "null"],
"const": null
},
"GranteeUserID": {
@@ -937,7 +934,6 @@ Feature: user GDPR (General Data Protection Regulation) report
}
},
"type": {
"type": "string",
"const": "events.SpaceShared"
}
}

View File

@@ -754,7 +754,7 @@ trait Sharing {
$user = $this->getActualUsername($user);
if ($updateLastPublicLink) {
$share_id = (FeatureContext::isUsingSharingNG()) ? $this->shareNgGetLastCreatedLinkShareID() : (string) $this->getLastCreatedPublicShare()->id;
$share_id = ($this->isUsingSharingNG()) ? $this->shareNgGetLastCreatedLinkShareID() : (string) $this->getLastCreatedPublicShare()->id;
} else {
if ($shareOwner === null) {
$share_id = $this->getLastCreatedUserGroupShareId();