From 693bc7b38f63b6de85ca9733eaadeb277461700d Mon Sep 17 00:00:00 2001 From: Ralf Haferkamp Date: Wed, 28 Feb 2024 16:14:10 +0100 Subject: [PATCH] Fix typos (cherry picked from commit 10babaf4c527d91825f70cea68065f44dc01b8da) --- changelog/unreleased/sharing-ng-mount.md | 2 +- services/graph/pkg/service/v0/api_drives_drive_item.go | 2 +- services/graph/pkg/service/v0/utils.go | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/changelog/unreleased/sharing-ng-mount.md b/changelog/unreleased/sharing-ng-mount.md index 503a6a2121..f1da7ef170 100644 --- a/changelog/unreleased/sharing-ng-mount.md +++ b/changelog/unreleased/sharing-ng-mount.md @@ -1,6 +1,6 @@ Enhancement: graphs endpoint for mounting and unmounting shares Functionality for mounting (accepting) and unmounting (rejecting) received -has been added to the graph API +shares has been added to the graph API. https://github.com/owncloud/ocis/pull/7885 diff --git a/services/graph/pkg/service/v0/api_drives_drive_item.go b/services/graph/pkg/service/v0/api_drives_drive_item.go index 4f0d6329bb..e602e4d2de 100644 --- a/services/graph/pkg/service/v0/api_drives_drive_item.go +++ b/services/graph/pkg/service/v0/api_drives_drive_item.go @@ -57,7 +57,7 @@ func (s DrivesDriveItemService) UnmountShare(ctx context.Context, resourceID sto } // This is a a bit of a hack. We should not rely on a specific format of the item id. - // (But currently the ShareID is + // But currently there is no other way to get the ShareID. shareId := resourceID.GetOpaqueId() // Now, find out the resourceID of the shared resource diff --git a/services/graph/pkg/service/v0/utils.go b/services/graph/pkg/service/v0/utils.go index 578c3d1cb0..ded1ca58c7 100644 --- a/services/graph/pkg/service/v0/utils.go +++ b/services/graph/pkg/service/v0/utils.go @@ -228,7 +228,7 @@ func cs3ReceivedSharesToDriveItems(ctx context.Context, // the oldest share for the resource: // '$! // Note: This means that the driveitem ID will change when the oldest - // shared is removed. It would be good to have are more stable ID here (e.g. + // share is removed. It would be good to have are more stable ID here (e.g. // derived from the shared resource's ID. But as we need to use the same // ID across all services this means we needed to make similar adjustments // to the sharejail (usershareprovider, webdav). Which we can't currently do @@ -320,8 +320,8 @@ func cs3ReceivedSharesToDriveItems(ctx context.Context, if err != nil { // TODO: define a proper error behavior here. We don't // want the whole request to fail just because a single - // resource owner couldn't be resolved. But, should be - // really return the affect share in the response? + // resource owner couldn't be resolved. But, should we + // really return the affected share in the response? // For now we just log a warning. The returned // identitySet will just contain the userid. logger.Warn().Err(err).Str("userid", userID.String()).Msg("could not get owner of shared resource")