From 95cb4b5351d7f58f81547de6aa00d38948ca7d0e Mon Sep 17 00:00:00 2001 From: Jannik Stehle Date: Tue, 11 Oct 2022 10:55:22 +0200 Subject: [PATCH 1/7] Update web to v6.0.0-rc.1 --- .drone.env | 2 +- changelog/unreleased/update-web-6.0.0-rc.1.md | 41 +++++++++++++++++++ services/web/Makefile | 2 +- 3 files changed, 43 insertions(+), 2 deletions(-) create mode 100644 changelog/unreleased/update-web-6.0.0-rc.1.md diff --git a/.drone.env b/.drone.env index dcc4502297..10f287fa4d 100644 --- a/.drone.env +++ b/.drone.env @@ -3,5 +3,5 @@ CORE_COMMITID=ddd3b90f4aea35a459a6fedf78a9bcf110dc3303 CORE_BRANCH=master # The test runner source for UI tests -WEB_COMMITID=283eb8eebcfbcdce76198f76d465c73e3094ba8b +WEB_COMMITID=09120268c6bc311f3456bb6aef70b11e97618f51 WEB_BRANCH=master diff --git a/changelog/unreleased/update-web-6.0.0-rc.1.md b/changelog/unreleased/update-web-6.0.0-rc.1.md new file mode 100644 index 0000000000..d40027477b --- /dev/null +++ b/changelog/unreleased/update-web-6.0.0-rc.1.md @@ -0,0 +1,41 @@ +Enhancement: Update ownCloud Web to v6.0.0-rc.1 + +Tags: web + +We updated ownCloud Web to v6.0.0-rc.1. Please refer to the changelog (linked) for details on the web release. + +* Bugfix [#7419](https://github.com/owncloud/web/issues/7419): Add language param opening external app +* Bugfix [#7731](https://github.com/owncloud/web/pull/7731): "Copy Quicklink"-translations +* Bugfix [#7652](https://github.com/owncloud/web/pull/7652): Disable copy/move overwrite on self +* Bugfix [#7739](https://github.com/owncloud/web/pull/7739): Disable shares loading on public and trash locations +* Bugfix [#7740](https://github.com/owncloud/web/pull/7740): Disappearing quicklink in sidebar +* Bugfix [#7734](https://github.com/owncloud/web/pull/7734): File name reactivity +* Bugfix [#7724](https://github.com/owncloud/web/pull/7724): Folder conflict dialog +* Bugfix [#7652](https://github.com/owncloud/web/pull/7652): Inhibit move files between spaces +* Bugfix [#7640](https://github.com/owncloud/web/pull/7640): "Private link"-button alignment +* Bugfix [#7748](https://github.com/owncloud/web/pull/7748): Reload file list after last share removal +* Bugfix [#7699](https://github.com/owncloud/web/issues/7699): Remove the "close sidebar"-calls on delete +* Bugfix [#7504](https://github.com/owncloud/web/pull/7504): Resolve upload existing folder +* Bugfix [#7675](https://github.com/owncloud/web/pull/7675): Search bar on small screens +* Bugfix [#7662](https://github.com/owncloud/web/pull/7662): Sidebar for received shares in search file list +* Bugfix [#7506](https://github.com/owncloud/web/issues/7506): Shares loading +* Bugfix [#7632](https://github.com/owncloud/web/pull/7632): Sidebar toggle icon +* Bugfix [#7756](https://github.com/owncloud/web/pull/7756): Try to obtain refresh token before the error case +* Bugfix [#7651](https://github.com/owncloud/web/pull/7651): Spaces on "Shared via link"-page +* Bugfix [#7521](https://github.com/owncloud/web/issues/7521): Spaces reactivity on update +* Bugfix [#7630](https://github.com/owncloud/web/pull/7630): Upload modify time +* Change [#6648](https://github.com/owncloud/web/issues/6648): Drive aliases in URLs +* Enhancement [#7709](https://github.com/owncloud/web/pull/7709): Edit custom permissions wording +* Enhancement [#7190](https://github.com/owncloud/web/pull/7190): Deny subfolders inside share +* Enhancement [#7684](https://github.com/owncloud/web/pull/7684): Design polishing +* Enhancement [#7725](https://github.com/owncloud/web/pull/7725): Enable renaming on received shares +* Enhancement [#7747](https://github.com/owncloud/web/pull/7747): Friendlier logout screen +* Enhancement [#6247](https://github.com/owncloud/web/issues/6247): Id based routing +* Enhancement [#7405](https://github.com/owncloud/web/pull/7405): Resolve internal links +* Enhancement [#7569](https://github.com/owncloud/web/pull/7569): Make keybindings global +* Enhancement [#7405](https://github.com/owncloud/web/pull/7405): Resolve private links +* Enhancement [#7684](https://github.com/owncloud/web/pull/7684): Update ODS to v14.0.0-alpha.20 +* Enhancement [#7430](https://github.com/owncloud/web/pull/7430): Webdav support in web-client package + +https://github.com/owncloud/ocis/pull/4779 +https://github.com/owncloud/web/releases/tag/v6.0.0-rc.1 diff --git a/services/web/Makefile b/services/web/Makefile index fa880e686c..7de0a43ea6 100644 --- a/services/web/Makefile +++ b/services/web/Makefile @@ -1,6 +1,6 @@ SHELL := bash NAME := web -WEB_ASSETS_VERSION = v5.7.0 +WEB_ASSETS_VERSION = v6.0.0-rc.1 include ../../.make/recursion.mk From bd9eee17f52aeea2067900972c220ba67b3ee446 Mon Sep 17 00:00:00 2001 From: Jannik Stehle Date: Tue, 11 Oct 2022 15:14:49 +0200 Subject: [PATCH 2/7] Adjust expected acceptance test failures --- ...res-webUI-on-OCIS-storage-ocisSmokeTest.md | 3 - ...expected-failures-webUI-on-OCIS-storage.md | 76 ++++--------------- 2 files changed, 15 insertions(+), 64 deletions(-) diff --git a/tests/acceptance/expected-failures-webUI-on-OCIS-storage-ocisSmokeTest.md b/tests/acceptance/expected-failures-webUI-on-OCIS-storage-ocisSmokeTest.md index 932d262614..f17b986242 100644 --- a/tests/acceptance/expected-failures-webUI-on-OCIS-storage-ocisSmokeTest.md +++ b/tests/acceptance/expected-failures-webUI-on-OCIS-storage-ocisSmokeTest.md @@ -14,6 +14,3 @@ Only the web scenarios tagged ocisSmokeTest are run by default in OCIS CI. This ### [Copy private link option not available](https://github.com/owncloud/ocis/issues/1409) - [webUIPrivateLinks/accessingPrivateLinks.feature:9](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIPrivateLinks/accessingPrivateLinks.feature#L9) - [webUIPrivateLinks/accessingPrivateLinks.feature:17](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIPrivateLinks/accessingPrivateLinks.feature#L17) - -### [impossible to navigate into a folder in the trashbin](https://github.com/owncloud/web/issues/1725) -- [webUITrashbinDelete/trashbinDelete.feature:29](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L29) diff --git a/tests/acceptance/expected-failures-webUI-on-OCIS-storage.md b/tests/acceptance/expected-failures-webUI-on-OCIS-storage.md index dd154bcb8d..89c5c5d977 100644 --- a/tests/acceptance/expected-failures-webUI-on-OCIS-storage.md +++ b/tests/acceptance/expected-failures-webUI-on-OCIS-storage.md @@ -74,7 +74,7 @@ Other free text and Markdown formatting can be used elsewhere in the document if - [webUIPrivateLinks/accessingPrivateLinks.feature:25](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIPrivateLinks/accessingPrivateLinks.feature#L25) ### [Share additional info](https://github.com/owncloud/ocis/issues/1253) -- [webUISharingInternalUsersShareWithPage/shareWithUsers.feature:140](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalUsersShareWithPage/shareWithUsers.feature#L140) +- [webUISharingInternalUsersShareWithPage/shareWithUsers.feature:138](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalUsersShareWithPage/shareWithUsers.feature#L138) ### [Expiration date set is not implemented in user share](https://github.com/owncloud/ocis/issues/1250) - [webUISharingInternalGroups/shareWithGroups.feature:279](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature#L279) @@ -98,7 +98,7 @@ Other free text and Markdown formatting can be used elsewhere in the document if - [webUISharingPublicManagement/shareByPublicLink.feature:133](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/shareByPublicLink.feature#L133) ### [Propfind response to trashbin endpoint is different in ocis](https://github.com/owncloud/product/issues/186) -- [webUIFilesSearch/search.feature:178](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesSearch/search.feature#L178) +- [webUIFilesSearch/search.feature:131](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesSearch/search.feature#L131) ### [restoring a file from "Deleted files" (trashbin) is not possible if the original folder does not exist any-more](https://github.com/owncloud/web/issues/1753) - [webUITrashbinRestore/trashbinRestore.feature:138](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinRestore/trashbinRestore.feature#L138) @@ -107,7 +107,7 @@ Other free text and Markdown formatting can be used elsewhere in the document if - [webUIUpload/uploadFileGreaterThanQuotaSize.feature:12](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/uploadFileGreaterThanQuotaSize.feature#L12) ### [restoring a file deleted from a received shared folder is not possible](https://github.com/owncloud/ocis/issues/1124) -- [webUITrashbinRestore/trashbinRestore.feature:260](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinRestore/trashbinRestore.feature#L260) +- [webUITrashbinRestore/trashbinRestore.feature:244](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinRestore/trashbinRestore.feature#L244) ### [Blocked user is not logged out](https://github.com/owncloud/ocis/issues/902) - [webUILogin/adminBlocksUser.feature:13](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUILogin/adminBlocksUser.feature#L13) @@ -129,18 +129,14 @@ Other free text and Markdown formatting can be used elsewhere in the document if - [webUIFilesDetails/fileDetails.feature:106](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L106) - [webUIFilesDetails/fileDetails.feature:123](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L123) - [webUIFilesDetails/fileDetails.feature:140](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L140) -- [webUIFilesDetails/fileDetails.feature:169](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L169) ### [Deletion of a recursive folder from trashbin is not possible](https://github.com/owncloud/product/issues/188) -- [webUITrashbinDelete/trashbinDelete.feature:85](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L85) -- [webUITrashbinDelete/trashbinDelete.feature:71](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L71) -- [webUITrashbinDelete/trashbinDelete.feature:48](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L48) +- [webUITrashbinDelete/trashbinDelete.feature:51](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L51) +- [webUITrashbinDelete/trashbinDelete.feature:65](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L65) ### [Tags page not implemented yet](https://github.com/owncloud/web/issues/5017) -- [webUIDeleteFilesFolders/deleteFilesFolders.feature:135](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIDeleteFilesFolders/deleteFilesFolders.feature#L135) -- [webUIFilesSearch/search.feature:63](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesSearch/search.feature#L63) -- [webUIFilesSearch/search.feature:71](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesSearch/search.feature#L71) -- [webUIFilesSearch/search.feature:84](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesSearch/search.feature#L84) +- [webUIFilesSearch/search.feature:41](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesSearch/search.feature#L41) +- [webUIFilesSearch/search.feature:85](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesSearch/search.feature#L85) - [webUITags/tagsSuggestion.feature:25](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITags/tagsSuggestion.feature#L25) - [webUITags/tagsSuggestion.feature:35](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITags/tagsSuggestion.feature#L35) - [webUITags/createTags.feature:16](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITags/createTags.feature#L16) @@ -150,20 +146,9 @@ Other free text and Markdown formatting can be used elsewhere in the document if - [webUITags/createTags.feature:61](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITags/createTags.feature#L61) - [webUITags/createTags.feature:79](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITags/createTags.feature#L79) -### [impossible to navigate into a folder in the trashbin](https://github.com/owncloud/web/issues/1725) -- [webUITrashbinDelete/trashbinDelete.feature:29](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L29) - ### [Saving public share is not possible](https://github.com/owncloud/web/issues/5321) - [webUISharingPublicManagement/shareByPublicLink.feature:31](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/shareByPublicLink.feature#L31) -### [Public link send by email field](https://github.com/owncloud/web/issues/2422) -- [webUISharingPublicManagement/publicLinkShareByEmail.feature:15](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/publicLinkShareByEmail.feature#L15) -- [webUISharingPublicManagement/publicLinkShareByEmail.feature:25](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/publicLinkShareByEmail.feature#L25) -- [webUISharingPublicManagement/publicLinkShareByEmail.feature:41](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/publicLinkShareByEmail.feature#L41) -- [webUISharingPublicManagement/publicLinkShareByEmail.feature:56](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/publicLinkShareByEmail.feature#L56) -- [webUISharingPublicManagement/publicLinkShareByEmail.feature:71](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/publicLinkShareByEmail.feature#L71) -- [webUISharingPublicManagement/publicLinkShareByEmail.feature:99](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/publicLinkShareByEmail.feature#L99) - ### [Uploading folders does not work in files-drop](https://github.com/owncloud/web/issues/2443) - [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:247](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L247) @@ -202,52 +187,22 @@ Other free text and Markdown formatting can be used elsewhere in the document if - [webUIWebdavLocks/unlock.feature:148](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLocks/unlock.feature#L148) - [webUIWebdavLocks/unlock.feature:198](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLocks/unlock.feature#L198) - [webUIWebdavLocks/unlock.feature:199](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLocks/unlock.feature#L199) -- [webUIWebdavLockProtection/delete.feature:32](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/delete.feature#L32) - [webUIWebdavLockProtection/delete.feature:33](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/delete.feature#L33) -- [webUIWebdavLockProtection/delete.feature:53](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/delete.feature#L53) -- [webUIWebdavLockProtection/delete.feature:54](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/delete.feature#L54) -- [webUIWebdavLockProtection/move.feature:35](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/move.feature#L35) +- [webUIWebdavLockProtection/delete.feature:34](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/delete.feature#L34) - [webUIWebdavLockProtection/move.feature:36](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/move.feature#L36) -- [webUIWebdavLockProtection/move.feature:56](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/move.feature#L56) -- [webUIWebdavLockProtection/move.feature:57](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/move.feature#L57) -- [webUIWebdavLockProtection/move.feature:79](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/move.feature#L79) -- [webUIWebdavLockProtection/move.feature:80](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/move.feature#L80) -- [webUIWebdavLockProtection/move.feature:100](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/move.feature#L100) -- [webUIWebdavLockProtection/move.feature:101](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/move.feature#L101) -- [webUIWebdavLockProtection/upload.feature:31](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/upload.feature#L31) +- [webUIWebdavLockProtection/move.feature:37](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/move.feature#L37) - [webUIWebdavLockProtection/upload.feature:32](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/upload.feature#L32) -- [webUIWebdavLockProtection/upload.feature:51](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/upload.feature#L51) -- [webUIWebdavLockProtection/upload.feature:52](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/upload.feature#L52) -- [webUIWebdavLockProtection/upload.feature:71](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/upload.feature#L71) -- [webUIWebdavLockProtection/upload.feature:72](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/upload.feature#L72) - -### [Resources cannot be locked under ocis](https://github.com/owncloud/ocis/issues/1284) -- [webUIWebdavLockProtection/delete.feature:73](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/delete.feature#L73) -- [webUIWebdavLockProtection/delete.feature:74](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/delete.feature#L74) -- [webUIWebdavLockProtection/move.feature:123](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/move.feature#L123) -- [webUIWebdavLockProtection/move.feature:124](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/move.feature#L124) - -### [Writing to locked files/folders give only a generic error message](https://github.com/owncloud/web/issues/5741) -- [webUIWebdavLockProtection/upload.feature:90](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/upload.feature#L90) -- [webUIWebdavLockProtection/upload.feature:91](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/upload.feature#L91) +- [webUIWebdavLockProtection/upload.feature:33](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/upload.feature#L33) ### [Federated shares not showing in shared with me page](https://github.com/owncloud/web/issues/2510) - [webUISharingExternal/federationSharing.feature:38](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingExternal/federationSharing.feature#L38) - [webUISharingExternal/federationSharing.feature:166](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingExternal/federationSharing.feature#L166) ### [Upload of folder with same name shows error](https://github.com/owncloud/web/issues/6996) -- [webUIUpload/upload.feature:129](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/upload.feature#L129) -- [webUIUpload/upload.feature:142](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/upload.feature#L142) -- [webUIUpload/upload.feature:159](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/upload.feature#L159) -- [webUIUpload/uploadEdgecases.feature:69](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/uploadEdgecases.feature#L69) - -### [browsing directly to a details tab is not possible](https://github.com/owncloud/web/issues/5464) -- [webUIFiles/browseDirectlyToDetailsTab.feature:21](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFiles/browseDirectlyToDetailsTab.feature#L21) -- [webUIFiles/browseDirectlyToDetailsTab.feature:22](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFiles/browseDirectlyToDetailsTab.feature#L22) -- [webUIFiles/browseDirectlyToDetailsTab.feature:31](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFiles/browseDirectlyToDetailsTab.feature#L31) -- [webUIFiles/browseDirectlyToDetailsTab.feature:32](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFiles/browseDirectlyToDetailsTab.feature#L32) -- [webUIFiles/browseDirectlyToDetailsTab.feature:41](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFiles/browseDirectlyToDetailsTab.feature#L41) -- [webUIFiles/browseDirectlyToDetailsTab.feature:42](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFiles/browseDirectlyToDetailsTab.feature#L42) +- [webUIUpload/upload.feature:120](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/upload.feature#L120) +- [webUIUpload/upload.feature:130](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/upload.feature#L130) +- [webUIUpload/upload.feature:138](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/upload.feature#L138) +- [webUIUpload/uploadEdgecases.feature:53](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/uploadEdgecases.feature#L53) ### [reshared share that is shared with a group the sharer is part of shows twice on "Share with me" page](https://github.com/owncloud/web/issues/2512) - [webUISharingAcceptShares/acceptShares.feature:32](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L32) @@ -259,7 +214,7 @@ Other free text and Markdown formatting can be used elsewhere in the document if ### [not possible to overwrite a received shared file](https://github.com/owncloud/ocis/issues/2267) - [webUISharingInternalGroups/shareWithGroups.feature:79](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature#L79) -- [webUISharingInternalUsers/shareWithUsers.feature:59](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalUsers/shareWithUsers.feature#L59) +- [webUISharingInternalUsers/shareWithUsers.feature:55](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalUsers/shareWithUsers.feature#L55) ### [web config update is not properly reflected after the ocis start](https://github.com/owncloud/ocis/issues/2944) - [webUIFiles/breadcrumb.feature:50](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFiles/breadcrumb.feature#L50) @@ -278,4 +233,3 @@ Other free text and Markdown formatting can be used elsewhere in the document if ### [PROPFIND to sub-folder of a shared resources with same name gives 404](https://github.com/owncloud/ocis/issues/3859) - [webUISharingAcceptShares/acceptShares.feature:245](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L245) - From 5be83e204fd05acf0be65de7d09a7eb96f72fa27 Mon Sep 17 00:00:00 2001 From: Jannik Stehle Date: Tue, 11 Oct 2022 15:16:15 +0200 Subject: [PATCH 3/7] Fix xpath selector for files space table --- .../ui/tests/acceptance/pageobjects/filesPageSettingsContext.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/settings/ui/tests/acceptance/pageobjects/filesPageSettingsContext.js b/services/settings/ui/tests/acceptance/pageobjects/filesPageSettingsContext.js index a2e8beb8bc..b2ca955c39 100644 --- a/services/settings/ui/tests/acceptance/pageobjects/filesPageSettingsContext.js +++ b/services/settings/ui/tests/acceptance/pageobjects/filesPageSettingsContext.js @@ -75,7 +75,7 @@ module.exports = { selector: '#account-info-container' }, fileTableHeaderItems: { - selector: '//*[@id="files-personal-table"]//th[not(.//div)]', + selector: '//*[@id="files-space-table"]//th[not(.//div)]', locateStrategy: 'xpath' } } From 8a5d3bfe737208bfc2a9506bef864f863d983425 Mon Sep 17 00:00:00 2001 From: Jannik Stehle Date: Tue, 11 Oct 2022 15:21:50 +0200 Subject: [PATCH 4/7] Adjust more expected acceptance test failures --- .../expected-failures-webUI-on-OCIS-storage-ocisSmokeTest.md | 1 - tests/acceptance/expected-failures-webUI-on-OCIS-storage.md | 1 - 2 files changed, 2 deletions(-) diff --git a/tests/acceptance/expected-failures-webUI-on-OCIS-storage-ocisSmokeTest.md b/tests/acceptance/expected-failures-webUI-on-OCIS-storage-ocisSmokeTest.md index f17b986242..8c8f7c3be9 100644 --- a/tests/acceptance/expected-failures-webUI-on-OCIS-storage-ocisSmokeTest.md +++ b/tests/acceptance/expected-failures-webUI-on-OCIS-storage-ocisSmokeTest.md @@ -13,4 +13,3 @@ Only the web scenarios tagged ocisSmokeTest are run by default in OCIS CI. This ### [Copy private link option not available](https://github.com/owncloud/ocis/issues/1409) - [webUIPrivateLinks/accessingPrivateLinks.feature:9](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIPrivateLinks/accessingPrivateLinks.feature#L9) -- [webUIPrivateLinks/accessingPrivateLinks.feature:17](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIPrivateLinks/accessingPrivateLinks.feature#L17) diff --git a/tests/acceptance/expected-failures-webUI-on-OCIS-storage.md b/tests/acceptance/expected-failures-webUI-on-OCIS-storage.md index 89c5c5d977..a6d995362e 100644 --- a/tests/acceptance/expected-failures-webUI-on-OCIS-storage.md +++ b/tests/acceptance/expected-failures-webUI-on-OCIS-storage.md @@ -70,7 +70,6 @@ Other free text and Markdown formatting can be used elsewhere in the document if ### [webUI-Private-Links](https://github.com/owncloud/web/issues/6844) - [webUIPrivateLinks/accessingPrivateLinks.feature:9](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIPrivateLinks/accessingPrivateLinks.feature#L9) -- [webUIPrivateLinks/accessingPrivateLinks.feature:17](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIPrivateLinks/accessingPrivateLinks.feature#L17) - [webUIPrivateLinks/accessingPrivateLinks.feature:25](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIPrivateLinks/accessingPrivateLinks.feature#L25) ### [Share additional info](https://github.com/owncloud/ocis/issues/1253) From ead886e353b260a8288eb7d86aece3f61fcc575f Mon Sep 17 00:00:00 2001 From: Michael Barz Date: Tue, 11 Oct 2022 19:13:56 +0200 Subject: [PATCH 5/7] more expected failures fixes and line number changes --- .../expected-failures-webUI-on-OCIS-storage.md | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/tests/acceptance/expected-failures-webUI-on-OCIS-storage.md b/tests/acceptance/expected-failures-webUI-on-OCIS-storage.md index a6d995362e..a85398e67b 100644 --- a/tests/acceptance/expected-failures-webUI-on-OCIS-storage.md +++ b/tests/acceptance/expected-failures-webUI-on-OCIS-storage.md @@ -134,8 +134,6 @@ Other free text and Markdown formatting can be used elsewhere in the document if - [webUITrashbinDelete/trashbinDelete.feature:65](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L65) ### [Tags page not implemented yet](https://github.com/owncloud/web/issues/5017) -- [webUIFilesSearch/search.feature:41](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesSearch/search.feature#L41) -- [webUIFilesSearch/search.feature:85](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesSearch/search.feature#L85) - [webUITags/tagsSuggestion.feature:25](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITags/tagsSuggestion.feature#L25) - [webUITags/tagsSuggestion.feature:35](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITags/tagsSuggestion.feature#L35) - [webUITags/createTags.feature:16](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITags/createTags.feature#L16) @@ -197,19 +195,13 @@ Other free text and Markdown formatting can be used elsewhere in the document if - [webUISharingExternal/federationSharing.feature:38](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingExternal/federationSharing.feature#L38) - [webUISharingExternal/federationSharing.feature:166](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingExternal/federationSharing.feature#L166) -### [Upload of folder with same name shows error](https://github.com/owncloud/web/issues/6996) -- [webUIUpload/upload.feature:120](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/upload.feature#L120) -- [webUIUpload/upload.feature:130](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/upload.feature#L130) -- [webUIUpload/upload.feature:138](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/upload.feature#L138) -- [webUIUpload/uploadEdgecases.feature:53](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/uploadEdgecases.feature#L53) - ### [reshared share that is shared with a group the sharer is part of shows twice on "Share with me" page](https://github.com/owncloud/web/issues/2512) -- [webUISharingAcceptShares/acceptShares.feature:32](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L32) +- [webUISharingAcceptShares/acceptShares.feature:31](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L31) ### [[oCIS] Received share cannot be deleted/unshared if not shared with full permissions](https://github.com/owncloud/web/issues/5531) -- [webUISharingAcceptShares/acceptShares.feature:50](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L50) -- [webUISharingAcceptShares/acceptShares.feature:162](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L162) -- [webUISharingAcceptShares/acceptShares.feature:201](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L201) +- [webUISharingAcceptShares/acceptShares.feature:49](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L49) +- [webUISharingAcceptShares/acceptShares.feature:161](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L161) +- [webUISharingAcceptShares/acceptShares.feature:200](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L200) ### [not possible to overwrite a received shared file](https://github.com/owncloud/ocis/issues/2267) - [webUISharingInternalGroups/shareWithGroups.feature:79](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature#L79) @@ -231,4 +223,4 @@ Other free text and Markdown formatting can be used elsewhere in the document if - [webUIFilesCopy/copy.feature:101](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesCopy/copy.feature#L101) ### [PROPFIND to sub-folder of a shared resources with same name gives 404](https://github.com/owncloud/ocis/issues/3859) -- [webUISharingAcceptShares/acceptShares.feature:245](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L245) +- [webUISharingAcceptShares/acceptShares.feature:244](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L244) From de0b8f8ee322edc83826637a3e35d024bb03e322 Mon Sep 17 00:00:00 2001 From: Benedikt Kulmann Date: Tue, 11 Oct 2022 20:55:17 +0200 Subject: [PATCH 6/7] Revert "Set the alias link capability to false" This reverts commit 492ac5ced4d79567a876ad5b6cad5d0861376566. --- services/frontend/pkg/revaconfig/config.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/frontend/pkg/revaconfig/config.go b/services/frontend/pkg/revaconfig/config.go index 1439d32029..9d4a1f87f4 100644 --- a/services/frontend/pkg/revaconfig/config.go +++ b/services/frontend/pkg/revaconfig/config.go @@ -198,7 +198,7 @@ func FrontendConfigFromStruct(cfg *config.Config) (map[string]interface{}, error "default_permissions": 22, "search_min_length": cfg.SearchMinLength, "public": map[string]interface{}{ - "alias": false, + "alias": true, "enabled": true, "send_mail": true, "defaultPublicLinkShareName": "Public link", From 8d26bf0329d58cf95f4a85e0e31ca7ae04e68834 Mon Sep 17 00:00:00 2001 From: Benedikt Kulmann Date: Tue, 11 Oct 2022 20:57:26 +0200 Subject: [PATCH 7/7] fix changelog issue refs and add breaking change warning --- changelog/unreleased/update-web-6.0.0-rc.1.md | 69 ++++++++++--------- 1 file changed, 37 insertions(+), 32 deletions(-) diff --git a/changelog/unreleased/update-web-6.0.0-rc.1.md b/changelog/unreleased/update-web-6.0.0-rc.1.md index d40027477b..4ea4f599de 100644 --- a/changelog/unreleased/update-web-6.0.0-rc.1.md +++ b/changelog/unreleased/update-web-6.0.0-rc.1.md @@ -4,38 +4,43 @@ Tags: web We updated ownCloud Web to v6.0.0-rc.1. Please refer to the changelog (linked) for details on the web release. -* Bugfix [#7419](https://github.com/owncloud/web/issues/7419): Add language param opening external app -* Bugfix [#7731](https://github.com/owncloud/web/pull/7731): "Copy Quicklink"-translations -* Bugfix [#7652](https://github.com/owncloud/web/pull/7652): Disable copy/move overwrite on self -* Bugfix [#7739](https://github.com/owncloud/web/pull/7739): Disable shares loading on public and trash locations -* Bugfix [#7740](https://github.com/owncloud/web/pull/7740): Disappearing quicklink in sidebar -* Bugfix [#7734](https://github.com/owncloud/web/pull/7734): File name reactivity -* Bugfix [#7724](https://github.com/owncloud/web/pull/7724): Folder conflict dialog -* Bugfix [#7652](https://github.com/owncloud/web/pull/7652): Inhibit move files between spaces -* Bugfix [#7640](https://github.com/owncloud/web/pull/7640): "Private link"-button alignment -* Bugfix [#7748](https://github.com/owncloud/web/pull/7748): Reload file list after last share removal -* Bugfix [#7699](https://github.com/owncloud/web/issues/7699): Remove the "close sidebar"-calls on delete -* Bugfix [#7504](https://github.com/owncloud/web/pull/7504): Resolve upload existing folder -* Bugfix [#7675](https://github.com/owncloud/web/pull/7675): Search bar on small screens -* Bugfix [#7662](https://github.com/owncloud/web/pull/7662): Sidebar for received shares in search file list -* Bugfix [#7506](https://github.com/owncloud/web/issues/7506): Shares loading -* Bugfix [#7632](https://github.com/owncloud/web/pull/7632): Sidebar toggle icon -* Bugfix [#7756](https://github.com/owncloud/web/pull/7756): Try to obtain refresh token before the error case -* Bugfix [#7651](https://github.com/owncloud/web/pull/7651): Spaces on "Shared via link"-page -* Bugfix [#7521](https://github.com/owncloud/web/issues/7521): Spaces reactivity on update -* Bugfix [#7630](https://github.com/owncloud/web/pull/7630): Upload modify time -* Change [#6648](https://github.com/owncloud/web/issues/6648): Drive aliases in URLs -* Enhancement [#7709](https://github.com/owncloud/web/pull/7709): Edit custom permissions wording -* Enhancement [#7190](https://github.com/owncloud/web/pull/7190): Deny subfolders inside share -* Enhancement [#7684](https://github.com/owncloud/web/pull/7684): Design polishing -* Enhancement [#7725](https://github.com/owncloud/web/pull/7725): Enable renaming on received shares -* Enhancement [#7747](https://github.com/owncloud/web/pull/7747): Friendlier logout screen -* Enhancement [#6247](https://github.com/owncloud/web/issues/6247): Id based routing -* Enhancement [#7405](https://github.com/owncloud/web/pull/7405): Resolve internal links -* Enhancement [#7569](https://github.com/owncloud/web/pull/7569): Make keybindings global -* Enhancement [#7405](https://github.com/owncloud/web/pull/7405): Resolve private links -* Enhancement [#7684](https://github.com/owncloud/web/pull/7684): Update ODS to v14.0.0-alpha.20 -* Enhancement [#7430](https://github.com/owncloud/web/pull/7430): Webdav support in web-client package +### Breaking changes +* BREAKING CHANGE for users in [owncloud/web#6648](https://github.com/owncloud/web/issues/6648): breaks existing bookmarks - they won't resolve anymore. +* BREAKING CHANGE for developers in [owncloud/web#6648](https://github.com/owncloud/web/issues/6648): the appDefaults composables from web-pkg now work with drive aliases, concatenated with relative item paths, instead of webdav paths. If you use the appDefaults composables in your application it's likely that your code needs to be adapted. + +### Changes +* Bugfix [owncloud/web#7419](https://github.com/owncloud/web/issues/7419): Add language param opening external app +* Bugfix [owncloud/web#7731](https://github.com/owncloud/web/pull/7731): "Copy Quicklink"-translations +* Bugfix [owncloud/web#7652](https://github.com/owncloud/web/pull/7652): Disable copy/move overwrite on self +* Bugfix [owncloud/web#7739](https://github.com/owncloud/web/pull/7739): Disable shares loading on public and trash locations +* Bugfix [owncloud/web#7740](https://github.com/owncloud/web/pull/7740): Disappearing quicklink in sidebar +* Bugfix [owncloud/web#7734](https://github.com/owncloud/web/pull/7734): File name reactivity +* Bugfix [owncloud/web#7724](https://github.com/owncloud/web/pull/7724): Folder conflict dialog +* Bugfix [owncloud/web#7652](https://github.com/owncloud/web/pull/7652): Inhibit move files between spaces +* Bugfix [owncloud/web#7640](https://github.com/owncloud/web/pull/7640): "Private link"-button alignment +* Bugfix [owncloud/web#7748](https://github.com/owncloud/web/pull/7748): Reload file list after last share removal +* Bugfix [owncloud/web#7699](https://github.com/owncloud/web/issues/7699): Remove the "close sidebar"-calls on delete +* Bugfix [owncloud/web#7504](https://github.com/owncloud/web/pull/7504): Resolve upload existing folder +* Bugfix [owncloud/web#7675](https://github.com/owncloud/web/pull/7675): Search bar on small screens +* Bugfix [owncloud/web#7662](https://github.com/owncloud/web/pull/7662): Sidebar for received shares in search file list +* Bugfix [owncloud/web#7506](https://github.com/owncloud/web/issues/7506): Shares loading +* Bugfix [owncloud/web#7632](https://github.com/owncloud/web/pull/7632): Sidebar toggle icon +* Bugfix [owncloud/web#7756](https://github.com/owncloud/web/pull/7756): Try to obtain refresh token before the error case +* Bugfix [owncloud/web#7651](https://github.com/owncloud/web/pull/7651): Spaces on "Shared via link"-page +* Bugfix [owncloud/web#7521](https://github.com/owncloud/web/issues/7521): Spaces reactivity on update +* Bugfix [owncloud/web#7630](https://github.com/owncloud/web/pull/7630): Upload modify time +* Change [owncloud/web#6648](https://github.com/owncloud/web/issues/6648): Drive aliases in URLs +* Enhancement [owncloud/web#7709](https://github.com/owncloud/web/pull/7709): Edit custom permissions wording +* Enhancement [owncloud/web#7190](https://github.com/owncloud/web/pull/7190): Deny subfolders inside share +* Enhancement [owncloud/web#7684](https://github.com/owncloud/web/pull/7684): Design polishing +* Enhancement [owncloud/web#7725](https://github.com/owncloud/web/pull/7725): Enable renaming on received shares +* Enhancement [owncloud/web#7747](https://github.com/owncloud/web/pull/7747): Friendlier logout screen +* Enhancement [owncloud/web#6247](https://github.com/owncloud/web/issues/6247): Id based routing +* Enhancement [owncloud/web#7405](https://github.com/owncloud/web/pull/7405): Resolve internal links +* Enhancement [owncloud/web#7569](https://github.com/owncloud/web/pull/7569): Make keybindings global +* Enhancement [owncloud/web#7405](https://github.com/owncloud/web/pull/7405): Resolve private links +* Enhancement [owncloud/web#7684](https://github.com/owncloud/web/pull/7684): Update ODS to v14.0.0-alpha.20 +* Enhancement [owncloud/web#7430](https://github.com/owncloud/web/pull/7430): Webdav support in web-client package https://github.com/owncloud/ocis/pull/4779 https://github.com/owncloud/web/releases/tag/v6.0.0-rc.1