From 6ec48c4516c1de76fe613a4e133d403d0033778a Mon Sep 17 00:00:00 2001 From: Jannik Stehle Date: Thu, 12 Sep 2024 11:30:37 +0200 Subject: [PATCH] fix: eslint react errors when building idp service Ignores the eslint react errors for `react/no-is-mounted` to make CI green again. This is only a temporary solution, updating the pnpm version in our node docker images should make this obsolete. --- services/idp/src/components/Loading.jsx | 2 ++ services/idp/src/containers/Goodbye/Goodbyescreen.jsx | 2 ++ services/idp/src/containers/Login/Chooseaccount.jsx | 2 ++ services/idp/src/containers/Login/Consent.jsx | 2 ++ services/idp/src/containers/Welcome/Welcomescreen.jsx | 2 ++ 5 files changed, 10 insertions(+) diff --git a/services/idp/src/components/Loading.jsx b/services/idp/src/components/Loading.jsx index 42f024115..7d492ab91 100644 --- a/services/idp/src/components/Loading.jsx +++ b/services/idp/src/components/Loading.jsx @@ -1,3 +1,5 @@ +// FIXME: remove eslint-disable when pnpm in CI has been updated +/* eslint-disable react/no-is-mounted */ import React from 'react'; import PropTypes from 'prop-types'; import { connect } from 'react-redux'; diff --git a/services/idp/src/containers/Goodbye/Goodbyescreen.jsx b/services/idp/src/containers/Goodbye/Goodbyescreen.jsx index 511fedb3e..085c81be3 100644 --- a/services/idp/src/containers/Goodbye/Goodbyescreen.jsx +++ b/services/idp/src/containers/Goodbye/Goodbyescreen.jsx @@ -1,3 +1,5 @@ +// FIXME: remove eslint-disable when pnpm in CI has been updated +/* eslint-disable react/no-is-mounted */ import React from 'react'; import PropTypes from 'prop-types'; import { connect } from 'react-redux'; diff --git a/services/idp/src/containers/Login/Chooseaccount.jsx b/services/idp/src/containers/Login/Chooseaccount.jsx index 8c4440540..b01f4c247 100644 --- a/services/idp/src/containers/Login/Chooseaccount.jsx +++ b/services/idp/src/containers/Login/Chooseaccount.jsx @@ -1,3 +1,5 @@ +// FIXME: remove eslint-disable when pnpm in CI has been updated +/* eslint-disable react/no-is-mounted */ import React from 'react'; import PropTypes from 'prop-types'; import { connect } from 'react-redux'; diff --git a/services/idp/src/containers/Login/Consent.jsx b/services/idp/src/containers/Login/Consent.jsx index 9e64b56af..cdd33c7f9 100644 --- a/services/idp/src/containers/Login/Consent.jsx +++ b/services/idp/src/containers/Login/Consent.jsx @@ -1,3 +1,5 @@ +// FIXME: remove eslint-disable when pnpm in CI has been updated +/* eslint-disable react/no-is-mounted */ import React from 'react'; import PropTypes from 'prop-types'; import { connect } from 'react-redux'; diff --git a/services/idp/src/containers/Welcome/Welcomescreen.jsx b/services/idp/src/containers/Welcome/Welcomescreen.jsx index 62b853e3c..d204845fc 100644 --- a/services/idp/src/containers/Welcome/Welcomescreen.jsx +++ b/services/idp/src/containers/Welcome/Welcomescreen.jsx @@ -1,3 +1,5 @@ +// FIXME: remove eslint-disable when pnpm in CI has been updated +/* eslint-disable react/no-is-mounted */ import React from 'react'; import PropTypes from 'prop-types'; import { connect } from 'react-redux';