inherit logging config from ocis.yaml, let extensions overwrite their logging. Considering using a package level global logging...

graph-explorer/pkg/command/root.go

@@ -6,7 +6,6 @@ import (
 	"strings"
 
 	"github.com/owncloud/ocis/graph-explorer/pkg/config"
-	"github.com/owncloud/ocis/graph-explorer/pkg/flagset"
 	ociscfg "github.com/owncloud/ocis/ocis-pkg/config"
 	"github.com/owncloud/ocis/ocis-pkg/log"
 	"github.com/owncloud/ocis/ocis-pkg/sync"
@@ -31,7 +30,7 @@ func Execute(cfg *config.Config) error {
 			},
 		},
 
-		Flags: flagset.RootWithConfig(cfg),
+		//Flags: flagset.RootWithConfig(cfg),
 
 		Before: func(c *cli.Context) error {
 			cfg.Server.Version = version.String
@@ -91,8 +90,8 @@ func ParseConfig(c *cli.Context, cfg *config.Config) error {
 	if err := viper.ReadInConfig(); err != nil {
 		switch err.(type) {
 		case viper.ConfigFileNotFoundError:
-			logger.Info().
-				Msg("Continue without config")
+			//logger.Info().
+			//	Msg("Continue without config")
 		case viper.UnsupportedConfigError:
 			logger.Fatal().
 				Err(err).
@@ -120,6 +119,7 @@ type SutureService struct {
 
 // NewSutureService creates a new graph-explorer.SutureService
 func NewSutureService(cfg *ociscfg.Config) suture.Service {
+	inheritLogging(cfg)
 	if cfg.Mode == 0 {
 		cfg.GraphExplorer.Supervised = true
 	}
@@ -137,3 +137,13 @@ func (s SutureService) Serve(ctx context.Context) error {
 
 	return nil
 }
+
+// inheritLogging is a poor man's global logging state tip-toeing around circular dependencies. It sets the logging
+// of the service to whatever is in the higher config (in this case coming from ocis.yaml) and sets them as defaults,
+// being overwritten when the extension parses its config file / env variables.
+func inheritLogging(cfg *ociscfg.Config) {
+	cfg.GraphExplorer.Log.File = cfg.Log.File
+	cfg.GraphExplorer.Log.Color = cfg.Log.Color
+	cfg.GraphExplorer.Log.Pretty = cfg.Log.Pretty
+	cfg.GraphExplorer.Log.Level = cfg.Log.Level
+}