From 7345c7d32c5f3e88958431c219c109a38e3deb50 Mon Sep 17 00:00:00 2001 From: Jan Date: Thu, 14 Dec 2023 10:44:13 +0100 Subject: [PATCH] Remove accessDeniedHelperUrl from config (#7970) * Remove accessDeniedHelperUrl from config * Enhance changelog item * Adjust former changelog item * Force rename --- ...hange-remove-privacy-url-and-imprint-url-from-config.md} | 4 ++-- .../change-remove-access-denied-help-url-from-config.md | 6 ++++++ services/web/pkg/config/options.go | 1 - 3 files changed, 8 insertions(+), 3 deletions(-) rename changelog/5.0.0-beta.1_2023-12-12/{change-remove-privacy-url-and-imprint-url-from-config => change-remove-privacy-url-and-imprint-url-from-config.md} (63%) create mode 100644 changelog/unreleased/change-remove-access-denied-help-url-from-config.md diff --git a/changelog/5.0.0-beta.1_2023-12-12/change-remove-privacy-url-and-imprint-url-from-config b/changelog/5.0.0-beta.1_2023-12-12/change-remove-privacy-url-and-imprint-url-from-config.md similarity index 63% rename from changelog/5.0.0-beta.1_2023-12-12/change-remove-privacy-url-and-imprint-url-from-config rename to changelog/5.0.0-beta.1_2023-12-12/change-remove-privacy-url-and-imprint-url-from-config.md index 884db8c58b..671a3a4c1f 100644 --- a/changelog/5.0.0-beta.1_2023-12-12/change-remove-privacy-url-and-imprint-url-from-config +++ b/changelog/5.0.0-beta.1_2023-12-12/change-remove-privacy-url-and-imprint-url-from-config.md @@ -1,6 +1,6 @@ -Change: remove PrivacyURL and ImprintURL from the config +Change: remove privacyURL and imprintURL from the config -We've removed the option PrivacyURL and ImprintURL from the config, since other clients weren't able to consume these. +We've removed the option privacyURL and imprintURL from the config, since other clients weren't able to consume these. In order to be accessible by other clients, not just Web, those should be configured via the theme.json file. https://github.com/owncloud/ocis/pull/7938/ diff --git a/changelog/unreleased/change-remove-access-denied-help-url-from-config.md b/changelog/unreleased/change-remove-access-denied-help-url-from-config.md new file mode 100644 index 0000000000..c03e023d78 --- /dev/null +++ b/changelog/unreleased/change-remove-access-denied-help-url-from-config.md @@ -0,0 +1,6 @@ +Change: Remove accessDeniedHelpUrl from the config + +We've removed the option accessDeniedHelpUrl from the config, since other clients weren't able to consume it. +In order to be accessible by other clients, not just Web, it should be configured via the theme.json file. + +https://github.com/owncloud/ocis/pull/7970 diff --git a/services/web/pkg/config/options.go b/services/web/pkg/config/options.go index 18d3e56a04..ebd546f749 100644 --- a/services/web/pkg/config/options.go +++ b/services/web/pkg/config/options.go @@ -21,7 +21,6 @@ type Options struct { LogoutURL string `json:"logoutUrl,omitempty" yaml:"logoutUrl" env:"WEB_OPTION_LOGOUT_URL" desc:"Adds a link to the user's profile page to point him to an external page, where he can manage his session and devices. This is helpful when an external IdP is used. This option is disabled by default."` LoginURL string `json:"loginUrl,omitempty" yaml:"loginUrl" env:"WEB_OPTION_LOGIN_URL" desc:"Specifies the target URL to the login page. This is helpful when an external IdP is used. This option is disabled by default. Example URL like: https://www.myidp.com/login."` OpenLinksWithDefaultApp bool `json:"openLinksWithDefaultApp,omitempty" yaml:"openLinksWithDefaultApp" env:"WEB_OPTION_OPEN_LINKS_WITH_DEFAULT_APP" desc:"Specifies whether single file link shares should be opened with the default app or not. If not opened by the default app, the Web UI just displays the file details."` - AccessDeniedHelpURL string `json:"accessDeniedHelpUrl,omitempty" yaml:"accessDeniedHelpUrl" env:"WEB_OPTION_ACCESS_DENIED_HELP_URL" desc:"Specifies the target URL valid for the ocis instance for the generic logged out / access denied page."` TokenStorageLocal bool `json:"tokenStorageLocal" yaml:"tokenStorageLocal" env:"WEB_OPTION_TOKEN_STORAGE_LOCAL" desc:"Specifies whether the access token will be stored in the local storage when set to 'true' or in the session storage when set to 'false'. If stored in the local storage, login state will be persisted across multiple browser tabs, means no additional logins are required."` DisabledExtensions []string `json:"disabledExtensions,omitempty" yaml:"disabledExtensions" env:"WEB_OPTION_DISABLED_EXTENSIONS" desc:"A list to disable specific Web extensions identified by their ID. The ID can e.g. be taken from the 'index.ts' file of the web extension. Example: 'com.github.owncloud.web.files.search,com.github.owncloud.web.files.print'. See the Environment Variable Types description for more details."` Embed *Embed `json:"embed,omitempty" yaml:"embed"`