From 76c63ef696d32591c20f1b67c6b87de984b02b66 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rn=20Friedrich=20Dreyer?= Date: Wed, 4 Nov 2020 10:28:54 +0100 Subject: [PATCH] close request bodies MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Jörn Friedrich Dreyer --- konnectd/pkg/service/v0/service.go | 3 +++ ocs/pkg/service/v0/groups.go | 4 ++++ proxy/pkg/proxy/proxy_integration_test.go | 3 +++ 3 files changed, 10 insertions(+) diff --git a/konnectd/pkg/service/v0/service.go b/konnectd/pkg/service/v0/service.go index 4b1f0430f4..c1a3d7d9b7 100644 --- a/konnectd/pkg/service/v0/service.go +++ b/konnectd/pkg/service/v0/service.go @@ -196,6 +196,9 @@ func (k Konnectd) Index() http.HandlerFunc { if err != nil { k.logger.Fatal().Err(err).Msg("Could not read index template") } + if err = f.Close(); err != nil { + k.logger.Fatal().Err(err).Msg("Could not close body") + } // TODO add environment variable to make the path prefix configurable pp := "/signin/v1" diff --git a/ocs/pkg/service/v0/groups.go b/ocs/pkg/service/v0/groups.go index fc009c81a0..6b7913b459 100644 --- a/ocs/pkg/service/v0/groups.go +++ b/ocs/pkg/service/v0/groups.go @@ -137,6 +137,10 @@ func (o Ocs) RemoveFromGroup(w http.ResponseWriter, r *http.Request) { render.Render(w, r, response.ErrRender(data.MetaBadRequest.StatusCode, err.Error())) return } + if err = r.Body.Close(); err != nil { + render.Render(w, r, response.ErrRender(data.MetaServerError.StatusCode, err.Error())) + return + } values, err := url.ParseQuery(string(body)) if err != nil { diff --git a/proxy/pkg/proxy/proxy_integration_test.go b/proxy/pkg/proxy/proxy_integration_test.go index a23c55ef34..de0af13d9a 100644 --- a/proxy/pkg/proxy/proxy_integration_test.go +++ b/proxy/pkg/proxy/proxy_integration_test.go @@ -145,6 +145,9 @@ func TestProxyIntegration(t *testing.T) { if err != nil { t.Fatal("Error reading result body") } + if err = rr.Result().Body.Close(); err != nil { + t.Fatal("Error closing result body") + } bodyString := string(resultBody) if bodyString != `OK` {