From 9638dd524c1bd74bbce0948ef1a2949d3ffbad37 Mon Sep 17 00:00:00 2001 From: Florian Schade Date: Thu, 3 Aug 2023 13:13:38 +0200 Subject: [PATCH] fix: review feedback --- services/policies/pkg/engine/opa/engine.go | 3 ++- services/policies/pkg/engine/opa/rf_mimetype.go | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/services/policies/pkg/engine/opa/engine.go b/services/policies/pkg/engine/opa/engine.go index f152a6403..b4107ba18 100644 --- a/services/policies/pkg/engine/opa/engine.go +++ b/services/policies/pkg/engine/opa/engine.go @@ -24,7 +24,8 @@ type OPA struct { // NewOPA returns a ready to use opa engine. func NewOPA(timeout time.Duration, logger log.Logger, conf config.Engine) (OPA, error) { - var mtReader io.Reader = nil + var mtReader io.Reader + if conf.Mimes != "" { mtReader, err := os.Open(conf.Mimes) if err != nil { diff --git a/services/policies/pkg/engine/opa/rf_mimetype.go b/services/policies/pkg/engine/opa/rf_mimetype.go index 4fb5b02ad..f3b7b300f 100644 --- a/services/policies/pkg/engine/opa/rf_mimetype.go +++ b/services/policies/pkg/engine/opa/rf_mimetype.go @@ -38,7 +38,7 @@ func RFMimetypeExtensions(f io.Reader) (func(*rego.Rego), error) { } } if err := scanner.Err(); err != nil { - panic(err) + return nil, err } }