From 98b4a6a23aeff8ccf5ee671c26773549afa367a5 Mon Sep 17 00:00:00 2001 From: Ralf Haferkamp Date: Mon, 20 Mar 2023 12:36:55 +0100 Subject: [PATCH] Address some linter warnings Response bodies need to be closed --- services/proxy/pkg/user/backend/cs3.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/services/proxy/pkg/user/backend/cs3.go b/services/proxy/pkg/user/backend/cs3.go index 724d3aa26..59ef8dbaf 100644 --- a/services/proxy/pkg/user/backend/cs3.go +++ b/services/proxy/pkg/user/backend/cs3.go @@ -155,6 +155,8 @@ func (c *cs3backend) CreateUserFromClaims(ctx context.Context, claims map[string req := lgClient.UsersApi.CreateUser(newctx).User(newUser) created, resp, err := req.Execute() + defer resp.Body.Close() + var reread bool if err != nil { if resp == nil { @@ -178,7 +180,8 @@ func (c *cs3backend) CreateUserFromClaims(ctx context.Context, claims map[string if reread { c.logger.Debug().Msg("User already exist, re-reading via libregraph") gureq := lgClient.UserApi.GetUser(newctx, newUser.GetOnPremisesSamAccountName()) - created, _, err = gureq.Execute() + created, resp, err = gureq.Execute() + defer resp.Body.Close() if err != nil { c.logger.Error().Err(err).Msg("Error trying to re-read user from graphAPI") return nil, err