diff --git a/tests/acceptance/config/behat-core.yml b/tests/acceptance/config/behat-core.yml index b0071b5466..f4f6a1d076 100644 --- a/tests/acceptance/config/behat-core.yml +++ b/tests/acceptance/config/behat-core.yml @@ -50,6 +50,7 @@ default: - FeatureContext: *common_feature_context_params - FavoritesContext: - WebDavPropertiesContext: + - SharingNgContext: coreApiShareCreateSpecialToShares1: paths: diff --git a/tests/acceptance/expected-failures-API-on-OCIS-storage.md b/tests/acceptance/expected-failures-API-on-OCIS-storage.md index 3306a9fa4f..541a1451ea 100644 --- a/tests/acceptance/expected-failures-API-on-OCIS-storage.md +++ b/tests/acceptance/expected-failures-API-on-OCIS-storage.md @@ -238,8 +238,8 @@ And other missing implementation of favorites - [coreApiFavorites/favorites.feature:202](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiFavorites/favorites.feature#L202) - [coreApiFavorites/favorites.feature:203](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiFavorites/favorites.feature#L203) - [coreApiFavorites/favorites.feature:208](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiFavorites/favorites.feature#L208) -- [coreApiFavorites/favoritesSharingToShares.feature:64](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiFavorites/favoritesSharingToShares.feature#L64) -- [coreApiFavorites/favoritesSharingToShares.feature:65](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiFavorites/favoritesSharingToShares.feature#L65) +- [coreApiFavorites/favoritesSharingToShares.feature:84](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiFavorites/favoritesSharingToShares.feature#L84) +- [coreApiFavorites/favoritesSharingToShares.feature:85](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiFavorites/favoritesSharingToShares.feature#L85) #### [WWW-Authenticate header for unauthenticated requests is not clear](https://github.com/owncloud/ocis/issues/2285) diff --git a/tests/acceptance/features/coreApiFavorites/favoritesSharingToShares.feature b/tests/acceptance/features/coreApiFavorites/favoritesSharingToShares.feature index cc433c272e..d6ee3c2df2 100644 --- a/tests/acceptance/features/coreApiFavorites/favoritesSharingToShares.feature +++ b/tests/acceptance/features/coreApiFavorites/favoritesSharingToShares.feature @@ -13,7 +13,12 @@ Feature: favorite Scenario Outline: favorite a file inside of a received share Given using DAV path And user "Brian" has been created with default attributes and without skeleton files - And user "Alice" has shared folder "/PARENT" with user "Brian" + And user "Alice" has sent the following resource share invitation: + | resource | PARENT | + | space | Personal | + | sharee | Brian | + | shareType | user | + | permissionsRole | Editor | When user "Brian" favorites element "/Shares/PARENT/parent.txt" using the WebDAV API Then the HTTP status code should be "207" And as user "Brian" file "/Shares/PARENT/parent.txt" should be favorited @@ -27,7 +32,12 @@ Feature: favorite Given using DAV path And user "Brian" has been created with default attributes and without skeleton files And user "Alice" has created folder "/PARENT/sub-folder" - And user "Alice" has shared folder "/PARENT" with user "Brian" + And user "Alice" has sent the following resource share invitation: + | resource | PARENT | + | space | Personal | + | sharee | Brian | + | shareType | user | + | permissionsRole | Editor | When user "Brian" favorites element "/Shares/PARENT/sub-folder" using the WebDAV API Then the HTTP status code should be "207" And as user "Brian" folder "/Shares/PARENT/sub-folder" should be favorited @@ -40,7 +50,12 @@ Feature: favorite Scenario Outline: favorite a received share itself Given using DAV path And user "Brian" has been created with default attributes and without skeleton files - And user "Alice" has shared folder "/PARENT" with user "Brian" + And user "Alice" has sent the following resource share invitation: + | resource | PARENT | + | space | Personal | + | sharee | Brian | + | shareType | user | + | permissionsRole | Editor | When user "Brian" favorites element "/Shares/PARENT" using the WebDAV API Then the HTTP status code should be "207" And as user "Brian" folder "/Shares/PARENT" should be favorited @@ -53,7 +68,12 @@ Feature: favorite Scenario Outline: moving a favorite file out of a share keeps favorite state Given using DAV path And user "Brian" has been created with default attributes and without skeleton files - And user "Alice" has shared folder "/PARENT" with user "Brian" + And user "Alice" has sent the following resource share invitation: + | resource | PARENT | + | space | Personal | + | sharee | Brian | + | shareType | user | + | permissionsRole | Editor | And user "Brian" has favorited element "/Shares/PARENT/parent.txt" When user "Brian" moves file "/Shares/PARENT/parent.txt" to "/taken_out.txt" using the WebDAV API Then the HTTP status code should be "201" @@ -68,7 +88,12 @@ Feature: favorite Scenario Outline: sharee file favorite state should not change the favorite state of sharer Given using DAV path And user "Brian" has been created with default attributes and without skeleton files - And user "Alice" has shared file "/PARENT/parent.txt" with user "Brian" + And user "Alice" has sent the following resource share invitation: + | resource | PARENT/parent.txt | + | space | Personal | + | sharee | Brian | + | shareType | user | + | permissionsRole | File Editor | When user "Brian" favorites element "/Shares/parent.txt" using the WebDAV API Then the HTTP status code should be "207" And as user "Brian" file "/Shares/parent.txt" should be favorited