mirror/opencloud
1
0
Fork 0
mirror of https://github.com/opencloud-eu/opencloud.git synced 2026-02-04 11:08:50 -06:00
Code Issues Packages Projects Releases Wiki Activity

refactoring FeatureContext.php file (#7822)

Browse Source
This commit is contained in:
nirajacharya2
2023-11-29 09:45:29 +05:45
committed by GitHub
parent 68b613d58b
commit b71a50065d
1 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tests/acceptance/features/bootstrap/FeatureContext.php
View File

@@ -630,7 +630,7 @@ class FeatureContext extends BehatVariablesContext {
* @throws Exception
*/
public static function logStep(BeforeStepScope $scope): void {
$step = $scope->getStep()->getType() . " " . $scope->getStep()->getText();
$step = $scope->getStep()->getKeyword() . " " . $scope->getStep()->getText();
$logMessage = "\t### $step\n";
HttpLogger::writeLog(HttpLogger::getScenarioLogPath(), $logMessage);
}
@@ -1725,7 +1725,7 @@ class FeatureContext extends BehatVariablesContext {
];
}
$this->response = HttpRequestHelper::get(
$response = HttpRequestHelper::get(
$loginUrl,
$this->getStepLineRef(),
null,
@@ -1735,8 +1735,8 @@ class FeatureContext extends BehatVariablesContext {
$config,
$this->cookieJar
);
$this->theHTTPStatusCodeShouldBeSuccess();
$this->extractRequestTokenFromResponse($this->response);
$this->theHTTPStatusCodeShouldBeBetween(200, 299, $response);
$this->extractRequestTokenFromResponse($response);
// Login and extract new token
$password = $this->getPasswordForUser($user);
@@ -1745,7 +1745,7 @@ class FeatureContext extends BehatVariablesContext {
'password' => $password,
'requesttoken' => $this->requestToken
];
$this->response = HttpRequestHelper::post(
$response = HttpRequestHelper::post(
$loginUrl,
$this->getStepLineRef(),
null,
@@ -1755,8 +1755,8 @@ class FeatureContext extends BehatVariablesContext {
$config,
$this->cookieJar
);
$this->theHTTPStatusCodeShouldBeSuccess();
$this->extractRequestTokenFromResponse($this->response);
$this->theHTTPStatusCodeShouldBeBetween(200, 299, $response);
$this->extractRequestTokenFromResponse($response);
}
/**
@@ -2359,8 +2359,8 @@ class FeatureContext extends BehatVariablesContext {
*
* @return void
*/
public function readFileInServerRootForCore(string $path): void {
$response = OcsApiHelper::sendRequest(
public function readFileInServerRootForCore(string $path): ResponseInterface {
return OcsApiHelper::sendRequest(
$this->getBaseUrl(),
$this->getAdminUsername(),
$this->getAdminPassword(),
@@ -2368,7 +2368,6 @@ class FeatureContext extends BehatVariablesContext {
"/apps/testing/api/v1/file?file=$path",
$this->getStepLineRef()
);
$this->setResponse($response);
}
/**