mirror/opencloud
1
0
Fork 0
mirror of https://github.com/opencloud-eu/opencloud.git synced 2026-02-28 17:38:59 -06:00
Code Issues Packages Projects Releases Wiki Activity

[test-only] apiTest. banned password list (#7339)

Browse Source 
* apiTest. banned password list

* fix after review
This commit is contained in:
Viktor Scharf
2023-09-25 11:50:34 +02:00
committed by GitHub
parent 0dcc38a998
commit be9ac740c9
3 changed files with 73 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

62
tests/acceptance/features/apiGraph/enforcePasswordPublicLink.feature
View File

@@ -110,13 +110,13 @@ Feature: enforce password on public link
Then the HTTP status code should be "<http-code>"
And the OCS status code should be "400"
And the OCS status message should be:
"""
at least 13 characters are required
at least 3 lowercase letters are required
at least 2 uppercase letters are required
at least 2 numbers are required
at least 2 special characters are required !"#$%&'()*+,-./:;<=>?@[\]^_`{|}~
"""
"""
at least 13 characters are required
at least 3 lowercase letters are required
at least 2 uppercase letters are required
at least 2 numbers are required
at least 2 special characters are required !"#$%&'()*+,-./:;<=>?@[\]^_`{|}~
"""
Examples:
| ocs-api-version | http-code |
| 1 | 200 |
@@ -237,8 +237,54 @@ Feature: enforce password on public link
And the OCS status code should be "400"
And the OCS status message should be "<message>"
Examples:
| config | config-value | password | message |
| config | config-value | password | message |
| FRONTEND_PASSWORD_POLICY_MIN_CHARACTERS | 5 | 1234 | at least 5 characters are required |
| FRONTEND_PASSWORD_POLICY_MIN_LOWERCASE_CHARACTERS | 3 | TesT | at least 3 lowercase letters are required |
| FRONTEND_PASSWORD_POLICY_MIN_UPPERCASE_CHARACTERS | 3 | TesT | at least 3 uppercase letters are required |
| FRONTEND_PASSWORD_POLICY_MIN_DIGITS | 2 | test1 | at least 2 numbers are required |
Scenario Outline: update a public link with a password that is listed in the Banned-Password-List
Given the config "FRONTEND_PASSWORD_POLICY_BANNED_PASSWORDS_LIST" has been set to path "bannedPassword/banned-password-list.txt"
And using OCS API version "2"
And user "Alice" has been created with default attributes and without skeleton files
And user "Alice" has uploaded file with content "test file" to "/testfile.txt"
And user "Alice" has created a public link share with settings
| path | /testfile.txt |
| permissions | 1 |
When user "Alice" updates the last public link share using the sharing API with
| permissions | 3 |
| password | <password> |
Then the HTTP status code should be "<http-code>"
And the OCS status code should be "<ocs-code>"
And the OCS status message should be "<message>"
Examples:
| password | http-code | ocs-code | message |
| 123 | 400 | 400 | unfortunately, your password is commonly used. please pick a harder-to-guess password for your safety |
| password | 400 | 400 | unfortunately, your password is commonly used. please pick a harder-to-guess password for your safety |
| ownCloud | 400 | 400 | unfortunately, your password is commonly used. please pick a harder-to-guess password for your safety |
| 1234 | 200 | 200 | OK |
| OwnCloud | 200 | 200 | OK |
| p@ssword | 200 | 200 | OK |
Scenario Outline: create a public link with a password that is listed in the Banned-Password-List
Given the config "FRONTEND_PASSWORD_POLICY_BANNED_PASSWORDS_LIST" has been set to path "bannedPassword/banned-password-list.txt"
And using OCS API version "2"
And user "Alice" has been created with default attributes and without skeleton files
And user "Alice" has uploaded file with content "test file" to "/testfile.txt"
When user "Alice" creates a public link share using the sharing API with settings
| path | /testfile.txt |
| permissions | 3 |
| password | <password> |
Then the HTTP status code should be "<http-code>"
And the OCS status code should be "<ocs-code>"
And the OCS status message should be "<message>"
Examples:
| password | http-code | ocs-code | message |
| 123 | 400 | 400 | unfortunately, your password is commonly used. please pick a harder-to-guess password for your safety |
| password | 400 | 400 | unfortunately, your password is commonly used. please pick a harder-to-guess password for your safety |
| ownCloud | 400 | 400 | unfortunately, your password is commonly used. please pick a harder-to-guess password for your safety |
| 1234 | 200 | 200 | OK |
| OwnCloud | 200 | 200 | OK |
| p@ssword | 200 | 200 | OK |

16
tests/acceptance/features/bootstrap/OcisConfigContext.php
View File

@@ -25,6 +25,7 @@ use Behat\Gherkin\Node\TableNode;
use GuzzleHttp\Exception\GuzzleException;
use TestHelpers\OcisConfigHelper;
use PHPUnit\Framework\Assert;
use TestHelpers\UploadHelper;
/**
* steps needed to re-configure oCIS server
@@ -75,6 +76,21 @@ class OcisConfigContext implements Context {
);
}
/**
* @Given the config :configVariable has been set to path :path
*
* @param string $configVariable
* @param string $path
*
* @return void
* @throws GuzzleException
*/
public function theConfigHasBeenSetPathTo(string $configVariable, string $path): void {
$path = UploadHelper::getUploadFilesDir($path);
$this->theConfigHasBeenSetTo($configVariable, $path);
}
/**
* @Given the following configs have been set:
*

3
tests/acceptance/filesForUpload/bannedPassword/banned-password-list.txt Normal file
View File

@@ -0,0 +1,3 @@
password
123
ownCloud