From 8141a6d7239b684d15e9611c7d208c35cad29308 Mon Sep 17 00:00:00 2001 From: Phil Davis Date: Mon, 24 Apr 2023 10:50:40 +0545 Subject: [PATCH 1/2] Fix invalid public upload acceptance test step --- tests/acceptance/features/bootstrap/PublicWebDavContext.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/acceptance/features/bootstrap/PublicWebDavContext.php b/tests/acceptance/features/bootstrap/PublicWebDavContext.php index 4ca9a55a52..cf52e7018d 100644 --- a/tests/acceptance/features/bootstrap/PublicWebDavContext.php +++ b/tests/acceptance/features/bootstrap/PublicWebDavContext.php @@ -529,7 +529,7 @@ class PublicWebDavContext implements Context { } /** - * @Given the public has uploaded file :filename" with password :password and content :body + * @Given the public has uploaded file :filename with password :password and content :body * * @param string $filename target file name * @param string|null $password From 24699b5678bac95b60d145b6d6d02d65d3de3ba1 Mon Sep 17 00:00:00 2001 From: Phil Davis Date: Mon, 24 Apr 2023 10:58:05 +0545 Subject: [PATCH 2/2] Improve words in some test steps that check API responses --- tests/acceptance/features/apiGraph/getApplications.feature | 4 ++-- tests/acceptance/features/bootstrap/GraphContext.php | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/acceptance/features/apiGraph/getApplications.feature b/tests/acceptance/features/apiGraph/getApplications.feature index f79bb3d38c..d1390b6412 100644 --- a/tests/acceptance/features/apiGraph/getApplications.feature +++ b/tests/acceptance/features/apiGraph/getApplications.feature @@ -12,11 +12,11 @@ Feature: get applications Given the administrator has given "Alice" the role "" using the settings api When user "Alice" gets all applications using the Graph API Then the HTTP status code should be "200" - And the user retrieve API response should contain the following applications information: + And the user API response should contain the following application information: | key | value | | displayName | ownCloud Infinite Scale | | id | %uuid_v4% | - And the user retrieve API response should contain the following app roles: + And the user API response should contain the following app roles: | Admin | | Space Admin | | User | diff --git a/tests/acceptance/features/bootstrap/GraphContext.php b/tests/acceptance/features/bootstrap/GraphContext.php index 50d987c6ec..c88a0c0537 100644 --- a/tests/acceptance/features/bootstrap/GraphContext.php +++ b/tests/acceptance/features/bootstrap/GraphContext.php @@ -1706,13 +1706,13 @@ class GraphContext implements Context { } /** - * @Then the user retrieve API response should contain the following applications information: + * @Then the user API response should contain the following application information: * * @param TableNode $table * * @return void */ - public function theResponseShouldContainTheFollowingApplicationsInformation(TableNode $table): void { + public function theResponseShouldContainTheFollowingApplicationInformation(TableNode $table): void { Assert::assertIsArray($responseArray = ($this->featureContext->getJsonDecodedResponse($this->featureContext->getResponse()))['value'][0]); foreach ($table->getHash() as $row) { $key = $row["key"]; @@ -1728,7 +1728,7 @@ class GraphContext implements Context { } /** - * @Then the user retrieve API response should contain the following app roles: + * @Then the user API response should contain the following app roles: * * @param TableNode $table *