From c52c3e9db7214eca09732b930757be721ca5b35c Mon Sep 17 00:00:00 2001 From: Prarup Gurung Date: Fri, 15 Mar 2024 14:18:33 +0545 Subject: [PATCH] Addressed reviews --- .../acceptance/features/apiSharingNg/propfindShares.feature | 2 +- tests/acceptance/features/bootstrap/SpacesContext.php | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/acceptance/features/apiSharingNg/propfindShares.feature b/tests/acceptance/features/apiSharingNg/propfindShares.feature index 7fb15876ed..6dae19ec06 100644 --- a/tests/acceptance/features/apiSharingNg/propfindShares.feature +++ b/tests/acceptance/features/apiSharingNg/propfindShares.feature @@ -26,7 +26,7 @@ Feature: propfind a shares | sharee | Brian | | shareType | user | | permissionsRole | Viewer | - When user "Brian" sends PROPFIND request from the space "Shares" to the resource "/" with depth "1" using the WebDAV API + When user "Brian" sends PROPFIND request to space "Shares" using the WebDAV API Then the HTTP status code should be "207" And the "PROPFIND" response to user "Brian" should contain a space "Shares" with these key and value pairs: | key | value | diff --git a/tests/acceptance/features/bootstrap/SpacesContext.php b/tests/acceptance/features/bootstrap/SpacesContext.php index cc2a02e7bb..4ec063d2df 100644 --- a/tests/acceptance/features/bootstrap/SpacesContext.php +++ b/tests/acceptance/features/bootstrap/SpacesContext.php @@ -3620,8 +3620,8 @@ class SpacesContext implements Context { * * @param string $user * @param string $spaceName - * @param ?string $resource - * @param ?string $folderDepth + * @param string $resource + * @param string $folderDepth * * @return void * @@ -3629,7 +3629,7 @@ class SpacesContext implements Context { * * @throws GuzzleException */ - public function userSendsPropfindRequestFromTheSpaceToTheResourceWithDepthUsingTheWebdavApi(string $user, string $spaceName, ?string $resource = "", ?string $folderDepth = "1"): void { + public function userSendsPropfindRequestFromTheSpaceToTheResourceWithDepthUsingTheWebdavApi(string $user, string $spaceName, string $resource, string $folderDepth): void { $this->featureContext->setResponse( $this->sendPropfindRequestToSpace($user, $spaceName, $resource, null, $folderDepth) );