From c969faf8eff9d584520ecbae1e40637207e0e84a Mon Sep 17 00:00:00 2001 From: Swikriti Tripathi Date: Fri, 5 May 2023 15:05:47 +0545 Subject: [PATCH] Add proper description to a feature file --- .../expected-failures-API-on-OCIS-storage.md | 60 +++++++++---------- .../features/apiGraph/deleteGroup.feature | 4 +- .../acceptance/features/bootstrap/Sharing.php | 16 ++--- .../createShareToSharesFolder.feature | 2 +- .../accessToShare.feature | 3 + .../changingFilesShare.feature | 9 ++- .../gettingShares.feature | 21 ++++--- .../gettingSharesPendingFiltered.feature | 4 +- .../gettingSharesReceivedFiltered.feature | 4 +- ...gettingSharesReceivedFilteredEmpty.feature | 4 +- .../gettingSharesSharedFiltered.feature | 12 ++-- .../gettingSharesSharedFilteredEmpty.feature | 10 ++-- .../getWebDAVSharePermissions.feature | 39 ++++++------ .../shareAccessByID.feature | 7 ++- .../uploadToShare.feature | 27 +++++---- .../accessToPublicLinkShare.feature | 11 ++-- .../changingPublicLinkShare.feature | 25 ++++---- .../createPublicLinkShare.feature | 35 ++++++----- .../createPublicLinkShareToShares.feature | 5 +- .../deletePublicLinkShare.feature | 11 ++-- 20 files changed, 171 insertions(+), 138 deletions(-) diff --git a/tests/acceptance/expected-failures-API-on-OCIS-storage.md b/tests/acceptance/expected-failures-API-on-OCIS-storage.md index d8ac0bc88..e6c5bee81 100644 --- a/tests/acceptance/expected-failures-API-on-OCIS-storage.md +++ b/tests/acceptance/expected-failures-API-on-OCIS-storage.md @@ -211,16 +211,16 @@ cannot share a folder with create permission #### [OCS error message for attempting to access share via share id as an unauthorized user is not informative](https://github.com/owncloud/ocis/issues/1233) -- [coreApiShareOperationsToShares1/gettingShares.feature:149](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/gettingShares.feature#L149) -- [coreApiShareOperationsToShares1/gettingShares.feature:150](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/gettingShares.feature#L150) +- [coreApiShareOperationsToShares1/gettingShares.feature:152](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/gettingShares.feature#L152) +- [coreApiShareOperationsToShares1/gettingShares.feature:153](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/gettingShares.feature#L153) #### [Listing shares via ocs API does not show path for parent folders](https://github.com/owncloud/ocis/issues/1231) -- [coreApiShareOperationsToShares1/gettingShares.feature:186](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/gettingShares.feature#L186) -- [coreApiShareOperationsToShares1/gettingShares.feature:187](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/gettingShares.feature#L187) +- [coreApiShareOperationsToShares1/gettingShares.feature:189](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/gettingShares.feature#L189) +- [coreApiShareOperationsToShares1/gettingShares.feature:190](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/gettingShares.feature#L190) #### [Public link enforce permissions](https://github.com/owncloud/ocis/issues/1269) -- [coreApiSharePublicLink1/createPublicLinkShare.feature:353](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShare.feature#L353) +- [coreApiSharePublicLink1/createPublicLinkShare.feature:356](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShare.feature#L356) #### [download previews of other users file](https://github.com/owncloud/ocis/issues/2071) @@ -270,17 +270,17 @@ cannot share a folder with create permission #### [changing user quota gives ocs status 103 / Cannot set quota](https://github.com/owncloud/product/issues/247) -- [coreApiShareOperationsToShares2/uploadToShare.feature:208](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/uploadToShare.feature#L208) -- [coreApiShareOperationsToShares2/uploadToShare.feature:209](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/uploadToShare.feature#L209) +- [coreApiShareOperationsToShares2/uploadToShare.feature:211](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/uploadToShare.feature#L211) +- [coreApiShareOperationsToShares2/uploadToShare.feature:212](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/uploadToShare.feature#L212) #### [not possible to move file into a received folder](https://github.com/owncloud/ocis/issues/764) -- [coreApiShareOperationsToShares1/changingFilesShare.feature:23](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/changingFilesShare.feature#L23) -- [coreApiShareOperationsToShares1/changingFilesShare.feature:24](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/changingFilesShare.feature#L24) -- [coreApiShareOperationsToShares1/changingFilesShare.feature:67](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/changingFilesShare.feature#L67) -- [coreApiShareOperationsToShares1/changingFilesShare.feature:68](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/changingFilesShare.feature#L68) -- [coreApiShareOperationsToShares1/changingFilesShare.feature:89](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/changingFilesShare.feature#L89) -- [coreApiShareOperationsToShares1/changingFilesShare.feature:90](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/changingFilesShare.feature#L90) +- [coreApiShareOperationsToShares1/changingFilesShare.feature:26](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/changingFilesShare.feature#L26) +- [coreApiShareOperationsToShares1/changingFilesShare.feature:27](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/changingFilesShare.feature#L27) +- [coreApiShareOperationsToShares1/changingFilesShare.feature:70](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/changingFilesShare.feature#L70) +- [coreApiShareOperationsToShares1/changingFilesShare.feature:71](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/changingFilesShare.feature#L71) +- [coreApiShareOperationsToShares1/changingFilesShare.feature:92](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/changingFilesShare.feature#L92) +- [coreApiShareOperationsToShares1/changingFilesShare.feature:93](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares1/changingFilesShare.feature#L93) - [coreApiShareManagementBasicToShares/createShareToSharesFolder.feature:534](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature#L534) - [coreApiWebdavMove2/moveShareOnOcis.feature:30](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavMove2/moveShareOnOcis.feature#L30) - [coreApiWebdavMove2/moveShareOnOcis.feature:32](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavMove2/moveShareOnOcis.feature#L32) @@ -377,14 +377,14 @@ User and group management features _ocs: api compatibility, return correct status code_ -- [coreApiShareOperationsToShares2/shareAccessByID.feature:46](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L46) -- [coreApiShareOperationsToShares2/shareAccessByID.feature:47](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L47) -- [coreApiShareOperationsToShares2/shareAccessByID.feature:48](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L48) - [coreApiShareOperationsToShares2/shareAccessByID.feature:49](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L49) - [coreApiShareOperationsToShares2/shareAccessByID.feature:50](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L50) - [coreApiShareOperationsToShares2/shareAccessByID.feature:51](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L51) - [coreApiShareOperationsToShares2/shareAccessByID.feature:52](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L52) - [coreApiShareOperationsToShares2/shareAccessByID.feature:53](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L53) +- [coreApiShareOperationsToShares2/shareAccessByID.feature:54](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L54) +- [coreApiShareOperationsToShares2/shareAccessByID.feature:55](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L55) +- [coreApiShareOperationsToShares2/shareAccessByID.feature:56](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L56) ### Other @@ -400,7 +400,7 @@ API, search, favorites, config, capabilities, not existing endpoints, CORS and o - [coreApiAuthOcs/ocsGETAuth.feature:124](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiAuthOcs/ocsGETAuth.feature#L124) - [coreApiAuthOcs/ocsPOSTAuth.feature:11](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiAuthOcs/ocsPOSTAuth.feature#L11) - [coreApiAuthOcs/ocsPUTAuth.feature:11](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiAuthOcs/ocsPUTAuth.feature#L11) -- [coreApiSharePublicLink1/createPublicLinkShare.feature:343](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShare.feature#L343) +- [coreApiSharePublicLink1/createPublicLinkShare.feature:346](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShare.feature#L346) #### [sending MKCOL requests to another user's webDav endpoints as normal user gives 404 instead of 403 ](https://github.com/owncloud/ocis/issues/3872) @@ -549,26 +549,26 @@ And other missing implementation of favorites #### [Trying to accept a share with invalid ID gives incorrect OCS and HTTP status](https://github.com/owncloud/ocis/issues/2111) -- [coreApiShareOperationsToShares2/shareAccessByID.feature:83](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L83) -- [coreApiShareOperationsToShares2/shareAccessByID.feature:84](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L84) -- [coreApiShareOperationsToShares2/shareAccessByID.feature:85](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L85) - [coreApiShareOperationsToShares2/shareAccessByID.feature:86](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L86) - [coreApiShareOperationsToShares2/shareAccessByID.feature:87](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L87) - [coreApiShareOperationsToShares2/shareAccessByID.feature:88](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L88) - [coreApiShareOperationsToShares2/shareAccessByID.feature:89](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L89) - [coreApiShareOperationsToShares2/shareAccessByID.feature:90](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L90) -- [coreApiShareOperationsToShares2/shareAccessByID.feature:102](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L102) -- [coreApiShareOperationsToShares2/shareAccessByID.feature:103](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L103) -- [coreApiShareOperationsToShares2/shareAccessByID.feature:134](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L134) -- [coreApiShareOperationsToShares2/shareAccessByID.feature:135](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L135) -- [coreApiShareOperationsToShares2/shareAccessByID.feature:136](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L136) +- [coreApiShareOperationsToShares2/shareAccessByID.feature:91](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L91) +- [coreApiShareOperationsToShares2/shareAccessByID.feature:92](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L92) +- [coreApiShareOperationsToShares2/shareAccessByID.feature:93](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L93) +- [coreApiShareOperationsToShares2/shareAccessByID.feature:105](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L105) +- [coreApiShareOperationsToShares2/shareAccessByID.feature:106](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L106) - [coreApiShareOperationsToShares2/shareAccessByID.feature:137](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L137) - [coreApiShareOperationsToShares2/shareAccessByID.feature:138](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L138) - [coreApiShareOperationsToShares2/shareAccessByID.feature:139](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L139) - [coreApiShareOperationsToShares2/shareAccessByID.feature:140](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L140) - [coreApiShareOperationsToShares2/shareAccessByID.feature:141](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L141) -- [coreApiShareOperationsToShares2/shareAccessByID.feature:153](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L153) -- [coreApiShareOperationsToShares2/shareAccessByID.feature:154](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L154) +- [coreApiShareOperationsToShares2/shareAccessByID.feature:142](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L142) +- [coreApiShareOperationsToShares2/shareAccessByID.feature:143](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L143) +- [coreApiShareOperationsToShares2/shareAccessByID.feature:144](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L144) +- [coreApiShareOperationsToShares2/shareAccessByID.feature:156](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L156) +- [coreApiShareOperationsToShares2/shareAccessByID.feature:157](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L157) #### [Shares to deleted group listed in the response](https://github.com/owncloud/ocis/issues/2441) @@ -628,9 +628,9 @@ Not everything needs to be implemented for ocis. While the oc10 testsuite covers - [coreApiShareManagementToShares/acceptShares.feature:183](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementToShares/acceptShares.feature#L183) - [coreApiShareManagementToShares/acceptShares.feature:228](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementToShares/acceptShares.feature#L228) - [coreApiShareManagementToShares/acceptShares.feature:438](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementToShares/acceptShares.feature#L438) -- [coreApiShareOperationsToShares2/shareAccessByID.feature:121](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L121) -- [coreApiShareOperationsToShares2/shareAccessByID.feature:122](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L122) -- - [coreApiShareManagementBasicToShares/deleteShareFromShares.feature:178](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementBasicToShares/deleteShareFromShares.feature#L178) +- [coreApiShareOperationsToShares2/shareAccessByID.feature:124](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L124) +- [coreApiShareOperationsToShares2/shareAccessByID.feature:125](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature#L125) +- [coreApiShareManagementBasicToShares/deleteShareFromShares.feature:178](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementBasicToShares/deleteShareFromShares.feature#L178) - [coreApiShareManagementBasicToShares/deleteShareFromShares.feature:179](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementBasicToShares/deleteShareFromShares.feature#L179) - [coreApiShareManagementBasicToShares/deleteShareFromShares.feature:180](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementBasicToShares/deleteShareFromShares.feature#L180) - [coreApiShareManagementBasicToShares/deleteShareFromShares.feature:181](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementBasicToShares/deleteShareFromShares.feature#L181) diff --git a/tests/acceptance/features/apiGraph/deleteGroup.feature b/tests/acceptance/features/apiGraph/deleteGroup.feature index 45c709012..48ca52ccf 100644 --- a/tests/acceptance/features/apiGraph/deleteGroup.feature +++ b/tests/acceptance/features/apiGraph/deleteGroup.feature @@ -1,4 +1,4 @@ -@api +@api Feature: delete groups As an admin I want to be able to delete groups @@ -72,7 +72,7 @@ Feature: delete groups And user "Alice" has shared file "lorem.txt" with group "grp1" And user "Alice" has shared file "lorem.txt" with group "grp2" And group "grp1" has been deleted - When user "Alice" gets all the shares from the file "lorem.txt" using the sharing API + When user "Alice" gets all the shares of the file "lorem.txt" using the sharing API Then the HTTP status code should be "200" And group "grp2" should be included in the response But group "grp1" should not be included in the response diff --git a/tests/acceptance/features/bootstrap/Sharing.php b/tests/acceptance/features/bootstrap/Sharing.php index cd3f61988..8116149a6 100644 --- a/tests/acceptance/features/bootstrap/Sharing.php +++ b/tests/acceptance/features/bootstrap/Sharing.php @@ -2271,7 +2271,7 @@ trait Sharing { } /** - * @When user :user gets all the shares shared with him using the sharing API + * @When user :user gets all the shares shared with him/her using the sharing API * * @param string $user * @@ -2303,7 +2303,7 @@ trait Sharing { } /** - * @When /^user "([^"]*)" gets the (|pending)\s?(user|group|user and group|public link) shares shared with him using the sharing API$/ + * @When /^user "([^"]*)" gets the (|pending)\s?(user|group|user and group|public link) shares shared with (?:him|her) using the sharing API$/ * * @param string $user * @param string $pending @@ -2336,7 +2336,7 @@ trait Sharing { } /** - * @When /^user "([^"]*)" gets all the shares shared with him that are received as (?:file|folder|entry) "([^"]*)" using the provisioning API$/ + * @When /^user "([^"]*)" gets all the shares shared with (?:him|her|them) that are received as (?:file|folder|entry) "([^"]*)" using the provisioning API$/ * * @param string $user * @param string $path @@ -2355,7 +2355,7 @@ trait Sharing { } /** - * @When user :user gets all shares shared by him using the sharing API + * @When user :user gets all shares shared by him/her using the sharing API * * @param string $user * @@ -2376,7 +2376,7 @@ trait Sharing { } /** - * @When the administrator gets all shares shared by him using the sharing API + * @When the administrator gets all shares shared by him/her using the sharing API * * @return void */ @@ -2385,7 +2385,7 @@ trait Sharing { } /** - * @When /^user "([^"]*)" gets the (user|group|user and group|public link) shares shared by him using the sharing API$/ + * @When /^user "([^"]*)" gets the (user|group|user and group|public link) shares shared by (?:him|her) using the sharing API$/ * * @param string $user * @param string $shareType @@ -2415,7 +2415,7 @@ trait Sharing { } /** - * @When user :user gets all the shares from the file :path using the sharing API + * @When user :user gets all the shares of the file :path using the sharing API * * @param string $user * @param string $path @@ -2437,7 +2437,7 @@ trait Sharing { } /** - * @When user :user gets all the shares with reshares from the file :path using the sharing API + * @When user :user gets all the shares with reshares of the file :path using the sharing API * * @param string $user * @param string $path diff --git a/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature b/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature index fbf4b5748..9c0cc41d6 100644 --- a/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature +++ b/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature @@ -668,7 +668,7 @@ Feature: sharing And user "Brian" has accepted share "/textfile0.txt" offered by user "Alice" And user "Carol" has accepted share "/textfile0.txt" offered by user "Alice" And the administrator has deleted user "Brian" using the provisioning API - When user "Alice" gets all the shares from the file "textfile0.txt" using the sharing API + When user "Alice" gets all the shares of the file "textfile0.txt" using the sharing API Then the OCS status code should be "" And the HTTP status code should be "200" And user "Carol" should be included in the response diff --git a/tests/acceptance/features/coreApiShareOperationsToShares1/accessToShare.feature b/tests/acceptance/features/coreApiShareOperationsToShares1/accessToShare.feature index 7c3b46979..6853ee756 100644 --- a/tests/acceptance/features/coreApiShareOperationsToShares1/accessToShare.feature +++ b/tests/acceptance/features/coreApiShareOperationsToShares1/accessToShare.feature @@ -1,5 +1,8 @@ @api Feature: sharing + As a user + I want to share resources with other users + So that they can have access to the resources Background: Given these users have been created with default attributes and without skeleton files: diff --git a/tests/acceptance/features/coreApiShareOperationsToShares1/changingFilesShare.feature b/tests/acceptance/features/coreApiShareOperationsToShares1/changingFilesShare.feature index 2ebb728cd..8d52cf671 100644 --- a/tests/acceptance/features/coreApiShareOperationsToShares1/changingFilesShare.feature +++ b/tests/acceptance/features/coreApiShareOperationsToShares1/changingFilesShare.feature @@ -1,5 +1,8 @@ @api @issue-1289 @issue-1328 Feature: sharing + As a user + I want to move shares that I received + So that I can organise them according to my needs Background: Given these users have been created with default attributes and without skeleton files: @@ -24,7 +27,7 @@ Feature: sharing | new | - Scenario Outline: Move files between shares by same user + Scenario Outline: move files between shares by same user Given using DAV path And user "Alice" has created folder "share1" And user "Alice" has created folder "share2" @@ -46,7 +49,7 @@ Feature: sharing | new | - Scenario Outline: Move files between shares by same user added by sharee + Scenario Outline: move files between shares by same user added by sharee Given using DAV path And user "Alice" has created folder "share1" And user "Alice" has created folder "share2" @@ -68,7 +71,7 @@ Feature: sharing | new | - Scenario Outline: Move files between shares by different users + Scenario Outline: move files between shares by different users Given using DAV path And user "Carol" has been created with default attributes and without skeleton files And user "Alice" has uploaded file with content "some data" to "/textfile0.txt" diff --git a/tests/acceptance/features/coreApiShareOperationsToShares1/gettingShares.feature b/tests/acceptance/features/coreApiShareOperationsToShares1/gettingShares.feature index 3d0b83c13..d30a5b7ff 100644 --- a/tests/acceptance/features/coreApiShareOperationsToShares1/gettingShares.feature +++ b/tests/acceptance/features/coreApiShareOperationsToShares1/gettingShares.feature @@ -1,5 +1,8 @@ @api Feature: sharing + As a user + I want to get all the shares + So that I can know I have proper access to them Background: Given these users have been created with default attributes and without skeleton files: @@ -8,12 +11,12 @@ Feature: sharing | Brian | @smokeTest @issue-1258 - Scenario Outline: getting all shares of a user using that user + Scenario Outline: getting all shares from a user Given using OCS API version "" And user "Alice" has uploaded file with content "some data" to "/file_to_share.txt" And user "Alice" has shared file "file_to_share.txt" with user "Brian" And user "Brian" has accepted share "/file_to_share.txt" offered by user "Alice" - When user "Alice" gets all shares shared by him using the sharing API + When user "Alice" gets all shares shared by her using the sharing API Then the OCS status code should be "" And the HTTP status code should be "200" And file "/Shares/file_to_share.txt" should be included in the response @@ -49,7 +52,7 @@ Feature: sharing And user "Alice" has shared file "textfile0.txt" with user "Carol" And user "Brian" has accepted share "/textfile0.txt" offered by user "Alice" And user "Carol" has accepted share "/textfile0.txt" offered by user "Alice" - When user "Alice" gets all the shares from the file "textfile0.txt" using the sharing API + When user "Alice" gets all the shares of the file "textfile0.txt" using the sharing API Then the OCS status code should be "" And the HTTP status code should be "200" And user "Brian" should be included in the response @@ -72,7 +75,7 @@ Feature: sharing And user "Brian" has accepted share "/textfile0.txt" offered by user "Alice" And user "Brian" has shared file "/Shares/textfile0.txt" with user "Carol" And user "Carol" has accepted share "/textfile0.txt" offered by user "Brian" - When user "Alice" gets all the shares with reshares from the file "textfile0.txt" using the sharing API + When user "Alice" gets all the shares with reshares of the file "textfile0.txt" using the sharing API Then the OCS status code should be "" And the HTTP status code should be "200" And user "Brian" should be included in the response @@ -84,7 +87,7 @@ Feature: sharing | 2 | 200 | @smokeTest - Scenario Outline: User's own shares reshared to him don't appear when getting "shared with me" shares + Scenario Outline: resource cannot be reshared to resource owner Given using OCS API version "" And group "grp1" has been created And user "Carol" has been created with default attributes and without skeleton files @@ -95,7 +98,7 @@ Feature: sharing And user "Brian" has accepted share "/shared" offered by user "Carol" And user "Brian" has shared folder "/Shares/shared" with group "grp1" # no need to accept this share as it is Carol's file - When user "Carol" gets all the shares shared with him using the sharing API + When user "Carol" gets all the shares shared with her using the sharing API Then the OCS status code should be "" And the HTTP status code should be "200" And the last share id should not be included in the response @@ -136,7 +139,7 @@ Feature: sharing | 2 | 200 | @issue-1233 - Scenario Outline: Get a share with a user that didn't receive the share + Scenario Outline: get a share with a user that didn't receive the share Given using OCS API version "" And user "Carol" has been created with default attributes and without skeleton files And user "Alice" has uploaded file with content "some data" to "/textfile0.txt" @@ -149,8 +152,8 @@ Feature: sharing | 1 | 200 | | 2 | 404 | - @issue-1289 @skipOnGraph - Scenario: Share of folder to a group, remove user from that group + @issue-1289 @skipOnGraph + Scenario: share a folder to a group, and remove user from that group Given using OCS API version "1" And user "Carol" has been created with default attributes and without skeleton files And group "group0" has been created diff --git a/tests/acceptance/features/coreApiShareOperationsToShares1/gettingSharesPendingFiltered.feature b/tests/acceptance/features/coreApiShareOperationsToShares1/gettingSharesPendingFiltered.feature index 9fefc31e7..b3720c578 100644 --- a/tests/acceptance/features/coreApiShareOperationsToShares1/gettingSharesPendingFiltered.feature +++ b/tests/acceptance/features/coreApiShareOperationsToShares1/gettingSharesPendingFiltered.feature @@ -1,8 +1,8 @@ @api Feature: get the pending shares filtered by type (user, group etc) As a user - I want to be able to know the pending shares that I have received of a particular type (user, group etc) - So that I can reduce the amount of data that has to be transferred to be just the data that I need + I want to filter the pending shares that I have received of a particular type (user, group etc) + So that I can know about the status of the shares I've received Background: Given these users have been created with default attributes and without skeleton files: diff --git a/tests/acceptance/features/coreApiShareOperationsToShares1/gettingSharesReceivedFiltered.feature b/tests/acceptance/features/coreApiShareOperationsToShares1/gettingSharesReceivedFiltered.feature index 36eee7172..2a489197b 100644 --- a/tests/acceptance/features/coreApiShareOperationsToShares1/gettingSharesReceivedFiltered.feature +++ b/tests/acceptance/features/coreApiShareOperationsToShares1/gettingSharesReceivedFiltered.feature @@ -1,8 +1,8 @@ @api Feature: get the received shares filtered by type (user, group etc) As a user - I want to be able to know the shares that I have received of a particular type (user, group etc) - So that I can reduce the amount of data that has to be transferred to be just the data that I need + I want to filter the shares that I have received of a particular type (user, group etc) + So that I can know about the status of the shares I've received Background: Given these users have been created with default attributes and without skeleton files: diff --git a/tests/acceptance/features/coreApiShareOperationsToShares1/gettingSharesReceivedFilteredEmpty.feature b/tests/acceptance/features/coreApiShareOperationsToShares1/gettingSharesReceivedFilteredEmpty.feature index 2c9533be3..b8785084b 100644 --- a/tests/acceptance/features/coreApiShareOperationsToShares1/gettingSharesReceivedFilteredEmpty.feature +++ b/tests/acceptance/features/coreApiShareOperationsToShares1/gettingSharesReceivedFilteredEmpty.feature @@ -1,8 +1,8 @@ @api Feature: get the received shares filtered by type (user, group etc) As a user - I want to be able to know the shares that I have received of a particular type (user, group etc) - So that I can reduce the amount of data that has to be transferred to be just the data that I need + I want to filter the shares that I have received of a particular type (user, group etc) + So that I can know about the status of the shares I've received Background: Given these users have been created with default attributes and without skeleton files: diff --git a/tests/acceptance/features/coreApiShareOperationsToShares1/gettingSharesSharedFiltered.feature b/tests/acceptance/features/coreApiShareOperationsToShares1/gettingSharesSharedFiltered.feature index 825c702be..82cbf91be 100644 --- a/tests/acceptance/features/coreApiShareOperationsToShares1/gettingSharesSharedFiltered.feature +++ b/tests/acceptance/features/coreApiShareOperationsToShares1/gettingSharesSharedFiltered.feature @@ -1,8 +1,8 @@ @api Feature: get shares filtered by type (user, group etc) As a user - I want to be able to know the shares that I have made of a particular type (user, group etc) - So that I can reduce the amount of data that has to be transferred to be just the data that I need + I want to filter the shares that I have received of a particular type (user, group etc) + So that I can know about the status of the shares I've received Background: Given these users have been created with default attributes and without skeleton files: @@ -35,7 +35,7 @@ Feature: get shares filtered by type (user, group etc) Scenario Outline: getting shares shared to users Given using OCS API version "" - When user "Alice" gets the user shares shared by him using the sharing API + When user "Alice" gets the user shares shared by her using the sharing API Then the OCS status code should be "" And the HTTP status code should be "200" And exactly 2 files or folders should be included in the response @@ -49,7 +49,7 @@ Feature: get shares filtered by type (user, group etc) Scenario Outline: getting shares shared to groups Given using OCS API version "" - When user "Alice" gets the group shares shared by him using the sharing API + When user "Alice" gets the group shares shared by her using the sharing API Then the OCS status code should be "" And the HTTP status code should be "200" And exactly 2 files or folders should be included in the response @@ -63,7 +63,7 @@ Feature: get shares filtered by type (user, group etc) Scenario Outline: getting shares shared to public links Given using OCS API version "" - When user "Alice" gets the public link shares shared by him using the sharing API + When user "Alice" gets the public link shares shared by her using the sharing API Then the OCS status code should be "" And the HTTP status code should be "200" And exactly 2 files or folders should be included in the response @@ -77,7 +77,7 @@ Feature: get shares filtered by type (user, group etc) Scenario Outline: getting shares shared to users and groups Given using OCS API version "" - When user "Alice" gets the user and group shares shared by him using the sharing API + When user "Alice" gets the user and group shares shared by her using the sharing API Then the OCS status code should be "" And the HTTP status code should be "200" And exactly 4 files or folders should be included in the response diff --git a/tests/acceptance/features/coreApiShareOperationsToShares1/gettingSharesSharedFilteredEmpty.feature b/tests/acceptance/features/coreApiShareOperationsToShares1/gettingSharesSharedFilteredEmpty.feature index 2ac882dbd..eea4313a7 100644 --- a/tests/acceptance/features/coreApiShareOperationsToShares1/gettingSharesSharedFilteredEmpty.feature +++ b/tests/acceptance/features/coreApiShareOperationsToShares1/gettingSharesSharedFilteredEmpty.feature @@ -1,8 +1,8 @@ @api Feature: get shares filtered by type (user, group etc) As a user - I want to be able to know the shares that I have made of a particular type (user, group etc) - So that I can reduce the amount of data that has to be transferred to be just the data that I need + I want to filter the shares that I have received of a particular type (user, group etc) + So that I can know about the status of the shares I've received Background: Given these users have been created with default attributes and without skeleton files: @@ -31,7 +31,7 @@ Feature: get shares filtered by type (user, group etc) And user "Alice" has created a public link share with settings | path | /fileToShareWithPublic.txt | | permissions | read | - When user "Alice" gets the user shares shared by him using the sharing API + When user "Alice" gets the user shares shared by her using the sharing API Then the OCS status code should be "" And the HTTP status code should be "200" And no files or folders should be included in the response @@ -53,7 +53,7 @@ Feature: get shares filtered by type (user, group etc) And user "Alice" has created a public link share with settings | path | /fileToShareWithPublic.txt | | permissions | read | - When user "Alice" gets the group shares shared by him using the sharing API + When user "Alice" gets the group shares shared by her using the sharing API Then the OCS status code should be "" And the HTTP status code should be "200" And no files or folders should be included in the response @@ -73,7 +73,7 @@ Feature: get shares filtered by type (user, group etc) And user "Brian" has accepted share "/fileToShareWithUser.txt" offered by user "Alice" And user "Alice" has shared file "/fileToShareWithGroup.txt" with group "grp1" And user "Brian" has accepted share "/fileToShareWithGroup.txt" offered by user "Alice" - When user "Alice" gets the public link shares shared by him using the sharing API + When user "Alice" gets the public link shares shared by her using the sharing API Then the OCS status code should be "" And the HTTP status code should be "200" And no files or folders should be included in the response diff --git a/tests/acceptance/features/coreApiShareOperationsToShares2/getWebDAVSharePermissions.feature b/tests/acceptance/features/coreApiShareOperationsToShares2/getWebDAVSharePermissions.feature index 48e7543e0..a1824d204 100644 --- a/tests/acceptance/features/coreApiShareOperationsToShares2/getWebDAVSharePermissions.feature +++ b/tests/acceptance/features/coreApiShareOperationsToShares2/getWebDAVSharePermissions.feature @@ -1,5 +1,8 @@ @api Feature: sharing + As a user + I want to check the webdav share permissions + So that I know the resources have proper permissions Background: Given using OCS API version "1" @@ -9,7 +12,7 @@ Feature: sharing | Brian | @smokeTest - Scenario Outline: Correct webdav share-permissions for owned file + Scenario Outline: check webdav share-permissions for owned file Given using DAV path And user "Alice" has uploaded file with content "foo" to "/tmp.txt" When user "Alice" gets the following properties of file "/tmp.txt" using the WebDAV API @@ -28,7 +31,7 @@ Feature: sharing | spaces | - Scenario Outline: Correct webdav share-permissions for received file with edit and reshare permissions + Scenario Outline: check webdav share-permissions for received file with edit and reshare permissions Given using DAV path And user "Alice" has uploaded file with content "foo" to "/tmp.txt" And user "Alice" has shared file "/tmp.txt" with user "Brian" @@ -44,7 +47,7 @@ Feature: sharing | new | - Scenario Outline: Correct webdav share-permissions for received group shared file with edit and reshare permissions + Scenario Outline: check webdav share-permissions for received group shared file with edit and reshare permissions Given using DAV path And group "grp1" has been created And user "Brian" has been added to group "grp1" @@ -66,7 +69,7 @@ Feature: sharing | new | @issue-2213 - Scenario Outline: Correct webdav share-permissions for received file with edit permissions but no reshare permissions + Scenario Outline: check webdav share-permissions for received file with edit permissions but no reshare permissions Given using DAV path And user "Alice" has uploaded file with content "foo" to "/tmp.txt" And user "Alice" has shared file "tmp.txt" with user "Brian" @@ -81,7 +84,7 @@ Feature: sharing | new | @issue-2213 - Scenario Outline: Correct webdav share-permissions for received group shared file with edit permissions but no reshare permissions + Scenario Outline: check webdav share-permissions for received group shared file with edit permissions but no reshare permissions Given using DAV path And group "grp1" has been created And user "Brian" has been added to group "grp1" @@ -103,7 +106,7 @@ Feature: sharing | new | @issue-2213 - Scenario Outline: Correct webdav share-permissions for received file with reshare permissions but no edit permissions + Scenario Outline: check webdav share-permissions for received file with reshare permissions but no edit permissions Given using DAV path And user "Alice" has uploaded file with content "foo" to "/tmp.txt" And user "Alice" has shared file "tmp.txt" with user "Brian" @@ -118,7 +121,7 @@ Feature: sharing | new | - Scenario Outline: Correct webdav share-permissions for received group shared file with reshare permissions but no edit permissions + Scenario Outline: check webdav share-permissions for received group shared file with reshare permissions but no edit permissions Given using DAV path And group "grp1" has been created And user "Brian" has been added to group "grp1" @@ -140,7 +143,7 @@ Feature: sharing | new | - Scenario Outline: Correct webdav share-permissions for owned folder + Scenario Outline: check webdav share-permissions for owned folder Given using DAV path And user "Alice" has created folder "/tmp" When user "Alice" gets the following properties of folder "/" using the WebDAV API @@ -159,7 +162,7 @@ Feature: sharing | spaces | - Scenario Outline: Correct webdav share-permissions for received folder with all permissions + Scenario Outline: check webdav share-permissions for received folder with all permissions Given using DAV path And user "Alice" has created folder "/tmp" And user "Alice" has shared file "/tmp" with user "Brian" @@ -175,7 +178,7 @@ Feature: sharing | new | - Scenario Outline: Correct webdav share-permissions for received group shared folder with all permissions + Scenario Outline: check webdav share-permissions for received group shared folder with all permissions Given using DAV path And group "grp1" has been created And user "Brian" has been added to group "grp1" @@ -196,7 +199,7 @@ Feature: sharing | new | @issue-2213 - Scenario Outline: Correct webdav share-permissions for received folder with all permissions but edit + Scenario Outline: check webdav share-permissions for received folder with all permissions but edit Given using DAV path And user "Alice" has created folder "/tmp" And user "Alice" has shared file "/tmp" with user "Brian" @@ -211,7 +214,7 @@ Feature: sharing | new | - Scenario Outline: Correct webdav share-permissions for received group shared folder with all permissions but edit + Scenario Outline: check webdav share-permissions for received group shared folder with all permissions but edit Given using DAV path And group "grp1" has been created And user "Brian" has been added to group "grp1" @@ -233,7 +236,7 @@ Feature: sharing | new | - Scenario Outline: Correct webdav share-permissions for received folder with all permissions but create + Scenario Outline: check webdav share-permissions for received folder with all permissions but create Given using DAV path And user "Alice" has created folder "/tmp" And user "Alice" has shared file "/tmp" with user "Brian" @@ -248,7 +251,7 @@ Feature: sharing | new | - Scenario Outline: Correct webdav share-permissions for received group shared folder with all permissions but create + Scenario Outline: check webdav share-permissions for received group shared folder with all permissions but create Given using DAV path And group "grp1" has been created And user "Brian" has been added to group "grp1" @@ -270,7 +273,7 @@ Feature: sharing | new | - Scenario Outline: Correct webdav share-permissions for received folder with all permissions but delete + Scenario Outline: check webdav share-permissions for received folder with all permissions but delete Given using DAV path And user "Alice" has created folder "/tmp" And user "Alice" has shared file "/tmp" with user "Brian" @@ -285,7 +288,7 @@ Feature: sharing | new | - Scenario Outline: Correct webdav share-permissions for received group shared folder with all permissions but delete + Scenario Outline: check webdav share-permissions for received group shared folder with all permissions but delete Given using DAV path And group "grp1" has been created And user "Brian" has been added to group "grp1" @@ -307,7 +310,7 @@ Feature: sharing | new | - Scenario Outline: Correct webdav share-permissions for received folder with all permissions but share + Scenario Outline: check webdav share-permissions for received folder with all permissions but share Given using DAV path And user "Alice" has created folder "/tmp" And user "Alice" has shared file "/tmp" with user "Brian" @@ -322,7 +325,7 @@ Feature: sharing | new | - Scenario Outline: Correct webdav share-permissions for received group shared folder with all permissions but share + Scenario Outline: check webdav share-permissions for received group shared folder with all permissions but share Given using DAV path And group "grp1" has been created And user "Brian" has been added to group "grp1" diff --git a/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature b/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature index c2752439b..2d7bcdf37 100644 --- a/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature +++ b/tests/acceptance/features/coreApiShareOperationsToShares2/shareAccessByID.feature @@ -1,5 +1,8 @@ @api Feature: share access by ID + As an API consumer (app) + I want to access a share by its id + So that the app can more easily manage shares Background: Given these users have been created with default attributes and without skeleton files: @@ -8,7 +11,7 @@ Feature: share access by ID | Brian | - Scenario Outline: Get a share with a valid share ID + Scenario Outline: get a share with a valid share ID Given using OCS API version "" And user "Alice" has uploaded file with content "ownCloud test text file 0" to "/textfile0.txt" When user "Alice" shares file "textfile0.txt" with user "Brian" using the sharing API @@ -35,7 +38,7 @@ Feature: share access by ID | 2 | 200 | - Scenario Outline: Get a share with an invalid share id + Scenario Outline: get a share with an invalid share id Given using OCS API version "" When user "Alice" gets share with id "" using the sharing API Then the OCS status code should be "404" diff --git a/tests/acceptance/features/coreApiShareOperationsToShares2/uploadToShare.feature b/tests/acceptance/features/coreApiShareOperationsToShares2/uploadToShare.feature index 277e604c6..e37d12762 100644 --- a/tests/acceptance/features/coreApiShareOperationsToShares2/uploadToShare.feature +++ b/tests/acceptance/features/coreApiShareOperationsToShares2/uploadToShare.feature @@ -1,11 +1,14 @@ @api Feature: sharing + As a user + I want to upload resources to a folder shared to me + So that other people can access the resource Background: Given user "Alice" has been created with default attributes and without skeleton files - Scenario: Uploading file to a user read-only share folder does not work + Scenario: uploading file to a user read-only share folder does not work Given user "Brian" has been created with default attributes and without skeleton files And user "Alice" has created folder "FOLDER" And user "Alice" has created a share with settings @@ -19,7 +22,7 @@ Feature: sharing And as "Alice" file "/FOLDER/textfile.txt" should not exist - Scenario Outline: Uploading file to a group read-only share folder does not work + Scenario Outline: uploading file to a group read-only share folder does not work Given using DAV path And user "Brian" has been created with default attributes and without skeleton files And group "grp1" has been created @@ -40,7 +43,7 @@ Feature: sharing | new | - Scenario Outline: Uploading file to a user upload-only share folder works + Scenario Outline: uploading file to a user upload-only share folder works Given using DAV path And user "Brian" has been created with default attributes and without skeleton files And user "Alice" has created folder "FOLDER" @@ -66,7 +69,7 @@ Feature: sharing | new | - Scenario Outline: Uploading file to a group upload-only share folder works + Scenario Outline: uploading file to a group upload-only share folder works Given using DAV path And user "Brian" has been created with default attributes and without skeleton files And group "grp1" has been created @@ -94,7 +97,7 @@ Feature: sharing | new | @smokeTest - Scenario Outline: Uploading file to a user read/write share folder works + Scenario Outline: uploading file to a user read/write share folder works Given using DAV path And user "Brian" has been created with default attributes and without skeleton files And user "Alice" has created folder "FOLDER" @@ -118,7 +121,7 @@ Feature: sharing | new | - Scenario Outline: Uploading file to a group read/write share folder works + Scenario Outline: uploading file to a group read/write share folder works Given using DAV path And user "Brian" has been created with default attributes and without skeleton files And group "grp1" has been created @@ -144,7 +147,7 @@ Feature: sharing | new | @smokeTest @skipOnGraph - Scenario Outline: Check quota of owners parent directory of a shared file + Scenario Outline: check quota of owners parent directory of a shared file Given using DAV path And user "Brian" has been created with default attributes and without skeleton files And the quota of user "Brian" has been set to "0" @@ -167,7 +170,7 @@ Feature: sharing | new | @skipOnGraph - Scenario Outline: Uploading to a user shared folder with read/write permission when the sharer has insufficient quota does not work + Scenario Outline: uploading to a user shared folder with read/write permission when the sharer has insufficient quota does not work Given using DAV path And user "Brian" has been created with default attributes and small skeleton files And user "Alice" has created folder "FOLDER" @@ -187,7 +190,7 @@ Feature: sharing | new | - Scenario Outline: Uploading to a group shared folder with read/write permission when the sharer has insufficient quota does not work + Scenario Outline: uploading to a group shared folder with read/write permission when the sharer has insufficient quota does not work Given using DAV path And user "Brian" has been created with default attributes and without skeleton files And group "grp1" has been created @@ -209,7 +212,7 @@ Feature: sharing | new | @skipOnGraph - Scenario Outline: Uploading to a user shared folder with upload-only permission when the sharer has insufficient quota does not work + Scenario Outline: uploading to a user shared folder with upload-only permission when the sharer has insufficient quota does not work Given using DAV path And user "Brian" has been created with default attributes and without skeleton files And user "Alice" has created folder "FOLDER" @@ -229,7 +232,7 @@ Feature: sharing | new | @skipOnGraph - Scenario Outline: Uploading to a group shared folder with upload-only permission when the sharer has insufficient quota does not work + Scenario Outline: uploading to a group shared folder with upload-only permission when the sharer has insufficient quota does not work Given using DAV path And user "Brian" has been created with default attributes and without skeleton files And group "grp1" has been created @@ -251,7 +254,7 @@ Feature: sharing | new | - Scenario Outline: Sharer can download file uploaded with different permission by sharee to a shared folder + Scenario Outline: sharer can download file uploaded with different permission by sharee to a shared folder Given using DAV path And user "Brian" has been created with default attributes and without skeleton files And user "Alice" has created folder "FOLDER" diff --git a/tests/acceptance/features/coreApiSharePublicLink1/accessToPublicLinkShare.feature b/tests/acceptance/features/coreApiSharePublicLink1/accessToPublicLinkShare.feature index f89202aaf..b93faf05e 100644 --- a/tests/acceptance/features/coreApiSharePublicLink1/accessToPublicLinkShare.feature +++ b/tests/acceptance/features/coreApiSharePublicLink1/accessToPublicLinkShare.feature @@ -1,5 +1,8 @@ @api Feature: accessing a public link share + As a person who knows a public link + I want be able to access the preview of a public link file + So that I can see a small preview of the file before deciding to download it Background: Given these users have been created with default attributes and without skeleton files: @@ -7,7 +10,7 @@ Feature: accessing a public link share | Alice | - Scenario: Access to the preview of password protected public link without providing the password is not allowed + Scenario: access to the preview of password protected public link without providing the password is not allowed Given user "Alice" has uploaded file "filesForUpload/testavatar.jpg" to "testavatar.jpg" And user "Alice" has created a public link share with settings | path | /testavatar.jpg | @@ -17,7 +20,7 @@ Feature: accessing a public link share Then the HTTP status code should be "404" - Scenario: Access to the preview of public shared file without password + Scenario: access to the preview of public shared file without password Given user "Alice" has uploaded file "filesForUpload/testavatar.jpg" to "testavatar.jpg" And user "Alice" has created a public link share with settings | path | /testavatar.jpg | @@ -26,7 +29,7 @@ Feature: accessing a public link share Then the HTTP status code should be "200" - Scenario: Access to the preview of password protected public shared file inside a folder without providing the password is not allowed + Scenario: access to the preview of password protected public shared file inside a folder without providing the password is not allowed Given user "Alice" has created folder "FOLDER" And user "Alice" has uploaded file "filesForUpload/testavatar.jpg" to "FOLDER/testavatar.jpg" And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "FOLDER/textfile0.txt" @@ -41,7 +44,7 @@ Feature: accessing a public link share Then the HTTP status code of responses on all endpoints should be "404" - Scenario: Access to the preview of public shared file inside a folder without password + Scenario: access to the preview of public shared file inside a folder without password Given user "Alice" has created folder "FOLDER" And user "Alice" has uploaded file "filesForUpload/testavatar.jpg" to "FOLDER/testavatar.jpg" And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "FOLDER/textfile0.txt" diff --git a/tests/acceptance/features/coreApiSharePublicLink1/changingPublicLinkShare.feature b/tests/acceptance/features/coreApiSharePublicLink1/changingPublicLinkShare.feature index 344fd8646..419da708f 100644 --- a/tests/acceptance/features/coreApiSharePublicLink1/changingPublicLinkShare.feature +++ b/tests/acceptance/features/coreApiSharePublicLink1/changingPublicLinkShare.feature @@ -1,6 +1,9 @@ @api @issue-1276 @issue-1277 @issue-2079 @issue-1269 Feature: changing a public link share + As a user + I want to set the permissions of a public link share + So that people who have the public link only have the designated authorization Background: Given these users have been created with default attributes and without skeleton files: @@ -10,7 +13,7 @@ Feature: changing a public link share And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "PARENT/parent.txt" - Scenario Outline: Public can or can-not delete file through publicly shared link depending on having delete permissions using the public WebDAV API + Scenario Outline: public can or cannot delete file through publicly shared link depending on having delete permissions using the public WebDAV API Given user "Alice" has created a public link share with settings | path | /PARENT | | permissions | | @@ -26,7 +29,7 @@ Feature: changing a public link share | read,update,create,delete | 204 | should not | - Scenario: Public link share permissions work correctly for renaming and share permissions read,update,create,delete using the public WebDAV API + Scenario: public link share permissions work correctly for renaming and share permissions read,update,create,delete using the public WebDAV API Given user "Alice" has created a public link share with settings | path | /PARENT | | permissions | read,update,create,delete | @@ -36,7 +39,7 @@ Feature: changing a public link share And as "Alice" file "/PARENT/newparent.txt" should exist - Scenario: Public link share permissions work correctly for upload with share permissions read,update,create,delete with the public WebDAV API + Scenario: public link share permissions work correctly for upload with share permissions read,update,create,delete with the public WebDAV API Given user "Alice" has created a public link share with settings | path | /PARENT | | permissions | read,update,create,delete | @@ -45,7 +48,7 @@ Feature: changing a public link share And the content of file "PARENT/lorem.txt" for user "Alice" should be "test" - Scenario: Public cannot delete file through publicly shared link with password using an invalid password with public WebDAV API + Scenario: public cannot delete file through publicly shared link with password using an invalid password with public WebDAV API Given user "Alice" has created a public link share with settings | path | /PARENT | | permissions | change | @@ -55,7 +58,7 @@ Feature: changing a public link share And as "Alice" file "PARENT/parent.txt" should exist - Scenario: Public can delete file through publicly shared link with password using the valid password with the public WebDAV API + Scenario: public can delete file through publicly shared link with password using the valid password with the public WebDAV API Given user "Alice" has created a public link share with settings | path | /PARENT | | permissions | change | @@ -65,7 +68,7 @@ Feature: changing a public link share And as "Alice" file "PARENT/parent.txt" should not exist - Scenario: Public tries to rename a file in a password protected share using an invalid password with the public WebDAV API + Scenario: public tries to rename a file in a password protected share using an invalid password with the public WebDAV API Given user "Alice" has created a public link share with settings | path | /PARENT | | permissions | change | @@ -76,7 +79,7 @@ Feature: changing a public link share And as "Alice" file "/PARENT/parent.txt" should exist - Scenario: Public tries to rename a file in a password protected share using the valid password with the public WebDAV API + Scenario: public tries to rename a file in a password protected share using the valid password with the public WebDAV API Given user "Alice" has created a public link share with settings | path | /PARENT | | permissions | change | @@ -87,7 +90,7 @@ Feature: changing a public link share And as "Alice" file "/PARENT/parent.txt" should not exist - Scenario: Public tries to upload to a password protected public share using an invalid password with the public WebDAV API + Scenario: public tries to upload to a password protected public share using an invalid password with the public WebDAV API Given user "Alice" has created a public link share with settings | path | /PARENT | | permissions | change | @@ -97,7 +100,7 @@ Feature: changing a public link share And as "Alice" file "/PARENT/lorem.txt" should not exist - Scenario: Public tries to upload to a password protected public share using the valid password with the public WebDAV API + Scenario: public tries to upload to a password protected public share using the valid password with the public WebDAV API Given user "Alice" has created a public link share with settings | path | /PARENT | | permissions | change | @@ -107,7 +110,7 @@ Feature: changing a public link share And as "Alice" file "/PARENT/lorem.txt" should exist - Scenario: Public cannot rename a file in uploadwriteonly public link share with the public WebDAV API + Scenario: public cannot rename a file in upload-write-only public link share with the public WebDAV API Given user "Alice" has created a public link share with settings | path | /PARENT | | permissions | uploadwriteonly | @@ -117,7 +120,7 @@ Feature: changing a public link share And as "Alice" file "/PARENT/newparent.txt" should not exist - Scenario: Public cannot delete a file in uploadwriteonly public link share with the public WebDAV API + Scenario: public cannot delete a file in upload-write-only public link share with the public WebDAV API Given user "Alice" has created a public link share with settings | path | /PARENT | | permissions | uploadwriteonly | diff --git a/tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShare.feature b/tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShare.feature index 498990776..58e54d8ed 100644 --- a/tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShare.feature +++ b/tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShare.feature @@ -1,12 +1,15 @@ @api @issue-1276 @issue-1277 Feature: create a public link share + As a user + I want to create public links + So that I can share resources to people who aren't owncloud users Background: Given user "Alice" has been created with default attributes and without skeleton files @smokeTest - Scenario Outline: A new public link share of a file using the default permissions only grants read access using the public WebDAV API + Scenario Outline: new public link share of a file using the default permissions only grants read access using the public WebDAV API Given using OCS API version "" And user "Alice" has uploaded file with content "Random data" to "/randomfile.txt" When user "Alice" creates a public link share using the sharing API with settings @@ -37,7 +40,7 @@ Feature: create a public link share | 2 | 200 | @smokeTest @issue-1293 - Scenario Outline: Creating a new public link share of a file with password using the new public WebDAV API + Scenario Outline: creating a new public link share of a file with password using the new public WebDAV API Given using OCS API version "" And user "Alice" has uploaded file with content "Random data" to "/randomfile.txt" When user "Alice" creates a public link share using the sharing API with settings @@ -69,7 +72,7 @@ Feature: create a public link share | 2 | 200 | - Scenario Outline: Create a new public link share of a file with edit permissions + Scenario Outline: create a new public link share of a file with edit permissions Given using OCS API version "" And user "Alice" has uploaded file with content "Random data" to "/randomfile.txt" When user "Alice" creates a public link share using the sharing API with settings @@ -101,7 +104,7 @@ Feature: create a public link share | 2 | 200 | - Scenario Outline: Creating a new public link share of a folder using the default permissions only grants read access and can be accessed with no password or any password using the public WebDAV API + Scenario Outline: creating a new public link share of a folder using the default permissions only grants read access and can be accessed with no password or any password using the public WebDAV API Given using OCS API version "" And user "Alice" has created folder "/PARENT" And user "Alice" has uploaded file with content "Random data" to "/PARENT/randomfile.txt" @@ -133,7 +136,7 @@ Feature: create a public link share | 2 | 200 | - Scenario Outline: Creating a new public link share of a folder, with a password and accessing using the public WebDAV API + Scenario Outline: creating a new public link share of a folder, with a password and accessing using the public WebDAV API Given using OCS API version "" And user "Alice" has created folder "/PARENT" And user "Alice" has uploaded file with content "Random data" to "/PARENT/randomfile.txt" @@ -168,7 +171,7 @@ Feature: create a public link share | 2 | 200 | @smokeTest - Scenario Outline: Getting the share information of public link share from the OCS API does not expose sensitive information + Scenario Outline: getting the share information of public link share from the OCS API does not expose sensitive information Given using OCS API version "" And user "Alice" has uploaded file with content "Random data" to "/randomfile.txt" When user "Alice" creates a public link share using the sharing API with settings @@ -191,7 +194,7 @@ Feature: create a public link share | 2 | 200 | - Scenario Outline: Getting the share information of passwordless public-links hides credential placeholders + Scenario Outline: getting the share information of password less public-links hides credential placeholders Given using OCS API version "" And user "Alice" has uploaded file with content "Random data" to "/randomfile.txt" When user "Alice" creates a public link share using the sharing API with settings @@ -214,7 +217,7 @@ Feature: create a public link share | 2 | 200 | - Scenario Outline: Creating a link share with no specified permissions defaults to read permissions when public upload is disabled globally and accessing using the public WebDAV API + Scenario Outline: creating a link share with no specified permissions defaults to read permissions when public upload is disabled globally and accessing using the public WebDAV API Given using OCS API version "" And parameter "shareapi_allow_public_upload" of app "core" has been set to "no" And user "Alice" has created folder "/afolder" @@ -236,7 +239,7 @@ Feature: create a public link share | 2 | 200 | - Scenario Outline: Creating a link share with edit permissions keeps it using the public WebDAV API + Scenario Outline: creating a link share with edit permissions keeps it using the public WebDAV API Given using OCS API version "" And user "Alice" has created folder "/afolder" When user "Alice" creates a public link share using the sharing API with settings @@ -258,7 +261,7 @@ Feature: create a public link share | 2 | 200 | - Scenario Outline: Creating a link share with upload permissions keeps it using the public WebDAV API + Scenario Outline: creating a link share with upload permissions keeps it using the public WebDAV API Given using OCS API version "" And user "Alice" has created folder "/afolder" When user "Alice" creates a public link share using the sharing API with settings @@ -280,7 +283,7 @@ Feature: create a public link share | 2 | 200 | @issue-1265 @issue-2079 - Scenario Outline: Allow public sharing of the root on OCIS when the default permission is read and access using the public WebDAV API + Scenario Outline: allow public sharing of the root on OCIS when the default permission is read and access using the public WebDAV API Given using OCS API version "" And user "Alice" has uploaded file with content "Random data" to "/randomfile.txt" When user "Alice" creates a public link share using the sharing API with settings @@ -340,7 +343,7 @@ Feature: create a public link share | 2 | 200 | @issue-1293 - Scenario: Delete a folder that has been publicly shared and try to access using the public WebDAV API + Scenario: delete a folder that has been publicly shared and try to access using the public WebDAV API Given user "Alice" has created folder "PARENT" And user "Alice" has uploaded file with content "Random data" to "/PARENT/parent.txt" And user "Alice" has created a public link share with settings @@ -361,7 +364,7 @@ Feature: create a public link share And the HTTP status code should be "404" - Scenario: Get the size of a file shared by public link + Scenario: get the size of a file shared by public link Given user "Alice" has uploaded file with content "This is a test file" to "test-file.txt" And user "Alice" has created a public link share with settings | path | test-file.txt | @@ -371,7 +374,7 @@ Feature: create a public link share And the size of the file should be "19" - Scenario Outline: Get the mtime of a file shared by public link + Scenario Outline: get the mtime of a file shared by public link Given using DAV path And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "file.txt" with mtime "Thu, 08 Aug 2019 04:18:13 GMT" using the WebDAV API When user "Alice" creates a public link share using the sharing API with settings @@ -385,7 +388,7 @@ Feature: create a public link share | new | - Scenario Outline: Get the mtime of a file inside a folder shared by public link + Scenario Outline: get the mtime of a file inside a folder shared by public link Given using DAV path And user "Alice" has created folder "testFolder" And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "testFolder/file.txt" with mtime "Thu, 08 Aug 2019 04:18:13 GMT" using the WebDAV API @@ -400,7 +403,7 @@ Feature: create a public link share | new | - Scenario: Get the mtime of a file inside a folder shared by public link using new webDAV version + Scenario: get the mtime of a file inside a folder shared by public link using new webDAV version Given user "Alice" has created folder "testFolder" And user "Alice" has created a public link share with settings | path | /testFolder | diff --git a/tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShareToShares.feature b/tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShareToShares.feature index 6cd3e14ab..ecbd2127b 100644 --- a/tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShareToShares.feature +++ b/tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShareToShares.feature @@ -1,11 +1,14 @@ @api Feature: create a public link share when share_folder is set to Shares + As a user + I want to create public links + So that I can share resources to people who aren't owncloud users Background: Given user "Alice" has been created with default attributes and without skeleton files - Scenario Outline: Creating a new public link share of a file gives the correct response + Scenario Outline: creating a new public link share of a file gives the correct response Given using OCS API version "" And user "Alice" has uploaded file with content "Random data" to "/randomfile.txt" When user "Alice" creates a public link share using the sharing API with settings diff --git a/tests/acceptance/features/coreApiSharePublicLink1/deletePublicLinkShare.feature b/tests/acceptance/features/coreApiSharePublicLink1/deletePublicLinkShare.feature index 95ea59011..a39694509 100644 --- a/tests/acceptance/features/coreApiSharePublicLink1/deletePublicLinkShare.feature +++ b/tests/acceptance/features/coreApiSharePublicLink1/deletePublicLinkShare.feature @@ -1,11 +1,14 @@ @api Feature: delete a public link share + As a user + I want to delete a public link + So that the public won't have access to the resource inside it Background: Given user "Alice" has been created with default attributes and without skeleton files @issue-product-60 - Scenario Outline: Deleting a public link of a file + Scenario Outline: deleting a public link of a file Given using OCS API version "" And user "Alice" has uploaded file with content "This is a test file" to "test-file.txt" And user "Alice" has created a public link share with settings @@ -21,7 +24,7 @@ Feature: delete a public link share | 2 | 200 | @issue-product-60 @issue-1275 - Scenario Outline: Deleting a public link after renaming a file + Scenario Outline: deleting a public link after renaming a file Given using OCS API version "" And user "Alice" has uploaded file with content "This is a test file" to "test-file.txt" And user "Alice" has created a public link share with settings @@ -38,7 +41,7 @@ Feature: delete a public link share | 2 | 200 | @issue-product-60 - Scenario Outline: Deleting a public link of a folder + Scenario Outline: deleting a public link of a folder Given using OCS API version "" And user "Alice" has created folder "test-folder" And user "Alice" has created a public link share with settings @@ -54,7 +57,7 @@ Feature: delete a public link share | 2 | 200 | @issue-product-60 - Scenario Outline: Deleting a public link of a file in a folder + Scenario Outline: deleting a public link of a file in a folder Given using OCS API version "" And user "Alice" has created folder "test-folder" When user "Alice" uploads file "filesForUpload/textfile.txt" to "/test-folder/testfile.txt" using the WebDAV API