From c9af62305051e31feb207db8a84d83e10f830dd2 Mon Sep 17 00:00:00 2001 From: Prarup Gurung Date: Fri, 3 May 2024 15:49:42 +0545 Subject: [PATCH] changingFilesShare.feature: Used sharingNG for sharing in given step --- tests/acceptance/config/behat.yml | 1 + ...ected-failures-localAPI-on-OCIS-storage.md | 4 --- .../changingFilesShare.feature | 27 ++++++++++++++----- 3 files changed, 22 insertions(+), 10 deletions(-) diff --git a/tests/acceptance/config/behat.yml b/tests/acceptance/config/behat.yml index 9b0141652b..0edd5481d6 100644 --- a/tests/acceptance/config/behat.yml +++ b/tests/acceptance/config/behat.yml @@ -69,6 +69,7 @@ default: - ArchiverContext: - GraphContext: - OcisConfigContext: + - SharingNgContext: apiContract: paths: diff --git a/tests/acceptance/expected-failures-localAPI-on-OCIS-storage.md b/tests/acceptance/expected-failures-localAPI-on-OCIS-storage.md index 03a957d81d..25e5a37247 100644 --- a/tests/acceptance/expected-failures-localAPI-on-OCIS-storage.md +++ b/tests/acceptance/expected-failures-localAPI-on-OCIS-storage.md @@ -18,10 +18,6 @@ The expected failures in this file are from features in the owncloud/ocis repo. - [apiArchiver/downloadById.feature:165](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiArchiver/downloadById.feature#L165) - [apiArchiver/downloadById.feature:166](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiArchiver/downloadById.feature#L166) -### [PROPFIND on accepted shares with identical names containing brackets exit with 404](https://github.com/owncloud/ocis/issues/4421) - -- [apiSpacesShares/changingFilesShare.feature:14](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/changingFilesShare.feature#L14) - ### [Shared mount folder gets deleted when overwritten by a file from personal space](https://github.com/owncloud/ocis/issues/7208) - [apiSpacesShares/copySpaces.feature:512](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/copySpaces.feature#L512) diff --git a/tests/acceptance/features/apiSpacesShares/changingFilesShare.feature b/tests/acceptance/features/apiSpacesShares/changingFilesShare.feature index 03ecf63dd5..b073db9aa4 100644 --- a/tests/acceptance/features/apiSpacesShares/changingFilesShare.feature +++ b/tests/acceptance/features/apiSpacesShares/changingFilesShare.feature @@ -17,13 +17,23 @@ Feature: change shared resource And user "Alice" has created folder "/PARENT" And user "Brian" has created folder "/PARENT" And user "Alice" has moved file "textfile0.txt" to "PARENT/from_alice.txt" in space "Personal" - And user "Alice" has shared folder "/PARENT" with user "Carol" - And user "Brian" has shared folder "/PARENT" with user "Carol" + And user "Alice" has sent the following share invitation: + | resource | PARENT | + | space | Personal | + | sharee | Carol | + | shareType | user | + | permissionsRole | Viewer | + And user "Brian" has sent the following share invitation: + | resource | PARENT | + | space | Personal | + | sharee | Carol | + | shareType | user | + | permissionsRole | Viewer | When user "Carol" moves file "PARENT/from_alice.txt" to "PARENT (1)/from_alice.txt" in space "Shares" using the WebDAV API - Then the HTTP status code should be "201" - And for user "Carol" folder "PARENT" of the space "Shares" should not contain these entries: + Then the HTTP status code should be "502" + And for user "Carol" folder "PARENT" of the space "Shares" should contain these entries: | from_alice.txt | - And for user "Carol" folder "PARENT (1)" of the space "Shares" should contain these entries: + And for user "Carol" folder "PARENT (1)" of the space "Shares" should not contain these entries: | from_alice.txt | @@ -31,7 +41,12 @@ Feature: change shared resource Given the administrator has assigned the role "" to user "Brian" using the Graph API And user "Alice" has uploaded file with content "old content version 1" to "/textfile1.txt" And user "Alice" has uploaded file with content "old content version 2" to "/textfile1.txt" - And user "Alice" has shared file "/textfile1.txt" with user "Brian" + And user "Alice" has sent the following share invitation: + | resource | textfile1.txt | + | space | Personal | + | sharee | Brian | + | shareType | user | + | permissionsRole | File Editor | When user "Brian" uploads a file inside space "Shares" with content "this is a new content" to "textfile1.txt" using the WebDAV API Then the HTTP status code should be "204" And for user "Brian" the space "Shares" should contain these entries: