From ce808eaa179424da6322b5c07c17ca77e30402b0 Mon Sep 17 00:00:00 2001 From: Ralf Haferkamp Date: Mon, 25 Sep 2023 17:47:33 +0200 Subject: [PATCH] graph/education: Remove unreachable code An LDAP Modify operation never returns LDAPResultEntryAlreadyExists errors. That error can only happen for LDAPAdd or LDAPModifyDN. --- services/graph/pkg/identity/ldap_education_school.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/services/graph/pkg/identity/ldap_education_school.go b/services/graph/pkg/identity/ldap_education_school.go index 3f389a30a9..c87c4b6dd7 100644 --- a/services/graph/pkg/identity/ldap_education_school.go +++ b/services/graph/pkg/identity/ldap_education_school.go @@ -253,13 +253,7 @@ func (i *LDAP) updateSchoolProperties(ctx context.Context, dn string, currentSch } if err := i.conn.Modify(mr); err != nil { - var lerr *ldap.Error logger.Debug().Err(err).Msg("error updating school number") - if errors.As(err, &lerr) { - if lerr.ResultCode == ldap.LDAPResultEntryAlreadyExists { - err = errorcode.New(errorcode.NameAlreadyExists, lerr.Error()) - } - } return err }