From 0bf6a110f61099957935208b093b2e7b0c69e97c Mon Sep 17 00:00:00 2001 From: amrita Date: Thu, 4 May 2023 17:01:13 +0545 Subject: [PATCH] Remove skipOnLDAP tag --- .../features/apiAccountsHashDifficulty/addUser.feature | 2 +- .../createShareGroupAndUserWithSameName.feature | 8 ++++---- .../createShareReceivedInMultipleWays.feature | 2 +- .../createShareToSharesFolder.feature | 6 +++--- .../acceptShares.feature | 2 +- .../gettingShares.feature | 2 +- .../updateShareGroupAndUserWithSameName.feature | 4 ++-- .../acceptance/features/coreApiSharees/sharees.feature | 4 ++-- .../coreApiTrashbin/trashbinFilesFolders.feature | 10 +++++----- .../coreApiWebdavProperties2/getFileProperties.feature | 2 +- 10 files changed, 21 insertions(+), 21 deletions(-) diff --git a/tests/acceptance/features/apiAccountsHashDifficulty/addUser.feature b/tests/acceptance/features/apiAccountsHashDifficulty/addUser.feature index 61dcf152f6..d009b9b36a 100644 --- a/tests/acceptance/features/apiAccountsHashDifficulty/addUser.feature +++ b/tests/acceptance/features/apiAccountsHashDifficulty/addUser.feature @@ -1,4 +1,4 @@ -@api @provisioning_api-app-required @skipOnLDAP @skipOnGraph @skipOnReva +@api @provisioning_api-app-required @skipOnGraph @skipOnReva Feature: add user As an admin I want to be able to add users and store their password with the full hash difficulty diff --git a/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareGroupAndUserWithSameName.feature b/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareGroupAndUserWithSameName.feature index 816e884aff..c412610078 100644 --- a/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareGroupAndUserWithSameName.feature +++ b/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareGroupAndUserWithSameName.feature @@ -8,7 +8,7 @@ Feature: sharing works when a username and group name are the same Given auto-accept shares has been disabled And user "Alice" has been created with default attributes and without skeleton files - @skipOnLDAP + Scenario: creating a new share with user and a group having same name Given these users have been created without skeleton files: | username | @@ -30,7 +30,7 @@ Feature: sharing works when a username and group name are the same And the content of file "/Shares/randomfile.txt" for user "Brian" should be "Random data" And the content of file "/Shares/randomfile.txt" for user "Carol" should be "Random data" - @skipOnLDAP + Scenario: creating a new share with group and a user having same name Given these users have been created without skeleton files: | username | @@ -52,7 +52,7 @@ Feature: sharing works when a username and group name are the same And the content of file "/Shares/randomfile.txt" for user "Brian" should be "Random data" And the content of file "/Shares/randomfile.txt" for user "Carol" should be "Random data" - @skipOnLDAP + Scenario: creating a new share with user and a group having same name but different case Given these users have been created without skeleton files: | username | @@ -74,7 +74,7 @@ Feature: sharing works when a username and group name are the same And the content of file "/Shares/randomfile.txt" for user "Brian" should be "Random data" And the content of file "/Shares/randomfile.txt" for user "Carol" should be "Random data" - @skipOnLDAP + Scenario: creating a new share with group and a user having same name but different case Given these users have been created without skeleton files: | username | diff --git a/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareReceivedInMultipleWays.feature b/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareReceivedInMultipleWays.feature index 30b573eeeb..7e851ea3d5 100644 --- a/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareReceivedInMultipleWays.feature +++ b/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareReceivedInMultipleWays.feature @@ -166,7 +166,7 @@ Feature: share resources where the sharee receives the share in multiple ways | 1 | /zzzfolder | /zzzfolder (2) | 100 | | 2 | /zzzfolder | /zzzfolder (2) | 200 | - @skipOnLDAP @skipOnGraph + @skipOnGraph Scenario Outline: share with a group and then add a user to that group that already has a file with the shared name Given using OCS API version "" And user "Carol" has been created with default attributes and without skeleton files diff --git a/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature b/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature index 7e7d8003d3..c7bda640eb 100644 --- a/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature +++ b/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature @@ -420,7 +420,7 @@ Feature: sharing | /Shares/randomfile.txt | And the content of file "Shares/randomfile.txt" for user "brian" should be "Random data" - @skipOnLDAP + Scenario: creating a new share with user of a group when username contains capital letters Given these users have been created without skeleton files: | username | @@ -468,7 +468,7 @@ Feature: sharing | 1 | 100 | | 2 | 200 | - @skipOnLDAP @skipOnGraph + @skipOnGraph Scenario Outline: share with a group and then add a user to that group Given using OCS API version "" And these users have been created with default attributes and without skeleton files: @@ -493,7 +493,7 @@ Feature: sharing | 1 | 100 | | 2 | 200 | - @skipOnLDAP + # deleting an LDAP group is not relevant or possible using the provisioning API Scenario Outline: shares shared to deleted group should not be available Given using OCS API version "" diff --git a/tests/acceptance/features/coreApiShareManagementToShares/acceptShares.feature b/tests/acceptance/features/coreApiShareManagementToShares/acceptShares.feature index 819c0a0f33..042799f356 100644 --- a/tests/acceptance/features/coreApiShareManagementToShares/acceptShares.feature +++ b/tests/acceptance/features/coreApiShareManagementToShares/acceptShares.feature @@ -418,7 +418,7 @@ Feature: accept/decline shares coming from internal users | /textfile0.txt | | /Shares/textfile0.txt | - @skipOnLDAP + Scenario: user shares folder with matching folder name to a user before that user has logged in Given these users have been created without skeleton files and not initialized: | username | diff --git a/tests/acceptance/features/coreApiShareOperationsToShares1/gettingShares.feature b/tests/acceptance/features/coreApiShareOperationsToShares1/gettingShares.feature index f22e74c897..30699e91e3 100644 --- a/tests/acceptance/features/coreApiShareOperationsToShares1/gettingShares.feature +++ b/tests/acceptance/features/coreApiShareOperationsToShares1/gettingShares.feature @@ -150,7 +150,7 @@ Feature: sharing | 1 | 200 | | 2 | 404 | - @skipOnLDAP @issue-1289 @skipOnGraph + @issue-1289 @skipOnGraph Scenario: Share of folder to a group, remove user from that group Given using OCS API version "1" And user "Carol" has been created with default attributes and without skeleton files diff --git a/tests/acceptance/features/coreApiShareUpdateToShares/updateShareGroupAndUserWithSameName.feature b/tests/acceptance/features/coreApiShareUpdateToShares/updateShareGroupAndUserWithSameName.feature index 9d193353fd..1db05f5160 100644 --- a/tests/acceptance/features/coreApiShareUpdateToShares/updateShareGroupAndUserWithSameName.feature +++ b/tests/acceptance/features/coreApiShareUpdateToShares/updateShareGroupAndUserWithSameName.feature @@ -13,7 +13,7 @@ Feature: updating shares to users and groups that have the same name And user "Alice" has created folder "/TMP" And user "Alice" has uploaded file with content "Random data" to "/TMP/randomfile.txt" - @skipOnLDAP + Scenario Outline: update permissions of a user share with a user and a group having the same name Given using OCS API version "" And user "Alice" has shared folder "/TMP" with group "Brian" @@ -33,7 +33,7 @@ Feature: updating shares to users and groups that have the same name | 1 | 100 | | 2 | 200 | - @skipOnLDAP + Scenario Outline: update permissions of a group share with a user and a group having the same name Given using OCS API version "" And user "Alice" has shared folder "/TMP" with user "Brian" diff --git a/tests/acceptance/features/coreApiSharees/sharees.feature b/tests/acceptance/features/coreApiSharees/sharees.feature index ffe96577d6..8744a596cb 100644 --- a/tests/acceptance/features/coreApiSharees/sharees.feature +++ b/tests/acceptance/features/coreApiSharees/sharees.feature @@ -57,7 +57,7 @@ Feature: search sharees | 1 | 100 | 200 | | 2 | 200 | 200 | - @skipOnLDAP + Scenario Outline: search only with group members - allowed Given using OCS API version "" And parameter "shareapi_only_share_with_group_members" of app "core" has been set to "yes" @@ -200,7 +200,7 @@ Feature: search sharees | 1 | 100 | 200 | | 2 | 200 | 200 | - @skipOnLDAP + Scenario Outline: enumerate only group members - only show partial results from member of groups Given using OCS API version "" And these users have been created with default attributes and without skeleton files: diff --git a/tests/acceptance/features/coreApiTrashbin/trashbinFilesFolders.feature b/tests/acceptance/features/coreApiTrashbin/trashbinFilesFolders.feature index f5f036046d..eac3c7b135 100644 --- a/tests/acceptance/features/coreApiTrashbin/trashbinFilesFolders.feature +++ b/tests/acceptance/features/coreApiTrashbin/trashbinFilesFolders.feature @@ -158,7 +158,7 @@ Feature: files and folders exist in the trashbin after being deleted | dav-path | | spaces | - @issue-3561 @skipOnLDAP + @issue-3561 Scenario Outline: Listing other user's trashbin is prohibited Given using DAV path And user "testtrashbin100" has been created with default attributes and without skeleton files @@ -176,7 +176,7 @@ Feature: files and folders exist in the trashbin after being deleted | new | 404 | | spaces | 404 | - @issue-3561 @smokeTest @skipOnLDAP + @issue-3561 @smokeTest Scenario Outline: Listing other user's trashbin is prohibited with multiple files on trashbin Given using DAV path And user "testtrashbin101" has been created with default attributes and without skeleton files @@ -197,7 +197,7 @@ Feature: files and folders exist in the trashbin after being deleted | new | 404 | | spaces | 404 | - @issue-3561 @skipOnLDAP @provisioning_api-app-required + @issue-3561 @provisioning_api-app-required Scenario Outline: Listing other user's trashbin is prohibited for newly recreated user with same name Given using DAV path And user "testtrashbin102" has been created with default attributes and without skeleton files @@ -223,7 +223,7 @@ Feature: files and folders exist in the trashbin after being deleted | new | 404 | | spaces | 404 | - @issue-3561 @skipOnLDAP + @issue-3561 Scenario Outline: Listing other user's empty unused trashbin is prohibited Given using DAV path And user "testtrashbinempty" has been created with default attributes and without skeleton files @@ -239,7 +239,7 @@ Feature: files and folders exist in the trashbin after being deleted | dav-path | | spaces | - @issue-3561 @skipOnLDAP + @issue-3561 Scenario Outline: Listing non-existent user's trashbin is prohibited Given using DAV path When user "Alice" tries to list the trashbin content for user "testtrashbinnotauser" diff --git a/tests/acceptance/features/coreApiWebdavProperties2/getFileProperties.feature b/tests/acceptance/features/coreApiWebdavProperties2/getFileProperties.feature index 12385b1ada..0cb75774dd 100644 --- a/tests/acceptance/features/coreApiWebdavProperties2/getFileProperties.feature +++ b/tests/acceptance/features/coreApiWebdavProperties2/getFileProperties.feature @@ -243,7 +243,7 @@ Feature: get file properties | dav_version | | spaces | - @skipOnLDAP @user_ldap-issue-268 + Scenario Outline: A file that is shared by user,group and link has a share-types property Given using DAV path And user "Brian" has been created with default attributes and without skeleton files