From 821069d19095fde9c16aabdeaef494b4f7a31f91 Mon Sep 17 00:00:00 2001 From: "sagargurung1001@gmail.com" Date: Tue, 20 Dec 2022 16:19:31 +0545 Subject: [PATCH 1/3] Extend Propfind of space to space-member --- .../features/apiContract/propfind.feature | 22 ++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/tests/acceptance/features/apiContract/propfind.feature b/tests/acceptance/features/apiContract/propfind.feature index ff1ccbf4eb..6d8ec92c88 100644 --- a/tests/acceptance/features/apiContract/propfind.feature +++ b/tests/acceptance/features/apiContract/propfind.feature @@ -6,12 +6,13 @@ Feature: Propfind test Given these users have been created with default attributes and without skeleton files: | username | | Alice | + | Brian | And using spaces DAV path And the administrator has given "Alice" the role "Space Admin" using the settings api And user "Alice" has created a space "new-space" with the default quota using the GraphApi - Scenario: check the PROPFIND request of a space + Scenario: space-admin check the PROPFIND request of a space Given user "Alice" has uploaded a file inside space "new-space" with content "some content" to "testfile.txt" When user "Alice" sends PROPFIND request to space "new-space" using the WebDAV API Then the HTTP status code should be "207" @@ -22,3 +23,22 @@ Feature: Propfind test | oc:permissions | SRDNVCKZ | | oc:privatelink | | | oc:size | 12 | + + + Scenario Outline: space member with different role check the PROPFIND request of a space + Given user "Alice" has uploaded a file inside space "new-space" with content "some content" to "testfile.txt" + And user "Alice" has shared a space "new-space" to user "Brian" with role "" + When user "Brian" sends PROPFIND request to space "new-space" using the WebDAV API + Then the HTTP status code should be "207" + And for user "Alice" the "PROPFIND" response should contain a space "new-space" with these key and value pairs: + | key | value | + | oc:fileid | UUIDof:new-space | + | oc:name | new-space | + | oc:permissions | | + | oc:privatelink | | + | oc:size | 12 | + Examples: + | role | oc_permission | + | manager | SRDNVCKZ | + | editor | SDNVCK | + | viewer | S | From 3ca033dab7ccb6856b13a104773592b236b813da Mon Sep 17 00:00:00 2001 From: "sagargurung1001@gmail.com" Date: Wed, 21 Dec 2022 16:33:11 +0545 Subject: [PATCH 2/3] Addressed review --- tests/acceptance/features/apiContract/propfind.feature | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/acceptance/features/apiContract/propfind.feature b/tests/acceptance/features/apiContract/propfind.feature index 6d8ec92c88..a6d4575214 100644 --- a/tests/acceptance/features/apiContract/propfind.feature +++ b/tests/acceptance/features/apiContract/propfind.feature @@ -12,7 +12,7 @@ Feature: Propfind test And user "Alice" has created a space "new-space" with the default quota using the GraphApi - Scenario: space-admin check the PROPFIND request of a space + Scenario: space-admin checks the PROPFIND request of a space Given user "Alice" has uploaded a file inside space "new-space" with content "some content" to "testfile.txt" When user "Alice" sends PROPFIND request to space "new-space" using the WebDAV API Then the HTTP status code should be "207" @@ -25,12 +25,12 @@ Feature: Propfind test | oc:size | 12 | - Scenario Outline: space member with different role check the PROPFIND request of a space + Scenario Outline: space member with a different role checks the PROPFIND request of a space Given user "Alice" has uploaded a file inside space "new-space" with content "some content" to "testfile.txt" And user "Alice" has shared a space "new-space" to user "Brian" with role "" When user "Brian" sends PROPFIND request to space "new-space" using the WebDAV API Then the HTTP status code should be "207" - And for user "Alice" the "PROPFIND" response should contain a space "new-space" with these key and value pairs: + And for user "Brian" the "PROPFIND" response should contain a space "new-space" with these key and value pairs: | key | value | | oc:fileid | UUIDof:new-space | | oc:name | new-space | From 9a86777df6f091a7fdcda0c9e2da2bd4de71f21e Mon Sep 17 00:00:00 2001 From: "sagargurung1001@gmail.com" Date: Wed, 28 Dec 2022 09:31:01 +0545 Subject: [PATCH 3/3] Rebase and review address --- tests/acceptance/features/apiContract/propfind.feature | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/acceptance/features/apiContract/propfind.feature b/tests/acceptance/features/apiContract/propfind.feature index a6d4575214..13cebf83fe 100644 --- a/tests/acceptance/features/apiContract/propfind.feature +++ b/tests/acceptance/features/apiContract/propfind.feature @@ -30,7 +30,7 @@ Feature: Propfind test And user "Alice" has shared a space "new-space" to user "Brian" with role "" When user "Brian" sends PROPFIND request to space "new-space" using the WebDAV API Then the HTTP status code should be "207" - And for user "Brian" the "PROPFIND" response should contain a space "new-space" with these key and value pairs: + And the "PROPFIND" response should contain a space "new-space" with these key and value pairs: | key | value | | oc:fileid | UUIDof:new-space | | oc:name | new-space |