From dfd6bfa2cc6c07b9c53fc3d1331183751cab00e2 Mon Sep 17 00:00:00 2001 From: "A.Unger" Date: Tue, 10 Mar 2020 15:15:22 +0100 Subject: [PATCH] add tracing --- pkg/command/server.go | 8 ++++++-- pkg/flagset/flagset.go | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/pkg/command/server.go b/pkg/command/server.go index cc15cc1cb9..4af0d56db9 100644 --- a/pkg/command/server.go +++ b/pkg/command/server.go @@ -70,6 +70,10 @@ func Server(cfg *config.Config) *cli.Command { }, ) + logger.Info(). + Str("collector", cfg.Tracing.Collector). + Msg("Trace collector added") + if err != nil { logger.Error(). Err(err). @@ -137,8 +141,8 @@ func Server(cfg *config.Config) *cli.Command { http.Context(ctx), http.Config(cfg), http.Metrics(metrics), - http.Flags(flagset.RootWithConfig(cfg)), - http.Flags(flagset.ServerWithConfig(cfg)), + http.Flags(flagset.RootWithConfig(config.New())), + http.Flags(flagset.ServerWithConfig(config.New())), ) if err != nil { diff --git a/pkg/flagset/flagset.go b/pkg/flagset/flagset.go index 2247c45d33..96a97cd788 100644 --- a/pkg/flagset/flagset.go +++ b/pkg/flagset/flagset.go @@ -57,6 +57,7 @@ func ServerWithConfig(cfg *config.Config) []cli.Flag { return []cli.Flag{ &cli.BoolFlag{ Name: "tracing-enabled", + Value: false, Usage: "Enable sending traces", EnvVars: []string{"OCS_TRACING_ENABLED"}, Destination: &cfg.Tracing.Enabled,