mirror/opencloud
1
0
Fork 0
mirror of https://github.com/opencloud-eu/opencloud.git synced 2026-02-25 06:58:59 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix: ensure thumbnail is written into disk

Browse Source
This commit is contained in:
Juan Pablo Villafáñez
2024-12-03 10:52:05 +01:00
parent ce3d9c13f5
commit f3d91f8c69
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
services/thumbnails/pkg/thumbnail/storage/filesystem.go
View File

@@ -66,25 +66,28 @@ func (s FileSystem) Put(key string, img []byte) error {
if err != nil {
return errors.Wrapf(err, "could not create temporary file for \"%s\"", key)
}
_, writeErr := f.Write(img) // write the thumbnail in the temporary file
f.Close() // close the file regardless of the error
defer f.Close()
// if there was a problem writing, remove the temporary file
if writeErr != nil {
if _, writeErr := f.Write(img); writeErr != nil {
if remErr := os.Remove(f.Name()); remErr != nil {
return errors.Wrapf(remErr, "could not cleanup temporary file for \"%s\"", key)
}
return errors.Wrapf(writeErr, "could not write to temporary file for \"%s\"", key)
}
// if there wasn't a problem, ensure the data is written into disk
if synErr := f.Sync(); synErr != nil {
return errors.Wrapf(synErr, "could not sync temporary file data into the disk for \"%s\"", key)
}
// rename the temporary file to the final file
if renErr := os.Rename(f.Name(), imgPath); renErr != nil {
// if we couldn't rename, remove the temporary file
if remErr := os.Remove(f.Name()); remErr != nil {
return errors.Wrapf(remErr, "rename failed and could not cleanup temporary file for \"%s\"", key)
}
return errors.Wrapf(err, "could not rename temporary file to \"%s\"", key)
return errors.Wrapf(renErr, "could not rename temporary file to \"%s\"", key)
}
}