From fe84b83617232d502c27338277d1e3570774f49c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Sw=C3=A4rd?= Date: Thu, 27 Jul 2023 11:52:11 +0200 Subject: [PATCH] Separate out grpc client to package local for webdav service. --- services/webdav/pkg/command/server.go | 2 +- services/webdav/pkg/config/config.go | 2 ++ services/webdav/pkg/service/v0/service.go | 5 ++--- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/services/webdav/pkg/command/server.go b/services/webdav/pkg/command/server.go index dcd4d99cec..9a2dcdb78b 100644 --- a/services/webdav/pkg/command/server.go +++ b/services/webdav/pkg/command/server.go @@ -33,7 +33,7 @@ func Server(cfg *config.Config) *cli.Command { if err != nil { return err } - err = ogrpc.Configure(ogrpc.GetClientOptions(cfg.GRPCClientTLS)...) + cfg.GrpcClient, err = ogrpc.NewClient(ogrpc.GetClientOptions(cfg.GRPCClientTLS)...) if err != nil { return err } diff --git a/services/webdav/pkg/config/config.go b/services/webdav/pkg/config/config.go index 3edbb56fe2..7b2c887780 100644 --- a/services/webdav/pkg/config/config.go +++ b/services/webdav/pkg/config/config.go @@ -4,6 +4,7 @@ import ( "context" "github.com/owncloud/ocis/v2/ocis-pkg/shared" + "go-micro.dev/v4/client" ) // Config combines all available configuration parts. @@ -17,6 +18,7 @@ type Config struct { Debug Debug `yaml:"debug"` GRPCClientTLS *shared.GRPCClientTLS `yaml:"grpc_client_tls"` + GrpcClient client.Client `yaml:"-"` HTTP HTTP `yaml:"http"` diff --git a/services/webdav/pkg/service/v0/service.go b/services/webdav/pkg/service/v0/service.go index f60b75a62c..3d5f0d03b7 100644 --- a/services/webdav/pkg/service/v0/service.go +++ b/services/webdav/pkg/service/v0/service.go @@ -19,7 +19,6 @@ import ( "github.com/go-chi/render" "github.com/owncloud/ocis/v2/ocis-pkg/log" "github.com/owncloud/ocis/v2/ocis-pkg/registry" - "github.com/owncloud/ocis/v2/ocis-pkg/service/grpc" thumbnailsmsg "github.com/owncloud/ocis/v2/protogen/gen/ocis/messages/thumbnails/v0" searchsvc "github.com/owncloud/ocis/v2/protogen/gen/ocis/services/search/v0" thumbnailssvc "github.com/owncloud/ocis/v2/protogen/gen/ocis/services/thumbnails/v0" @@ -77,8 +76,8 @@ func NewService(opts ...Option) (Service, error) { config: conf, log: options.Logger, mux: m, - searchClient: searchsvc.NewSearchProviderService("com.owncloud.api.search", grpc.DefaultClient()), - thumbnailsClient: thumbnailssvc.NewThumbnailService("com.owncloud.api.thumbnails", grpc.DefaultClient()), + searchClient: searchsvc.NewSearchProviderService("com.owncloud.api.search", conf.GrpcClient), + thumbnailsClient: thumbnailssvc.NewThumbnailService("com.owncloud.api.thumbnails", conf.GrpcClient), gatewaySelector: gatewaySelector, }