Commit Graph

128 Commits

Author SHA1 Message Date
Ralf Haferkamp
e0cf17d5e5 Fix thumbnails status code
Return 403 instead of 500 when the image is too large (in dimensions or file
size).

Fixes: #10589
2024-11-18 16:18:18 +01:00
jkoberg
2b8b853c4d feat(thumbnails): make ggp thumbnails work
Signed-off-by: jkoberg <jkoberg@owncloud.com>
2024-11-07 17:18:28 +01:00
jkoberg
1571d39a74 feat(thumbnails): add ggp test file
Signed-off-by: jkoberg <jkoberg@owncloud.com>
2024-11-06 19:32:08 +01:00
jkoberg
02196da2e0 feat(thumbnails): allow thumbnails on ggp files
Signed-off-by: jkoberg <jkoberg@owncloud.com>
2024-11-06 19:32:08 +01:00
Jörn Friedrich Dreyer
a79e3b3f63 Merge pull request #10412 from owncloud/fix-signal-handling
Fix signal handling
2024-10-28 15:24:35 +01:00
Jörn Friedrich Dreyer
dde999d5c2 align shutdown logging
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
2024-10-28 14:47:11 +01:00
Martin Mattel
31e728af10 [docs-only] Add libvips build dependencies for macOS 2024-10-28 11:33:19 +01:00
Michael Barz
35578a0ecc chore: remove unneeded stuff 2024-10-21 22:46:06 +02:00
Ralf Haferkamp
e43a858808 Fix libvips thumbnail generation for text files 2024-10-17 14:05:27 +02:00
Ralf Haferkamp
b63676ff93 Fix GeoGebra thumbnails when libvips support is enabled
For GeoGebra files we where still using the imaging package to decode the
embedded png, but handed it of to vips for scaling, which can't work. Now
we use vips for decoding the image as well.
2024-10-17 14:05:27 +02:00
Ralf Haferkamp
2feb1ab0cf Apply suggestions from proof reading
Co-authored-by: Martin <github@diemattels.at>
2024-10-17 14:05:27 +02:00
Ralf Haferkamp
eb7168ddb5 Changelog entry and Readme updates related to libvips 2024-10-17 14:05:27 +02:00
Ralf Haferkamp
a9a5570050 feat(thumbnails): optional libvips based thumbnail generation
Can be enabled by setting the 'enable_vips' tag on 'go build'
2024-10-17 14:05:27 +02:00
Ralf Haferkamp
358adc15dc refactor(thumbnails): separate out 'kovidgoyal/imaging' dependencies
Move code using the 'kovidgoyal/imaging' package to separate files
to make it easier to create alternative implementations based on build
tags.
2024-10-17 14:05:27 +02:00
Ralf Haferkamp
d0ce57dfc2 refactor(thumbnails): merge processor into generator
Processor is now part of the generator. This should make it possible
to implement thumbnail generators that do not depend on the 'imaging'
module.
2024-10-17 14:05:27 +02:00
Florian Schade
66ff86bd35 enhancement: simplify ready and health check handler usage 2024-10-16 20:26:00 +02:00
Christian Richter
49cf9b0859 add grpc checker to search, settings & thumbnails
Signed-off-by: Christian Richter <crichter@owncloud.com>
2024-10-15 16:44:42 +02:00
Christian Richter
dcce0bc9bc add http checks to sse & thumbnails
Signed-off-by: Christian Richter <crichter@owncloud.com>
2024-10-15 13:57:39 +02:00
Christian Richter
0094d30378 code cleanup & refactoring
Signed-off-by: Christian Richter <crichter@owncloud.com>
2024-10-14 08:39:42 +02:00
Florian Schade
0671039474 enhancement: add readyz and healthz check handler 2024-10-14 08:39:42 +02:00
Florian Schade
c82a7c560e enhancement: use global ready and health handlers 2024-10-14 08:39:42 +02:00
Ralf Haferkamp
e2d7251893 fix(thumbnails): Implement ratelimit for the grpc service
This moves the ratelimit ('THUMBNAILS_MAX_CONCURRENT_REQUESTS') from the
HTTP endpoint to the GRPC endpoint. The HTTP endpoint is just used for
downloading already created thumbnails. But the resource consuming part of
thumbnail generation happens in the GRPC service.
2024-10-09 14:15:54 +02:00
Ralf Haferkamp
0b53c48bd9 fix(thumbnails): don't re-create thumbnails if they already exist
A previous cleanup introduced a bug which caused thumbnails to be
re-created even if we already had a matching thumbnail in the storage.
2024-10-08 10:37:36 +02:00
Ralf Haferkamp
86fa6a9cde Revert "remove obsolete var"
This reverts commit a145c36fd5.
2024-10-08 10:37:36 +02:00
Juergen Weigert
0d719a7c72 fix: more colons after variables found.
cd owncloud/ocis/services
vi $(grep -l -r '[A-Z][A-Z][A-Z]:/')
2024-10-02 09:09:47 +02:00
Ralf Haferkamp
109b23966c bump some jwt related go modules to current version
go-jwt/jwt to v5.2.1
MicahParks/keyfunc to v2.1.0
2024-08-26 15:35:15 +02:00
Jörn Friedrich Dreyer
066c4b8173 only register signal handling once
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
2024-07-29 16:28:13 +02:00
Jörn Friedrich Dreyer
7999e2969b do not force exit to let all services shutdown gracefully
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
2024-07-24 14:02:52 +02:00
Jörn Friedrich Dreyer
9d1515e8fc rely on context from app
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
2024-07-24 14:02:11 +02:00
Jörn Friedrich Dreyer
008f379a01 pass config context when running apps
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
2024-07-24 13:30:42 +02:00
Jörn Friedrich Dreyer
7a22dfb6de NotifyContext when running services standalone
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
2024-07-24 13:26:58 +02:00
Benedikt Kulmann
6b697d77ba feat: thumbnail service CORS config 2024-07-09 11:33:56 +02:00
Michael Barz
b04f3209d4 chore: prepare release, bump version 2024-06-19 19:45:57 +02:00
Benedikt Kulmann
6117e19d4f fix: thumbnail max input height
Thumbnail max input width and height need to be the same, because images
can be portrait or landscape. See https://github.com/owncloud/ocis/issues/9234
2024-06-12 10:55:26 +02:00
Michael Barz
b892a9ab28 Merge pull request #9312 from owncloud/var-placeholders
docs: use placeholder for next release
2024-06-05 21:36:25 +02:00
Martin
b9a1dc1943 Update thumbnail README.md with respect to SecureView
Referencing: owncloud/ocis#9299 (Thumbnailer respect secure view)

Adding a short sentence about the thumbnail behavior when using SecureView.
2024-06-05 11:34:05 +02:00
Christian Richter
b3db1354ec Merge pull request #9299 from dragonchaser/thumbnailer-respect-secure-view
Thumbnailer respect secure view
2024-06-04 16:26:25 +02:00
Christian Richter
a145c36fd5 remove obsolete var
Signed-off-by: Christian Richter <crichter@owncloud.com>
2024-06-04 12:10:01 +02:00
Christian Richter
db308bea5c try to remove code duplications
Signed-off-by: Christian Richter <crichter@owncloud.com>
2024-06-04 11:24:55 +02:00
Michael Barz
5d99688161 docs: use placeholder for next release 2024-06-04 10:28:42 +02:00
Christian Richter
1012a399ae Don't show thumbnails for secureview shares
Co-authored-by: Julian Koberg <jkoberg@owncloud.com>

Signed-off-by: Christian Richter <crichter@owncloud.com>
2024-06-03 14:04:46 +02:00
mmattel
c1c0037a75 [docs-only] fix two service readme's 2024-06-03 11:55:46 +02:00
Martin
82e614ec50 Update thumbnails README.md
References: #9199 (feat: limit concurrent processing of thumbnail requests)

Content fix:
- If NO thumbnail is available, we return 404 (and not if it is avaialble)
- Make the resolution list multi-lined again for improved readbility
2024-06-03 09:25:42 +02:00
Thomas Müller
e79d63208e feat: limit concurrent processing of thumbnail requests 2024-05-21 14:12:50 +02:00
Thomas Müller
06bb8c9654 feat: add maximum image file size to be processed by the thumbnailer (#9069) 2024-05-08 16:28:44 +02:00
Thomas Müller
9db3fd028e feat: add maximum image dimension to be processed by the thumbnailer (#9035)
* feat: add maximum image dimension to be processed by the thumbnailer

* chore: make golangci-lint happy
2024-05-03 12:20:27 +02:00
Thomas Müller
a8cbc612cc chore: remove unused return value from BindSourcesToStructs (#9033) 2024-04-30 18:18:31 +02:00
Jörn Friedrich Dreyer
32e44a9fdc Merge pull request #8989 from owncloud/log-and-trace-fixes
log and trace fixes
2024-04-29 17:13:52 +02:00
Jörn Friedrich Dreyer
e41472234f log and trace fixes
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
2024-04-26 17:03:49 +02:00
Thomas Müller
a53a7cf8b5 fix: replace github.com/disintegration/imaging with github.com/kovidgoyal/imaging 2024-04-26 11:36:49 +02:00